Modify

Opened 10 months ago

Closed 10 months ago

Last modified 10 months ago

#13682 closed enhancement (fixed)

Discard converted_by?

Reported by: naoliv Owned by: naoliv
Priority: normal Milestone: 16.10
Component: Core Version:
Keywords: discard converted_by tag Cc:

Description

Since JOSM already removes created_by and other tags while modifying some objects, shouldn't converted_by also be discarded?

For example, http://osm.mapki.com/history/way.php?id=10938317

JOSM

Build-Date:2016-09-21 21:43:56
Revision:11038
Is-Local-Build:true

Identification: JOSM/1.5 (11038 SVN pt_BR) Linux Debian GNU/Linux testing (stretch)
Memory Usage: 247 MB / 10206 MB (141 MB allocated, but free)
Java version: 1.8.0_102-8u102-b14.1-2-b14, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 1600x900, :0.1 1280x1024
Maximum Screen Size: 1600x1024
Java package: openjdk-8-jre:amd64-8u102-b14.1-2
Java ATK Wrapper package: libatk-wrapper-java:all-0.33.3-9
VM arguments: [-Dawt.useSystemAAFontSettings=on]

Attachments (0)

Change History (10)

comment:1 Changed 10 months ago by Klumbumbus

I think this should be discussed before on a bigger audience e.g. forum, tagging mailing list what this tag is about and if it should be deleted.

comment:2 Changed 10 months ago by naoliv

Right.
I will ask on tagging.

comment:3 Changed 10 months ago by Klumbumbus

Owner: changed from team to naoliv
Status: newneedinfo

comment:4 Changed 10 months ago by Don-vip

Keywords: discard converted_by tag added

comment:5 Changed 10 months ago by stoecker

That was never a standard tag. And it's only about 100.000 times in the database. On the other hand some of the stuff we drop has much less remaining entries (e.g sub_sea:type). There aren't any useful values for that tag, so probably dropping it is ok.

comment:7 Changed 10 months ago by stoecker

Resolution: fixed
Status: needinfoclosed

In 11064/josm:

fix #13682 - silently drop also converted_by

comment:8 Changed 10 months ago by stoecker

In 11065/josm:

see #13682 - silently drop also converted_by - remove duplicate

comment:9 Changed 10 months ago by stoecker

Milestone: 16.09

Then we do it the JOSM way and simply decide ourself. And get the blame for it when somebody complains. Anyway we already handled it as throw away tag in the checks.

comment:10 Changed 10 months ago by simon04

Milestone: 16.0916.10

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain naoliv.
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.