Opened 5 years ago
Closed 4 years ago
#1361 closed defect (fixed)
[PATCH] Relation dialog: "Download inclomplete..." blocks JOSM if OSM does not respond
| Reported by: | geoj@… | Owned by: | framm |
|---|---|---|---|
| Priority: | major | Component: | Core |
| Version: | latest | Keywords: | relation editor |
| Cc: | karl.guggisberg@… |
Description
Sometimes download requests to the OSM server can take quite a long time. The usual download dialog allows therefore to cancel requests, but not the relation editor dialog. If you execute the function "Download all incomplete ways and nodes in relation" JOSM is blocked until the OSM server sends a result.
I strongly recommend using the download dialog here as well, therefore the user can decide to cancel a request and try again later or just continue the current edit.
I already had the case that I had to kill JOSM because of this problem. Luckily all modifications were already committed...
Attachments (2)
Change History (7)
comment:1 Changed 4 years ago by Michi
Changed 4 years ago by Michi
Changed 4 years ago by Michi
comment:2 Changed 4 years ago by Michi
I just looked at the sources, and I think there is an nicer solution than setting topmost to false: Not using the parent window as parentComponent. But since I'm not very versed with Java, I'm not sure if that works. So I attached a patch for both of my resolutions.
comment:3 Changed 4 years ago by stoecker
- Summary changed from Relation dialog: "Download inclomplete..." blocks JOSM if OSM does not respond to [PATCH] Relation dialog: "Download inclomplete..." blocks JOSM if OSM does not respond
comment:4 Changed 4 years ago by stoecker
Ticket #2876 has been marked as a duplicate of this ticket.
comment:5 Changed 4 years ago by Gubaer
- Cc karl.guggisberg@… added
- Resolution set to fixed
- Status changed from new to closed
fixed in r1764
This just happend to me. Not because the download stalled, but because I had some conflicts after downloading. The relation dialog is topmost (at least on Windows), so the modal conflict message box is behind the window. And since it is modal, I could not move the relation editor window away.
I thought I lost my work (> 800 changes to the DB), but I managed to confirm the conflict message by pressing ESC. Phew! ;-)
So, my suggestion is to disable the topmost feature of the realtion editor window, or at least disabling it while downloading missing relation members.