Modify

Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#13515 closed enhancement (fixed)

Add building=ruins and natural=shingle

Reported by: Don-vip Owned by: Klumbumbus
Priority: normal Milestone: 16.10
Component: Internal preset Version:
Keywords: ruin building natural shingle Cc:

Description (last modified by Don-vip)

building=ruins is now used more than 10k times, used globally, well documented.

Looks like a good candidate for a new "Ruined building" internal preset?

http://taginfo.openstreetmap.org/tags/building=ruins#map
http://wiki.openstreetmap.org/wiki/Tag:building%3Druins

Same for natural=shingle

http://taginfo.openstreetmap.org/tags/?key=natural&value=shingle#map
http://wiki.openstreetmap.org/wiki/Tag:natural%3Dshingle

Attachments (0)

Change History (11)

comment:1 by Klumbumbus, 8 years ago

In 10935/josm:

see #13515 - add some tags to validator ignore list

comment:2 by Klumbumbus, 8 years ago

I fixed the unit test for now. I will remove it from the ignore list when I add it to the preset.

comment:3 by Klumbumbus, 8 years ago

I think it is enough to just add the value to the existing general building preset.

in reply to:  3 comment:4 by Don-vip, 8 years ago

Replying to Klumbumbus:

I think it is enough to just add the value to the existing general building preset.

yep

comment:5 by Don-vip, 8 years ago

Description: modified (diff)
Keywords: natural shingle added
Summary: Add building=ruins ?Add building=ruins and natural=shingle

comment:6 by Klumbumbus, 8 years ago

Looks like half of the shingles comes from an import in new zealand https://www.openstreetmap.org/#map=15/-43.8651/170.1600 http://taginfo.openstreetmap.org/tags/?key=natural&value=shingle#combinations

However I think we can add it anyway.

Last edited 8 years ago by Klumbumbus (previous) (diff)

comment:7 by Don-vip, 8 years ago

In 10951/josm:

see #13515 - ignore natural=shingle for 16.08 release

comment:8 by Klumbumbus, 8 years ago

Resolution: fixed
Status: newclosed

In 10996/josm:

fix #13515 - add building=ruins and natural=shingle to preset and mappaint style; new isons for shingle and scree self created CC0 and PD licensed

comment:9 by Klumbumbus, 8 years ago

In 11005/josm:

fix #13515 - add aeroway=holding_position to preset and mappaint style; new icon self created, derived from taxiway icon, CC0 and PD licensed

comment:10 by Klumbumbus, 7 years ago

In 11034/josm:

see #13515 - improve natural=shingle icon for 16px

comment:11 by simon04, 7 years ago

Milestone: 16.0916.10

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Klumbumbus.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.