Modify

Opened 18 months ago

Last modified 2 weeks ago

#13474 new defect

Upload comment and source get reset to previous values

Reported by: SanderH Owned by: team
Priority: major Milestone:
Component: Core Version:
Keywords: template_report upload comment source changeset Cc: josm@…

Description

What steps will reproduce the problem?

  1. Make a change in OSM
  2. Upload the change with upload comment and source 'first'
  3. Make another change in OSM
  4. Upload the change and change the comment and source to 'second' on the Settings tab
  5. On the changesets tab, choose to upload to a new changeset instead of the existing changeset
  6. On the Settings tab, both the comment and source is reset to 'first'

What is the expected result?

I expect the changed upload comment and source to be retained when choosing to upload to a new changeset.
It's natural to fill the dialog from left to right, so first filling in the Settings tab, then the Changeset tab.

What happens instead?

The just entered upload comment is gone and replaced by the previous upload comment.

Please provide any additional information below. Attach a screenshot if possible.

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-08-11 21:54:24 +0200 (Thu, 11 Aug 2016)
Build-Date:2016-08-11 22:36:05
Revision:10786
Relative:URL: ^/trunk

Identification: JOSM/1.5 (10786 en) Windows 10 64-Bit
Memory Usage: 2015 MB / 2015 MB (1136 MB allocated, but free)
Java version: 1.8.0_102-b14, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:<java.home>\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=%UserProfile%\AppData\LocalLow\Sun\Java\Deployment\cache\6.0\56\1ee8cfb8-5ee29e1d, -Djnlpx.remove=false, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.splashport=10071, -Djnlp.application.href=https://josm.openstreetmap.de/download/josm.jnlp, -Djnlpx.jvm=<java.home>\bin\javaw.exe, -Djnlpx.vmargs=LURqYXZhLnV0aWwuQXJyYXlzLnVzZUxlZ2FjeU1lcmdlU29ydD10cnVlAC1Eam5scC5hcHBsaWNhdGlvbi5ocmVmPWh0dHBzOi8vam9zbS5vcGVuc3RyZWV0bWFwLmRlL2Rvd25sb2FkL2pvc20uam5scAA=]
Dataset consistency test: No problems found

Attachments (0)

Change History (6)

comment:1 Changed 18 months ago by Don-vip

Keywords: upload comment source added

comment:2 Changed 18 months ago by Don-vip

Keywords: changeset added

comment:3 Changed 9 months ago by michael2402

I could not reproduce. It is probably fixed in r12265.

comment:4 Changed 9 months ago by SanderH

Could still replicate the issue in 12306

comment:5 Changed 2 weeks ago by Don-vip

Ticket #15879 has been marked as a duplicate of this ticket.

comment:6 Changed 2 weeks ago by Don-vip

Cc: josm@… added
Priority: normalmajor

From #15879:

Click the upload button on the toolbar
Type a changeset comment and then press Ctrl+Enter

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to SanderH
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.