Modify

Attachments (1)

old_and_new_icon_paths.xlsx (27.4 KB) - added by Klumbumbus 15 months ago.
404 new icon paths

Download all attachments as: .zip

Change History (41)

comment:1 Changed 15 months ago by Klumbumbus

Summary: replace png icons by svg from osm svn source and sort iconsreplace png icons by svg from osm svn source, sort icons and remove duplicates

comment:2 Changed 15 months ago by Klumbumbus

Milestone: 16.0816.07

Patch is ready, I will commit it today. (This should be in milestone 16.07 to not break external styles/presets for tested users for a long time.)

comment:3 Changed 15 months ago by Klumbumbus

In 10706/josm:

see #13217 - replace about 166 png icons by svg from https://trac.openstreetmap.org/browser/subversion/applications/share/map-icons/svg reworked most of them (white background or halo, resizing, pixel alignement), draw a few new svg icons from png derived; remove duplicate icons; reorder icons; adapt internal preset and mappaint styles

comment:4 Changed 15 months ago by Klumbumbus

Some stats:

In images folder there are now:

  • 564 png files
  • 569 svg files
  • 1133 total

For the images/presets folder the numbers are:

  • 162 png files
  • 508 svg files
  • 670 total

comment:5 Changed 15 months ago by bastiK

Great work!

In the mapcss style, we now rely on the fact that big images get scaled down to 16x16 px. As this value is hardcoded and somewhat arbitrary, I wonder if this could be specified explicitly? Would it help to have a new MapCSS feature for this?

E.g. icon-size: 16; could be used to scale an image proportionally, such that the larger of the two dimensions (width / height) is 16 px.
Or icon-max-size: 16; - the same, only that an image smaller that 16 px remains unscaled.

comment:6 Changed 15 months ago by Klumbumbus

In 10707/josm:

see #13217 - fix some icons; see #13204 - add reef mappaint style and icon (https://openclipart.org/detail/172292/corals, modified, PD, CC0)

comment:7 Changed 15 months ago by Klumbumbus

In 10709/josm:

see #13217, see #13204 - fix two icons

comment:8 Changed 15 months ago by Klumbumbus

Description: modified (diff)

comment:9 Changed 15 months ago by Klumbumbus

Description: modified (diff)

comment:10 Changed 15 months ago by Klumbumbus

Description: modified (diff)

comment:11 Changed 15 months ago by Klumbumbus

Description: modified (diff)

comment:12 Changed 15 months ago by Klumbumbus

Description: modified (diff)

comment:13 Changed 15 months ago by Klumbumbus

Description: modified (diff)

comment:14 Changed 15 months ago by Klumbumbus

Description: modified (diff)

comment:15 Changed 15 months ago by Klumbumbus

Description: modified (diff)

Changed 15 months ago by Klumbumbus

Attachment: old_and_new_icon_paths.xlsx added

404 new icon paths

comment:16 Changed 15 months ago by Klumbumbus

Description: modified (diff)

comment:17 in reply to:  5 Changed 15 months ago by Klumbumbus

Replying to bastiK:

E.g. icon-size: 16; could be used to scale an image proportionally, such that the larger of the two dimensions (width / height) is 16 px.

Would be nice, so you don't need to care about which one (width or height) is bigger, but I don't see this as high priority.

The more confusing (and error-prone) part is that svg icons between 16 and 64(?) px don't scale down, while bigger ones scale down again. Therefore I resized several icons in r10706.

comment:18 Changed 15 months ago by Klumbumbus

Description: modified (diff)

comment:19 Changed 15 months ago by Klumbumbus

Description: modified (diff)

comment:20 Changed 15 months ago by Klumbumbus

Description: modified (diff)

comment:21 Changed 15 months ago by naoliv

Sorry if it's already known:

ERROR: Failed to locate image 'presets/car.png'
WARNING:  Car: Could not get presets icon presets/car.png
ERROR: Failed to locate image 'presets/bed.png'
WARNING:  Amenity: Could not get presets icon presets/bed.png
ERROR: Failed to locate image 'presets/shop/mall.png'
WARNING:  Shops: Could not get presets icon presets/shop/mall.png
ERROR: Failed to locate image 'presets/landuse.png'
WARNING:  Landuse: Could not get presets icon presets/landuse.png
ERROR: Failed to locate image 'presets/military.png'
WARNING:  Military: Could not get presets icon presets/military.png
ERROR: Failed to locate image 'presets/firebrigade.png'
WARNING:  Emergency: Could not get presets icon presets/firebrigade.png
ERROR: Failed to locate image 'presets/sport/soccer.png'
WARNING:  Sports: Could not get presets icon presets/sport/soccer.png
ERROR: Failed to locate image 'presets/sightseeing.png'
WARNING:  Tourism: Could not get presets icon presets/sightseeing.png
ERROR: Failed to locate image 'presets/equestrian.png'
WARNING:  Trail Riding Station: Could not get presets icon presets/equestrian.png
ERROR: Failed to locate image 'presets/works.png'
WARNING:  Man Made: Could not get presets icon presets/works.png

The only preset that I have enabled is https://josm.openstreetmap.de/josmfile?page=Presets/NewTags&zip=1 (I am unsure if the missing icons are from NewTags or from something internal in JOSM)

JOSM is 10710

comment:22 in reply to:  21 Changed 15 months ago by Klumbumbus

Replying to naoliv:

The only preset that I have enabled is https://josm.openstreetmap.de/josmfile?page=Presets/NewTags&zip=1 (I am unsure if the missing icons are from NewTags or from something internal in JOSM)

JOSM is 10710

This is already fixed. It takes up to 10 days until you get the update in your JOSM. To force an update, see https://josm.openstreetmap.de/wiki/Presets#UpdatingpresetsinJOSM

Last edited 15 months ago by Klumbumbus (previous) (diff)

comment:23 Changed 15 months ago by naoliv

Right. Thanks!

comment:24 Changed 15 months ago by Klumbumbus

Description: modified (diff)

comment:25 Changed 15 months ago by Klumbumbus

Description: modified (diff)

comment:26 Changed 15 months ago by Klumbumbus

Description: modified (diff)

comment:27 Changed 15 months ago by Klumbumbus

Description: modified (diff)

comment:28 Changed 15 months ago by IrlJidel

Updated Irish boundary presets as requested in http://wiki.openstreetmap.org/wiki/User_talk:IrlJidel

comment:29 in reply to:  28 Changed 15 months ago by Klumbumbus

Description: modified (diff)

Replying to IrlJidel:

Updated Irish boundary presets as requested in http://wiki.openstreetmap.org/wiki/User_talk:IrlJidel

Thanks.

comment:30 Changed 15 months ago by Klumbumbus

In 10724/josm:

see #13217, see #13204 - fix icons

comment:31 Changed 15 months ago by Klumbumbus

In 10725/josm:

see #13217 - fix water_point icon and pixel align aerialway station icon

comment:32 Changed 15 months ago by Michi

Updated the observatory preset as requested in https://wiki.openstreetmap.org/wiki/User_talk:Michi2#JOSM%20preset

comment:33 in reply to:  32 Changed 15 months ago by Klumbumbus

Description: modified (diff)

Replying to Michi:

Updated the observatory preset as requested in https://wiki.openstreetmap.org/wiki/User_talk:Michi2#JOSM%20preset

Thanks.

comment:34 Changed 15 months ago by Klumbumbus

Resolution: fixed
Status: newclosed

Ticket is fixed. 2 github pull requests for external presets/styles are still waiting for merge.

comment:35 Changed 15 months ago by Klumbumbus

Description: modified (diff)

comment:36 Changed 15 months ago by Klumbumbus

In 10750/josm:

see #13217 - remove duplicate icon; ignore historic=charcoal_pile 15k uses, but only local usage on 2 spots in the world

comment:37 Changed 15 months ago by Klumbumbus

In 10751/josm:

see #13217 - fix icon size display for tag combinations like public_transport=stop_position + railway=halt

comment:38 Changed 14 months ago by Klumbumbus

Description: modified (diff)

comment:39 Changed 14 months ago by simon04

In 10872/josm:

see #13217 - Update deprecated icon name in TagInfoExtract

comment:40 Changed 14 months ago by simon04

In 10927/josm:

see #13217 - Only one location for deprecated icon names

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Klumbumbus.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.