Modify

Opened 17 months ago

#13152 new defect

Unecessary decision dialog while merging two ways that are part of a multipolygon

Reported by: naoliv Owned by: team
Priority: normal Milestone:
Component: Core multipoly Version:
Keywords: Cc:

Description

Open the attached example, select the select=me parts and merge (with C).
We have this screen:

https://i.imgur.com/aHx50nn.png

Note how JOSM asks if we want to keep both segments in the multipolygon.
Most of the time people will think "of course I want both segments" and mark them to be kept.

But if the user chooses this logical solution he will end with a broken multipolygon:

https://i.imgur.com/LFRKjS3.png

It's not clear that he needs to keep only one way (any of them) and remove the other to have the correct solution.

Since we are merging two ways into one, the decision dialog should ask us if we want to keep/remove the already merged way and not the 2 initial segments.

It's even worse when we have more segments involved in the merge process.

JOSM:

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-07-13 23:20:15 +0200 (Wed, 13 Jul 2016)
Build-Date:2016-07-14 01:31:48
Revision:10531
Relative:URL: ^/trunk

Identification: JOSM/1.5 (10531 en) Linux Debian GNU/Linux testing (stretch)
Memory Usage: 247 MB / 10206 MB (58 MB allocated, but free)
Java version: 1.8.0_91-8u91-b14-3-b14, Oracle Corporation, OpenJDK 64-Bit Server VM
VM arguments: [-Dawt.useSystemAAFontSettings=on]
Dataset consistency test: No problems found

Plugins:
- Create_grid_of_ways (32440)
- ImportImagePlugin (32584)
- OpeningHoursEditor (32583)
- PicLayer (32495)
- RoadSigns (32584)
- SimplifyArea (32517)
- apache-commons (32584)
- buildings_tools (32639)
- conflation (0.2.0)
- contourmerge (1014)
- download_along (32535)
- editgpx (32485)
- ejml (32639)
- geojson (42)
- geotools (32584)
- importvec (32490)
- indoorhelper (32637)
- jts (32539)
- log4j (32309)
- measurement (32454)
- merge-overlap (32471)
- opendata (32584)
- pbf (32584)
- pdfimport (32584)
- poly (32584)
- reverter (32584)
- scripting (30723)
- todo (29154)
- turnrestrictions (32629)
- undelete (32584)
- utilsplugin2 (32584)

Attachments (1)

example.osm (1.2 KB) - added by naoliv 17 months ago.

Download all attachments as: .zip

Change History (1)

Changed 17 months ago by naoliv

Attachment: example.osm added

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to naoliv
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.