Modify

Opened 16 months ago

Closed 16 months ago

Last modified 10 days ago

#13144 closed enhancement (fixed)

Include sex/gender in hairdresser/barber preset

Reported by: naoliv Owned by: team
Priority: normal Milestone: 16.07
Component: Internal preset Version:
Keywords: Cc:

Description

While creating a hairdresser/barber using the preset we only have Name, Opening Hours and Wheelchairs

Is it possible to also include the sex/gender like https://wiki.openstreetmap.org/wiki/Tag:shop%3Dhairdresser#Tags_to_use_in_combination says, please?

Options should be "empty", "female", "male", "unisex", in a drop-down box (ie, the user will be able to select only one option and, except for the "empty" one, the selected value will be yes)

Attachments (0)

Change History (6)

comment:1 Changed 16 months ago by Don-vip

Milestone: 16.07

comment:2 in reply to:  description Changed 16 months ago by Klumbumbus

Replying to naoliv:

Options should be "empty", "female", "male", "unisex", in a drop-down box (ie, the user will be able to select only one option and, except for the "empty" one, the selected value will be yes)

This is confusing for the user. In a combobox you expect only one key with different values and not different keys. What should the combobox display if both male=yes and female=yes are already tagged and you open the preset?

I think the better solution would be check boxes and validation rules.

comment:3 Changed 16 months ago by Klumbumbus

patch for the validator rules:

/* #13144 */
*[unisex=yes][female=yes][male!=yes],
*[unisex=yes][male=yes][female!=yes] {
  throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
}
*[unisex=yes][female=yes][male=yes] {
  throwWarning: tr("{0} together with {1} and {2}. Remove {1} and {2}", "{0.tag}", "{1.tag}", "{2.tag}");
  fixRemove: "female";
  fixRemove: "male";
}
*[female=yes][male=yes][!unisex][shop=hairdresser] { /* for toilets male=yes female=yes unisex=no combination is valid */
  throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
  suggestAlternative: "unisex=yes";
  fixRemove: "female";
  fixRemove: "male";
  fixAdd: "unisex=yes";
}

Has i18n impact. Waiting a bit in case a hotfix for milestone 16.06 is required.

comment:4 Changed 16 months ago by naoliv

I only thought about the case where the user creates a hairdresser/barber using the preset (and I forgot that he can modify it using the preset too).
So indeed, a combobox won't properly fit this.

comment:5 Changed 16 months ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 10537/josm:

fix #13144 - Include female, male and unisex in hairdresser/barber preset and add related validation

comment:6 Changed 10 days ago by Klumbumbus

In 13102/josm:

see #13144, fix #15536 - limit male/female/unisex test to hairdressers

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.