Modify

#13037 closed enhancement (fixed)

[Patch] Small fixes for unit tests

Reported by: michael2402 Owned by: team
Priority: normal Milestone: 16.06
Component: Unit tests Version:
Keywords: gsoc-core Cc: Don-vip, bastiK, stoecker

Description (last modified by michael2402)

This is a collection of small fixes to make (more) unit tests pass. Most notably the following bugs are fixed:

  • Unit tests assume Europe/Berlin timezone
  • PreferencesTest assumed you use josm_test as user.
  • Remove Main.map.[mapView.]repaint() calls after command execution or when that layer can be invalidated.
  • Fix GpxTrack returning the wrong max time if the latest node is not the last one.
  • Set logLevel to default for all tests
  • AutosaveTaskTest does not create an endless list of warnings any more - 5 are enough to test that.
  • Fix Commmand triggering the selection change in the active data set. It triggers in the edited data set now.

A more detailed version of the changes can be seen here:
https://github.com/michaelzangl/josm/commits/test-do-not-call-map-repaint

If you want to preserve the commit messages, I can pack you the output of git --format-patch ;-).

Attachments (1)

patch-test-do-not-call-map-repaint.patch (72.5 KB) - added by michael2402 18 months ago.

Download all attachments as: .zip

Change History (4)

comment:1 Changed 18 months ago by michael2402

Description: modified (diff)

Changed 18 months ago by michael2402

comment:2 Changed 18 months ago by michael2402

Component: CoreUnit tests

comment:3 Changed 18 months ago by Don-vip

Resolution: fixed
Status: newclosed

In 10467/josm:

fix #13037 - Small fixes for unit tests (patch by michael2402) - gsoc-core

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.