Modify

Opened 17 months ago

Closed 2 weeks ago

#12994 closed defect (fixed)

Old style SideButton usage errors

Reported by: rickmastfan67 Owned by: team
Priority: minor Milestone: 16.06
Component: Core Version: latest
Keywords: Cc: stoecker

Description (last modified by rickmastfan67)

Just saw this in the JOSM command line after opening and closing the Data Download screen. Saw this with both a fresh and my default profile.

WARNING: Old style SideButton usage for action org.openstreetmap.josm.gui.download.DownloadDialog$DownloadAction@510e7f36
WARNING: Old style SideButton usage for action org.openstreetmap.josm.gui.download.DownloadDialog$CancelAction@74aee02e

Also have found one in the Prefences window right when you open it up:

WARNING: Old style SideButton usage for action org.openstreetmap.josm.gui.preferences.server.OsmApiUrlInputPanel$ValidateApiUrlAction@4217a0dc
URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-06-19 02:15:46 +0200 (Sun, 19 Jun 2016)
Build-Date:2016-06-19 01:34:13
Revision:10422
Relative:URL: ^/trunk

Identification: JOSM/1.5 (10422 en) Windows 7 64-Bit
Memory Usage: 336 MB / 1820 MB (235 MB allocated, but free)
Java version: 1.8.0_77-b03, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM

Attachments (0)

Change History (36)

comment:1 Changed 17 months ago by rickmastfan67

Description: modified (diff)
Summary: Old style SideButton usage in Download Data windowOld style SideButton usage errors

comment:2 Changed 17 months ago by rickmastfan67

There is also one plugin that is also getting this type of error. It's the measurement plugin.

WARNING: Old style SideButton usage for action org.openstreetmap.josm.plugins.measurement.MeasurementDialog$1@7880a1c2
  • measurement (32158)
Last edited 17 months ago by rickmastfan67 (previous) (diff)

comment:3 Changed 17 months ago by rickmastfan67

And here's a few more from the relations editing window:

WARNING: Old style SideButton usage for action org.openstreetmap.josm.gui.dialogs.relation.actions.SetRoleAction@4ae136c0
WARNING: Old style SideButton usage for action org.openstreetmap.josm.gui.dialogs.relation.ReferringRelationsBrowser$ReloadAction@168099e2
WARNING: Old style SideButton usage for action org.openstreetmap.josm.gui.dialogs.relation.ReferringRelationsBrowser$EditAction@3467c73
WARNING: Old style SideButton usage for action org.openstreetmap.josm.gui.dialogs.relation.actions.OKAction@932b661
WARNING: Old style SideButton usage for action org.openstreetmap.josm.gui.dialogs.relation.actions.CancelAction@d13c592

comment:4 Changed 17 months ago by Don-vip

Cc: stoecker added
Milestone: 16.06

comment:5 Changed 17 months ago by stoecker

In 10424/josm:

see #12994 - don't use SideButton outside side panel

comment:6 Changed 17 months ago by stoecker

Resolution: fixed
Status: newclosed

In [o32324:32325].

All mentioned ones should be fixed. Reopen when you find more.

comment:7 Changed 17 months ago by rickmastfan67

Resolution: fixed
Status: closedreopened

Triggered some more.

WARNING: Old style SideButton usage for action org.openstreetmap.josm.plugins.turnrestrictions.list.TurnRestrictionsListDialog$NewAction@2aa7214a
WARNING: Old style SideButton usage for action org.openstreetmap.josm.plugins.turnrestrictions.list.TurnRestrictionsListDialog$EditAction@19f8af0d
WARNING: Old style SideButton usage for action org.openstreetmap.josm.plugins.turnrestrictions.list.TurnRestrictionsListDialog$DeleteAction@5b36366b
  • turnrestrictions (32158)

comment:8 Changed 17 months ago by rickmastfan67

And a few more, this time triggered via the Changeset Management Dialog.

WARNING: Old style SideButton usage for action org.openstreetmap.josm.gui.dialogs.changeset.ChangesetCacheManager$QueryAction@6fcbac9c
WARNING: Old style SideButton usage for action org.openstreetmap.josm.gui.dialogs.changeset.SingleChangesetDownloadPanel$DownloadAction@7669ad80
WARNING: Old style SideButton usage for action org.openstreetmap.josm.gui.dialogs.changeset.ChangesetCacheManager$DownloadMyChangesets@327058c7
WARNING: Old style SideButton usage for action org.openstreetmap.josm.gui.dialogs.changeset.ChangesetCacheManager$CancelAction@4a486147

comment:9 in reply to:  8 Changed 17 months ago by Klumbumbus

Replying to rickmastfan67:

And a few more, this time triggered via the Changeset Management Dialog.

see also #13003

comment:10 Changed 17 months ago by stoecker

In 10438/josm:

see #12994 - Old style SideButton

comment:11 Changed 17 months ago by Don-vip

In 10447/josm:

see #12994, see #13018 - checkstyle

comment:12 Changed 17 months ago by Klumbumbus

some more (detected in r10448):

WARNING: Old style SideButton usage for action org.openstreetmap.josm.plugins.turnrestrictions.list.TurnRestrictionsListDialog$NewAction@18775d2
WARNING: Old style SideButton usage for action org.openstreetmap.josm.plugins.turnrestrictions.list.TurnRestrictionsListDialog$EditAction@1216ea1
WARNING: Old style SideButton usage for action org.openstreetmap.josm.plugins.turnrestrictions.list.TurnRestrictionsListDialog$DeleteAction@1e5204d
WARNING: Old style SideButton usage for action org.wikipedia.WikipediaToggleDialog$WikipediaLoadCoordinatesAction@7cc554
WARNING: Old style SideButton usage for action org.wikipedia.WikipediaToggleDialog$WikipediaLoadCategoryAction@11649e9
WARNING: Old style SideButton usage for action org.wikipedia.WikipediaToggleDialog$PasteWikipediaArticlesAction@1a1607e
WARNING: Old style SideButton usage for action org.wikipedia.WikipediaToggleDialog$AddWikipediaTagAction@925155
WARNING: Old style SideButton usage for action org.wikipedia.WikipediaToggleDialog$WikipediaSettingsAction@97b907
WARNING: Old style SideButton usage for action org.openstreetmap.josm.plugins.mapillary.gui.MapillaryMainDialog$NextPictureAction@1e272b8
WARNING: Old style SideButton usage for action org.openstreetmap.josm.plugins.mapillary.gui.MapillaryMainDialog$PreviousPictureAction@1530e8e
WARNING: Old style SideButton usage for action org.openstreetmap.josm.plugins.mapillary.gui.MapillaryMainDialog$RedAction@c93eff
WARNING: Old style SideButton usage for action org.openstreetmap.josm.plugins.mapillary.gui.MapillaryMainDialog$BlueAction@164b40b
WARNING: Old style SideButton usage for action org.openstreetmap.josm.plugins.mapillary.gui.MapillaryMainDialog$PlayAction@4fed46
WARNING: Old style SideButton usage for action org.openstreetmap.josm.plugins.mapillary.gui.MapillaryMainDialog$PauseAction@2f256c
WARNING: Old style SideButton usage for action org.openstreetmap.josm.plugins.mapillary.gui.MapillaryMainDialog$StopAction@775a1b
WARNING: Old style SideButton usage for action org.openstreetmap.josm.plugins.mapillary.gui.MapillaryHistoryDialog$UndoAction@45072c
WARNING: Old style SideButton usage for action org.openstreetmap.josm.plugins.mapillary.gui.MapillaryHistoryDialog$RedoAction@1c26475
WARNING: Old style SideButton usage for action org.openstreetmap.josm.plugins.mapillary.gui.MapillaryFilterDialog$UpdateAction@11c8874
WARNING: Old style SideButton usage for action org.openstreetmap.josm.plugins.mapillary.gui.MapillaryFilterDialog$ResetAction@144f550
WARNING: Old style SideButton usage for action org.openstreetmap.josm.plugins.todo.TodoDialog$SelectAction@174d1da
WARNING: Old style SideButton usage for action org.openstreetmap.josm.plugins.todo.TodoDialog$AddAction@9019d7
WARNING: Old style SideButton usage for action org.openstreetmap.josm.plugins.todo.TodoDialog$PassAction@1f195e6
WARNING: Old style SideButton usage for action org.openstreetmap.josm.plugins.todo.TodoDialog$MarkAction@dcbcca

comment:13 Changed 17 months ago by Don-vip

turnrestrictions updated in [o32375:32376].

comment:14 Changed 17 months ago by stoecker

I think you forgot the "true" for attachImageIcon() in the actions used by ToggleDialog.

comment:15 Changed 17 months ago by rickmastfan67

Gonna be a hating, but 2 more spotted with the turnrestrictions plugin. LOL. Didn't show up till I wanted to try making a new restriction.

WARNING: Old style SideButton usage for action org.openstreetmap.josm.plugins.turnrestrictions.editor.TurnRestrictionEditor$OKAction@6f3665d6
WARNING: Old style SideButton usage for action org.openstreetmap.josm.plugins.turnrestrictions.editor.TurnRestrictionEditor$CancelAction@60153307
  • turnrestrictions (32375)

comment:16 Changed 17 months ago by stoecker

In 10464/josm:

don't add Resource, when it should not, see #12994

comment:17 Changed 17 months ago by stoecker

Turnrestrictions and wikipedia, See [o32386:32387] - no jar released yet.

comment:18 Changed 17 months ago by stoecker

In 10465/josm:

Old style SideButton usage, see #12994

comment:19 Changed 17 months ago by michael2402

JOSM 10473

WARNUNG: Old style SideButton usage for action org.openstreetmap.josm.gui.dialogs.changeset.query.ChangesetQueryDialog$QueryAction@5578e073
WARNUNG: Old style SideButton usage for action org.openstreetmap.josm.gui.dialogs.changeset.query.ChangesetQueryDialog$CancelAction@42c18ba8
WARNUNG: Old style SideButton usage for action org.openstreetmap.josm.gui.help.ContextSensitiveHelpAction@276d3501

comment:20 Changed 17 months ago by stoecker

In 10479/josm:

Don't use SideButton outside toggle dialogs, see #12994

comment:21 Changed 17 months ago by stoecker

In 10481/josm:

Don't use SideButton outside toggle dialogs, see #12994, see #13054

comment:22 Changed 17 months ago by stoecker

In 10482/josm:

see #12994 - don't warn about SideButton without icon

comment:23 Changed 17 months ago by stoecker

Resolution: fixed
Status: reopenedclosed

Fixed mapillary in [o32396:32397] and did checkin turnrestrictions jar.

Wikipedia is fixed, but not yet activated. Todo is not in SVN. All reported issues fixed for now (I know there are more :-).

comment:24 in reply to:  23 Changed 17 months ago by rickmastfan67

Resolution: fixed
Status: closedreopened

Replying to stoecker:

Fixed mapillary in [o32396:32397] and did checkin turnrestrictions jar.

Wikipedia is fixed, but not yet activated. Todo is not in SVN. All reported issues fixed for now (I know there are more :-).

Sorry, but not all of the reported ones in this thread are fixed. One in comment:8 is still alive in r10493. It's the following:

WARNING: Old style SideButton usage for action org.openstreetmap.josm.gui.dialogs.changeset.SingleChangesetDownloadPanel$DownloadAction@1af16b23

comment:25 Changed 17 months ago by stoecker

Resolution: fixed
Status: reopenedclosed

In 10494/josm:

Don't use SideButton outside toggle dialogs, fix #12994

comment:26 Changed 17 months ago by rickmastfan67

Resolution: fixed
Status: closedreopened

Found some new ones. lol. :) Discovered them when uploading a change to the OSM database. Found in r10520.

WARNING: Old style SideButton usage for action org.openstreetmap.josm.gui.io.UploadDialog$UploadAction@49587f0f
WARNING: Old style SideButton usage for action org.openstreetmap.josm.gui.io.UploadDialog$CancelAction@322a8728
WARNING: Old style SideButton usage for action org.openstreetmap.josm.gui.help.ContextSensitiveHelpAction@13b18bfa

comment:27 Changed 17 months ago by Don-vip

Resolution: fixed
Status: reopenedclosed

In 10525/josm:

fix #12994 - Old style SideButton usage errors

comment:28 Changed 16 months ago by Don-vip

Some more:

- W: Old style SideButton usage for action org.openstreetmap.josm.gui.conflict.tags.CombinePrimitiveResolverDialog$ApplyAction@826c46
- W: Old style SideButton usage for action org.openstreetmap.josm.gui.conflict.tags.CombinePrimitiveResolverDialog$CancelAction@9ea8bc
- W: Old style SideButton usage for action org.openstreetmap.josm.gui.help.ContextSensitiveHelpAction@b565ab

comment:29 Changed 16 months ago by Don-vip

In 10527/josm:

fix #12994 - Old style SideButton usage errors

comment:30 Changed 16 months ago by Klumbumbus

Resolution: fixed
Status: closedreopened

New ones from #13141

- W: Old style SideButton usage for action org.openstreetmap.josm.gui.dialogs.DeleteFromRelationConfirmationDialog$OKAction@1e5a5e0
- W: Old style SideButton usage for action org.openstreetmap.josm.gui.dialogs.DeleteFromRelationConfirmationDialog$CancelAction@2f578b
- W: Old style SideButton usage for action org.openstreetmap.josm.gui.help.ContextSensitiveHelpAction@2b49d9

(Should we still use this one or create a new for milestone 16.07?)

comment:31 Changed 16 months ago by Don-vip

In 10779/josm:

see #12994 - Old style SideButton usage errors

comment:32 Changed 15 months ago by Don-vip

Resolution: fixed
Status: reopenedclosed

comment:33 Changed 14 months ago by simon04

Resolution: fixed
Status: closedreopened
WARNING: Old style SideButton usage for action org.openstreetmap.josm.gui.help.ContextSensitiveHelpAction@687a0d0b
WARNING: Old style SideButton usage for action org.openstreetmap.josm.gui.io.CredentialDialog$CancelAction@318b4507
WARNING: Old style SideButton usage for action org.openstreetmap.josm.gui.io.CredentialDialog$OKAction@5d928fa9

comment:34 Changed 12 months ago by skyper

Some more:

WARNING: Old style SideButton usage for action org.openstreetmap.josm.gui.io.UploadSelectionDialog$ContinueAction@23a6f922
WARNING: Old style SideButton usage for action org.openstreetmap.josm.gui.io.UploadSelectionDialog$CancelAction@4f308f47
WARNING: Old style SideButton usage for action org.openstreetmap.josm.gui.help.ContextSensitiveHelpAction@7523e04f
Last edited 12 months ago by skyper (previous) (diff)

comment:35 Changed 11 months ago by skyper

I did open separate tickets for the plugins (custom query).

and found one more:

- W: Old style SideButton usage for action org.openstreetmap.josm.gui.help.ContextSensitiveHelpAction@f726d00

comment:36 Changed 2 weeks ago by Don-vip

Resolution: fixed
Status: reopenedclosed

In 13071/josm:

fix #12994 - Old style SideButton usage errors

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.