Modify

Opened 17 years ago

Closed 17 years ago

#128 closed enhancement (wontfix)

Alt keyboard shortcut is a common window manager shortcut

Reported by: hansendc Owned by: imi
Priority: minor Milestone:
Component: Core Version: latest
Keywords: Cc:

Description

Honestly not a huge show stopper bug or anything, but the keyboard shortcuts page mentions that Alt will grab segments instead of ways if you use the alt key. However, many window managers use Alt as a shortcut for various window actions like resizing or moving windows. It would be nice if this was something a bit less common, or could also be accessed with Alt-Shift or something.

I guess this would also be taken care of if the shortcuts were configurable. In any case, I thought I'd at least document this request.

Attachments (0)

Change History (2)

comment:1 by Ed, 17 years ago

This patch will make right click do the same as alt+click does (I much prefer this):

Index: J:/eclipse/eclipse/workspace/JOSM/src/org/openstreetmap/josm/gui/SelectionManager.java
===================================================================
--- J:/eclipse/eclipse/workspace/JOSM/src/org/openstreetmap/josm/gui/SelectionManager.java (revision 219)
+++ J:/eclipse/eclipse/workspace/JOSM/src/org/openstreetmap/josm/gui/SelectionManager.java (working copy)
@@ -162,7 +162,7 @@

  • If the correct button, from the "drawing rectangle" mode */

public void mousePressed(MouseEvent e) {

  • if (e.getButton() == MouseEvent.BUTTON1)
+ if (e.getButton() == MouseEvent.BUTTON1
e.getButton() == MouseEvent.BUTTON3)

mousePosStart = mousePos = e.getPoint();

}


@@ -194,7 +194,7 @@

  • Check the state of the keys and buttons and set the selection accordingly. */

public void mouseReleased(MouseEvent e) {

  • if (e.getButton() != MouseEvent.BUTTON1)

+ if (e.getButton() != MouseEvent.BUTTON1 && e.getButton() != MouseEvent.BUTTON3)

return;

if (mousePos == null
mousePosStart == null)

return; injected release from outside

@@ -206,7 +206,7 @@

mousePos = null;


boolean shift = (e.getModifiersEx() & MouseEvent.SHIFT_DOWN_MASK) != 0;

  • boolean alt = (e.getModifiersEx() & MouseEvent.ALT_DOWN_MASK) != 0;
+ boolean alt = (e.getModifiersEx() & MouseEvent.ALT_DOWN_MASK) != 0
e.getButton() == MouseEvent.BUTTON3;

boolean ctrl = (e.getModifiersEx() & MouseEvent.CTRL_DOWN_MASK) != 0;
if ((e.getModifiersEx() & MouseEvent.BUTTON3_DOWN_MASK) == 0)

selectionEndedListener.selectionEnded(r, alt, shift, ctrl);

comment:2 by imi, 17 years ago

Resolution: wontfix
Status: newclosed

beside the fact the patch is totally screwed when passing outside an { { { / } } } - tag, it looks a bit dirty to me, e.g. assigning something other than the state of the alt-key to a variable "alt"...

Anyway, to circumvent most windowmanager, press the mouse button first and then press alt and finally release the mouse button (while still holding alt). JOSM will react to the mouse release only while all window manager I've seen react only on mouse press.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain imi.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.