Modify

Opened 23 months ago

Closed 3 weeks ago

Last modified 3 weeks ago

#12347 closed defect (fixed)

Split way breaks destination_sign relations

Reported by: Klumbumbus Owned by: team
Priority: normal Milestone: 16.02
Component: Core Version: latest
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

  1. split way/4471954

What is the expected result?

only the left way (the one connected to way with the role to) should be added to the relation/2812791

What happens instead?

both new ways are added to the relation

Please provide any additional information below. Attach a screenshot if possible.

(For turn restrictions this works fine when you split a way.)

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-01-12 00:59:37 +0100 (Tue, 12 Jan 2016)
Build-Date:2016-01-12 02:32:48
Revision:9417
Relative:URL: ^/trunk

Identification: JOSM/1.5 (9417 en) Windows 7 32-Bit
Memory Usage: 344 MB / 742 MB (112 MB allocated, but free)
Java version: 1.8.0_66-b18, Oracle Corporation, Java HotSpot(TM) Client VM
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:C:\Program Files\Java\jre1.8.0_66\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=C:\Program Files\josm-latest-bla.jnlp, -Djnlpx.remove=true, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=256m,768m, -Djnlpx.splashport=64859, -Djnlpx.jvm=<java.home>\bin\javaw.exe, -Djnlpx.vmargs=LURqYXZhLnV0aWwuQXJyYXlzLnVzZUxlZ2FjeU1lcmdlU29ydD10cnVlAA==]
Dataset consistency test: No problems found

Plugins:
- AddrInterpolation (31772)
- DirectDownload (31934)
- DirectUpload (31912)
- HouseNumberTaggingTool (31772)
- OpeningHoursEditor (31772)
- PicLayer (31895)
- RoadSigns (31895)
- apache-commons (31895)
- buildings_tools (31895)
- download_along (31772)
- editgpx (31772)
- imagery_offset_db (31895)
- importvec (31772)
- log4j (31895)
- measurement (31895)
- photo_geotagging (31895)
- photoadjust (31963)
- public_transport (31895)
- reltoolbox (31895)
- reverter (31926)
- tag2link (31910)
- tageditor (31772)
- tagging-preset-tester (31895)
- terracer (31895)
- turnlanes (31772)
- turnrestrictions (31895)
- undelete (31895)
- utilsplugin2 (31895)
- wikipedia (31917)

Last errors/warnings:
- W: java.net.SocketException: Socket Closed
- E: java.net.SocketException: Socket Closed

Attachments (0)

Change History (11)

comment:1 Changed 22 months ago by simon04

Resolution: fixed
Status: newclosed

In 9442/josm:

fix #12347 - Split way breaks destination_sign relations

comment:2 Changed 22 months ago by simon04

Milestone: 16.02

comment:3 Changed 22 months ago by bartosomail@…

Splitting a way still breaks destination_sign relations when the junction node is added to the relation with role "intersection" instead of role "sign".

comment:4 Changed 22 months ago by bartosomail@…

Resolution: fixed
Status: closedreopened
Version: latest

comment:5 Changed 22 months ago by simon04

Resolution: fixed
Status: reopenedclosed

In 9647/josm:

fix #12347 - Split way breaks destination_sign relations (with intersection role)

comment:6 Changed 22 months ago by rickmastfan67

@simon04, is it possible that you can take a look @ #10808 too? Similar problem where JOSM is breaking relations for "No U-Turn restrictions".

comment:7 Changed 20 months ago by bartosomail@…

Resolution: fixed
Status: closedreopened

The issue has reappeared, but only when the junction node has an "intersection" role. The splitting is still handled correctly only when the junction node has a "sign" role.
Tested with OSM version 10000.

comment:9 Changed 20 months ago by bartosomail@…

I just realized that what I stated about the junction role is not correct. It seems instead that the order of the relation members matters.

Example:

Split osmwww:way/404154435 at the middle node: both segments will become member of osmwww:relation/6058078, which is wrong.

Edit relation 6058078 and move the member with role "sign" under the member with role "intersection", save changes. Now try again to split way 404154435, and the result will be correct.

Last edited 20 months ago by Don-vip (previous) (diff)

comment:10 Changed 3 weeks ago by Don-vip

Resolution: fixed
Status: reopenedclosed

In 13065/josm:

fix #12347 - Split way breaks destination_sign relations

comment:11 Changed 3 weeks ago by Don-vip

In 13066/josm:

see #12347 - NPE

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.