josm freezes or hard quits occasionally when using tag help

[cmuelle8]

What steps will reproduce the problem?

1. open josm (ubuntu/openjdk8 env)
2. retrieve data
3. use "Go to OSM wiki for help (F1) in context menu of tag list

What is the expected result?

Page should open up in browser.

What happens instead?

JOSM freezes, Strg+C in console won't help, the process needs to be "killed". Last messages on the console is the URL about to be opened (the resolved one). Sometimes JOSM hard quits, with the console printing

INFO: HEAD https://wiki.openstreetmap.org/wiki/De:Tag:waterway=fish_pass -> 301
INFO: Herunterladen umgelenkt auf 'https://wiki.openstreetmap.org/wiki/DE:Tag:waterway%3Dfish_pass'
INFO: HEAD https://wiki.openstreetmap.org/wiki/DE:Tag:waterway%3Dfish_pass -> 200
INFO: Öffne URL: https://wiki.openstreetmap.org/wiki/De:Tag:waterway=fish_pass
java: Fatal IO error 11 (Die Ressource ist zur Zeit nicht verfügbar) on X server :0.

In the freezing case, just the last line is missing.

Please provide any additional information below. Attach a screenshot if possible.

In the past this feature worked reliably. Since the URL handling code was changed in the near past (http to https), may be other sections have changed as well, unintentionally triggering the behavior above?

Build-Date:2016-01-06 15:46:18
Revision:9328
Is-Local-Build:true

Identification: JOSM/1.5 (9328 SVN de) Linux Ubuntu 15.10
Memory Usage: 532 MB / 1609 MB (111 MB allocated, but free)
Java version: 1.8.0_66-internal, Oracle Corporation, OpenJDK 64-Bit Server VM
Dataset consistency test: No problems found

Plugins:
- PicLayer (31895)
- RoadSigns (31895)
- alignways (31895)
- apache-commons (31895)
- editgpx (31106)
- imagery_offset_db (31895)
- kendzi3d (1.0.189)
- kendzi3d-jogl (41)
- kendzi3d-resources (0.0.1)
- log4j (31895)
- openvisible (31106)
- pbf (31772)
- photo_geotagging (31895)
- photoadjust (31953)
- poly (31772)
- print (31895)
- reverter (31897)
- turnlanes (31772)
- turnrestrictions (31895)
- utilsplugin2 (31895)
- wikipedia (31917)

[cmuelle8]

reproduced with downloaded josm-latest.jar (so it's not an issue of svn local build only)

[simon04]

Recent changes include r9147 (HTTP → HTTPS), r9171 (HttpClient, GET → HEAD).

Does the problem persist when changing url.openstreetmap-wiki to http://wiki.openstreetmap.org/wiki/?

[Don-vip]

Cannot reproduce with

Identification: JOSM/1.5 (9329 SVN en) Windows 10 64-Bit
Memory Usage: 636 MB / 3634 MB (294 MB allocated, but free)
Java version: 1.8.0_66, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Program arguments: [--debug]

INFO: HEAD https://wiki.openstreetmap.org/wiki/Tag:waterway=fish_pass -> 301
DEBUG: RESPONSE: {Keep-Alive=[timeout=5, max=98], null=[HTTP/1.1 301 Moved Permanently], Server=[Apache/2.4.7 (Ubuntu)], X-Content-Type-Options=[nosniff], Connection=[Keep-Alive], Last-Modified=[Wed, 06 Jan 2016 22:49:24 GMT], Date=[Wed, 06 Jan 2016 22:49:24 GMT], Cache-Control=[private, must-revalidate, max-age=0], Vary=[Accept-Encoding,Cookie], Expires=[Thu, 01 Jan 1970 00:00:00 GMT], Content-Type=[text/html; charset=utf-8], Location=[https://wiki.openstreetmap.org/wiki/Tag:waterway%3Dfish_pass], X-Powered-By=[PHP/5.5.9-1ubuntu4.14]}
INFO: Download redirected to 'https://wiki.openstreetmap.org/wiki/Tag:waterway%3Dfish_pass'
INFO: HEAD https://wiki.openstreetmap.org/wiki/Tag:waterway%3Dfish_pass -> 200
DEBUG: RESPONSE: {Keep-Alive=[timeout=5, max=97], null=[HTTP/1.1 200 OK], Server=[Apache/2.4.7 (Ubuntu)], X-Content-Type-Options=[nosniff], Connection=[Keep-Alive], Last-Modified=[Wed, 06 Jan 2016 20:47:14 GMT], Date=[Wed, 06 Jan 2016 22:49:24 GMT], X-UA-Compatible=[IE=Edge], Cache-Control=[private, must-revalidate, max-age=0], Content-language=[en], Vary=[Accept-Encoding,Cookie], Expires=[Thu, 01 Jan 1970 00:00:00 GMT], Content-Type=[text/html; charset=UTF-8], X-Powered-By=[PHP/5.5.9-1ubuntu4.14]}

[simon04]

Cannot reproduce with

Build-Date:2016-01-06 22:14:07
Revision:9330
Is-Local-Build:true

Identification: JOSM/1.5 (9330 SVN en) Linux Arch Linux
Memory Usage: 621 MB / 3504 MB (168 MB allocated, but free)
Java version: 1.8.0_66, Oracle Corporation, OpenJDK 64-Bit Server VM
VM arguments: [-agentlib:jdwp=transport=dt_socket,address=127.0.0.1:42740,suspend=y,server=n, -Djosm.home=/tmp/.josm, -javaagent:/usr/share/intellijidea-ce/plugins/Groovy/lib/agent/gragent.jar, -Dfile.encoding=UTF-8]
Program arguments: [--set=use.native.file.dialog=true, --set=expert=true, --set=remotecontrol.enabled=true, --set=debug.edt-checker.enable=true, --set=dialog.dynamic.buttons=false]
Dataset consistency test: No problems found

I randomly selected a property and pressed [F1], repeating this process ≈10 times.

[cmuelle8]

yes:

INFO: HEAD http://wiki.openstreetmap.org/wiki/De:Tag:waterway=fish_pass -> 301
INFO: Herunterladen umgelenkt auf 'http://wiki.openstreetmap.org/wiki/DE:Tag:waterway%3Dfish_pass'
INFO: HEAD http://wiki.openstreetmap.org/wiki/DE:Tag:waterway%3Dfish_pass -> 200
INFO: Öffne URL: http://wiki.openstreetmap.org/wiki/De:Tag:waterway=fish_pass
java: Fatal IO error 11 (Die Ressource ist zur Zeit nicht verfügbar) on X server :0.

I do not think its related to r9147, rather 9171.
Also, i've written that it's not reproducable all the time, it happens quite a lot though.

[cmuelle8]

might as well be a bug in current openjdk/x not surfacing on your boxes..

[simon04]

I'm also using OpenJDK:

$ java -version
openjdk version "1.8.0_66"
OpenJDK Runtime Environment (build 1.8.0_66-b17)
OpenJDK 64-Bit Server VM (build 25.66-b17, mixed mode)

Is the bug related to HTTP HEAD request, i.e., when removing , "HEAD" twice (in PropertiesDialog.HelpAction#actionPerformed), does the problem persist?

[simon04]

Also, since the URL is already being opened ("Öffne URL"), it could also be related to some system/browser mis-configuration.

Does the problem persist when using r9060 (the "tested" from all those changes)?

[cmuelle8]

I just checked out 9170 and the problem appears as well, so r9171 is not what's causing it..

[simon04]

Does the problem persist when testing w/ fresh settings (especially w/o the wikipedia plugin) to exclude r9149/#9775 from causing troubles?

[cmuelle8]

Did not try fresh settings yet, but the wikipedia plugin is disabled (checked twice - first 9170 would not load it, because plugin version was to high; second try having it disabled in the plugin list) - no luck, issue appears anyway.

I suspected Eclipse being open in the background hogging to many system resources, but that isn't the issue either - the only processes open are a terminal and josm, so it should not be caused by hogged system resources either. Its a real bug, wherever it is.. Trying fresh settings now..

[cmuelle8]

Yep, happens with fresh settings as well (using 9170).. I'll restart the box and see if it persists (though linux should not be restart-ware)..

[cmuelle8]

Also strange, tile downloading is not affected at all, but maybe that uses different code paths..

[cmuelle8]

Irreproducible after restart, so definitely system related. I use hibernate, so I guess the bug is in the realm of stray handles collecting over time - maybe in X, the error message might indicate that. Closing without a fix..