Modify

Opened 2 years ago

Last modified 2 years ago

#12107 new defect

Class conflicts between plugins

Reported by: kendzi Owned by: team
Priority: major Milestone:
Component: Plugin Version:
Keywords: Cc:

Description (last modified by Don-vip)

I made some research, and looks like there are few conflicts with classes between plugins I attach the log.

Conflict between plugins:

  • 31718_apache-commons.jar, 31603_commons-imaging.jar,
  • 31718_apache-commons.jar, 71_scoutsigns.jar,
  • 31718_apache-commons.jar, 42_missingRoads.jar,
  • 31718_apache-commons.jar, 13_trafficFlowDirection.jar,
  • 31687_apache-http.jar, 0.0.2_ebdirigo.jar,
  • 31756_ejml.jar, 1.0.188_kendzi3d.jar,
  • 31756_ejml.jar, 1.0.179-SNAPSHOT_kendzi3d_Improved_by_Andrei.jar,
  • 8_kartverketimport.jar, 8_kartverketimport.jar,
  • 31603_log4j.jar, v0.5.1_matsim.jar,
  • 31694_mapdust.jar, 71_scoutsigns.jar,
  • 31694_mapdust.jar, 42_missingRoads.jar,
  • 31694_mapdust.jar, 13_trafficFlowDirection.jar,
  • 31707_OSMRecPlugin.jar, 1.0.188_kendzi3d.jar,
  • 31707_OSMRecPlugin.jar, 1.0.179-SNAPSHOT_kendzi3d_Improved_by_Andrei.jar,
  • 31694_Tracer.jar, 1443872074_Tracer-testing.jar,
  • 1.0.188_kendzi3d.jar, 1.0.179-SNAPSHOT_kendzi3d_Improved_by_Andrei.jar,
  • 1.0.188_kendzi3d.jar, v0.5.1_matsim.jar,
  • 71_scoutsigns.jar, 42_missingRoads.jar,
  • 71_scoutsigns.jar, 13_trafficFlowDirection.jar,
  • 42_missingRoads.jar, 13_trafficFlowDirection.jar,
  • 1.0.179-SNAPSHOT_kendzi3d_Improved_by_Andrei.jar, v0.5.1_matsim.jar,

Attachments (2)

josm_plugin_conflicts_log (316.7 KB) - added by kendzi 2 years ago.
josm_plugin_conflicts_log​2.txt (286.7 KB) - added by kendzi 2 years ago.

Download all attachments as: .zip

Change History (14)

Changed 2 years ago by kendzi

Attachment: josm_plugin_conflicts_log added

comment:1 Changed 2 years ago by kendzi

Description: modified (diff)

comment:2 Changed 2 years ago by Don-vip

Thanks. Some remarks:

  • commons-imaging is deprecated, it must be filtered out, the "conflict" is normal
  • scoutsigns, missingRoads, trafficFlowDirection: I'll create some PRs
  • ebdirigo: I already contacted them but they don't seem very reactive/cooperative. The source code is not even published
  • ejml: The version is not up to date because of GeoTools, I have created a ticket and I will create a PR if needed
  • kartverketimport: bug ??
  • kendzi vs Andrea: is it expected to merge both plugins? Why are there two versions? :(

comment:3 Changed 2 years ago by kendzi

  • kartverketimport: bug ??

Not at all. It is twice in plugin list:
https://josm.openstreetmap.de/plugin

kartverketimport.jar;http://svn.openstreetmap.org/applications/editors/josm/dist/kartverketimport.jar
kartverketimport.jar;https://github.com/JOSM/kartverketimport/releases/download/v8/kartverketimport.jar

  • kendzi vs Andrea

Good question. Andrea make fork of my plugin. He worked longer time on old plugin version and release it as separated plugin. He never tried to make pull request to me. As I known it is not run-able with current version of JOSM and kendzi3d-jogl (without it it won't run). I inform him about changes inside kendzi3d-jogl but don't see any changes.

I have review some changes he made and it won't be easy back-port it, the whole concept of selection was changed. And lot of changes have to be reverted. Secondary, I have compliantly different vision for editor :(

Last edited 2 years ago by kendzi (previous) (diff)

comment:4 in reply to:  3 Changed 2 years ago by Don-vip

Replying to kendzi:

Not at all. It is twice in plugin list:

Nice catch. I'll remove the plugin from wiki, as it is hosted on OSM SVN.

  • kendzi vs Andrea

I have review some changes he made and it won't be easy back-port it, the whole concept of selection was changed. And lot of changes have to be reverted. Secondary, I have compliantly different vision for editor :(

Sad :( I hope this situation can eventually be resolved in the future.

Last edited 2 years ago by Don-vip (previous) (diff)

comment:5 Changed 2 years ago by Don-vip

Description: modified (diff)

comment:6 Changed 2 years ago by Don-vip

Description: modified (diff)

comment:7 Changed 2 years ago by Don-vip

Many of the conflicts should be gone soon. Can you please perform a new check?

By the way it seems there's a network/server problem with zibi.openstreetmap.org.pl. Would it be OK for you to host the JAR files of your plugins directly on Github? See failing unit test.

comment:8 Changed 2 years ago by kendzi

I love that free ftp servers :(

Is it possible to host release files on github? As I known few years ago they drop it. I will check and try.

comment:9 Changed 2 years ago by Don-vip

Yes you can use the release mechanism and simply drag&drop the jar file. It's pretty straightforward, reliable and you can update the jar file in case of error.

comment:10 Changed 2 years ago by kendzi

Nice to known, I will give the try to releases in github. But I will do it tomorrow.

Here is current list of conflicts:

  • 31718_apache-commons.jar, 71_scoutsigns.jar,
  • 31718_apache-commons.jar, 42_missingRoads.jar,
  • 31718_apache-commons.jar, 13_trafficFlowDirection.jar,
  • 31687_apache-http.jar, 0.0.2_ebdirigo.jar,
  • 31756_ejml.jar, 1.0.188_kendzi3d.jar,
  • 31756_ejml.jar, 1.0.179-SNAPSHOT_kendzi3d_Improved_by_Andrei.jar,
  • 31769_gson.jar, 71_scoutsigns.jar,
  • 31769_gson.jar, 42_missingRoads.jar,
  • 31769_gson.jar, 13_trafficFlowDirection.jar,
  • 31603_log4j.jar, v0.5.2_matsim.jar,
  • 31707_OSMRecPlugin.jar, 1.0.188_kendzi3d.jar,
  • 31707_OSMRecPlugin.jar, 1.0.179-SNAPSHOT_kendzi3d_Improved_by_Andrei.jar,
  • 31694_Tracer.jar, 1443872074_Tracer-testing.jar,
  • 1.0.188_kendzi3d.jar, 1.0.179-SNAPSHOT_kendzi3d_Improved_by_Andrei.jar,
  • 1.0.188_kendzi3d.jar, v0.5.2_matsim.jar,
  • 71_scoutsigns.jar, 42_missingRoads.jar,
  • 71_scoutsigns.jar, 13_trafficFlowDirection.jar,
  • 42_missingRoads.jar, 13_trafficFlowDirection.jar,
  • 1.0.179-SNAPSHOT_kendzi3d_Improved_by_Andrei.jar, v0.5.2_matsim.jar,

Later I upload program for it on github. As it is jUnit test you could add it to your jenkins if you want.

Changed 2 years ago by kendzi

comment:12 Changed 2 years ago by kendzi

I run scan and we have one new problem with ImproveOsm, rest as usual:

  • 31895_apache-commons.jar, 31_ImproveOsm.jar
  • 31895_apache-commons.jar, 73_scoutsigns.jar
  • 31895_gson.jar, 73_scoutsigns.jar
  • 31895_gson.jar, 31_ImproveOsm.jar
  • 31895_log4j.jar, v0.5.5_matsim.jar
  • 31772_OSMRecPlugin.jar, 1.0.189_kendzi3d.jar > slf4j
  • 31772_Tracer.jar, 1453646778_Tracer-testing.jar
  • 1.0.189_kendzi3d.jar, v0.5.5_matsim.jar > guice 3 and inject 1
  • 73_scoutsigns.jar, 31_ImproveOsm.jar

Some known problems:

  • 31895_ejml.jar, 1.0.189_kendzi3d.jar > bug reqest for GeoJson is not solved yet #12097
  • 1.0.179-SNAPSHOT_kendzi3d_Improved_by_Andrei.jar, 1.0.189_kendzi3d.jar
  • 1.0.179-SNAPSHOT_kendzi3d_Improved_by_Andrei.jar, 31772_OSMRecPlugin.jar
  • 1.0.179-SNAPSHOT_kendzi3d_Improved_by_Andrei.jar, v0.5.5_matsim.jar
  • 1.0.179-SNAPSHOT_kendzi3d_Improved_by_Andrei.jar, 31895_ejml.jar
Last edited 2 years ago by kendzi (previous) (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to kendzi
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.