Modify

Opened 8 years ago

Closed 8 years ago

#12004 closed enhancement (fixed)

Propose a solution to source:maxspeed=UK:*

Reported by: GerdP Owned by: team
Priority: normal Milestone: 15.10
Component: Core validator Version:
Keywords: template_report iso country code maxspeed united kingdom Cc:

Description

What steps will reproduce the problem?

  1. create a highway with tags highway=secondary,maxspeed="60 mph", and source:maxspeed=UK:nsl_single

What is the expected result?

no warning

What happens instead?

A warning: Unknown country code: UK

Please provide any additional information below. Attach a screenshot if possible.

TestError [tester=org.openstreetmap.josm.data.validation.tests.Highways@7a1ab1b7, code=2703, message=Unknown country code: UK]

Revision: 8800
Repository Root: http://josm.openstreetmap.de/svn
Relative URL: ^/trunk
Last Changed Author: simon04
Last Changed Date: 2015-09-27 22:11:06 +0200 (Sun, 27 Sep 2015)
Build-Date: 2015-09-28 01:32:03
URL: http://josm.openstreetmap.de/svn/trunk
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last Changed Rev: 8800

Identification: JOSM/1.5 (8800 en) Windows 7 64-Bit
Memory Usage: 1214 MB / 3641 MB (522 MB allocated, but free)
Java version: 1.8.0_60, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
VM arguments: [-Dsun.java2d.opengl=true]
Dataset consistency test: No problems found

Plugins:
- buildings_tools (31558)
- geotools (31601)
- jts (31126)
- o5m (${version.entry.commit.revision})
- opendata (31241)
- pbf (31241)
- poly (31241)
- utilsplugin2 (31463)

Last errors/warnings:
- W: org.openstreetmap.josm.io.OsmTransferException: Could not connect to the OSM server. Please check your internet connection.. Cause: java.net.UnknownHostException: api.openstreetmap.org
- E: java.net.UnknownHostException: api.openstreetmap.org
- W: org.openstreetmap.josm.io.OsmTransferException: Could not connect to the OSM server. Please check your internet connection.. Cause: java.net.UnknownHostException: api.openstreetmap.org
- E: java.net.UnknownHostException: api.openstreetmap.org
- W: org.openstreetmap.josm.io.OsmTransferException: Could not connect to the OSM server. Please check your internet connection.. Cause: java.net.UnknownHostException: api.openstreetmap.org

Attachments (0)

Change History (3)

comment:1 by Don-vip, 8 years ago

Keywords: iso country code maxspeed added
Resolution: invalid
Status: newclosed

The error is correct. "UK" is not a country code defined in ISO_3166-2.

For United Kingdom, the correct code is GB.
For Ukraine, the correct code is UA.

comment:2 by Don-vip, 8 years ago

Component: CoreCore validator
Keywords: united kingdom added
Milestone: 15.10
Resolution: invalid
Status: closedreopened
Summary: wrong validator messagePropose a solution to source:maxspeed=UK:*
Type: defectenhancement

I see there's a lot of usage of UK instead of GB so the validator should propose a fix.

comment:3 by Don-vip, 8 years ago

Resolution: fixed
Status: reopenedclosed

In 8941/josm:

fix #12004 - suggest to replace source:maxspeed=UK:* by source:maxspeed=GB:* as per ISO 3166-2

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.