Modify

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#11891 closed defect (fixed)

unable to merge more than two data layers

Reported by: malenki Owned by: team
Priority: normal Milestone: 15.09
Component: Core Version: latest
Keywords: regression Cc:

Description

In older versions of JOSM one could select three or more data layers and merge them into one layer.
With up-to-date versions this is no longer possible.
E.g. when I select the layers 14, 13, 12 and 11, press ctrl-m, select layer 11 as destination and execute, the layers 13, 12 and 11 remain.
Experienced with r8788 and earlier versions.
A guess: Maybe this issue was introduced when the really useful gamma adjust function was added?

Attachments (0)

Change History (11)

comment:1 by simon04, 9 years ago

Resolution: fixed
Status: newclosed

In 8789/josm:

fix #11891 - Unable to merge more than two data layers - regression of r8728

comment:2 by simon04, 9 years ago

Milestone: 15.09

comment:3 by malenki, 9 years ago

Resolution: fixed
Status: closedreopened

Thanks for the speedy reaction, but in r8791 I still can only merge two data layers.
Tested with empty ~/.josm on Linux
openjdk version "1.8.0_72"
OpenJDK Runtime Environment (build 1.8.0_72-b00)
OpenJDK 64-Bit Server VM (build 25.72-b00, mixed mode

comment:4 by simon04, 9 years ago

It works for me: Create 5 new data layers (5×[CTRL]+[N]). Select them all in the layer list. Right click. Merge.

comment:5 by Don-vip, 9 years ago

Works for me too with jdk 8u60. Where do you get your 8u72 build from? It is not expected until January.

in reply to:  5 comment:6 by malenki, 9 years ago

Replying to Don-vip:

Works for me too with jdk 8u60. Where do you get your 8u72 build from? It is not expected until January.

At the moment I am running Void Linux. The Java version I use is the default 1.8 available in the repository.

comment:7 by Don-vip, 9 years ago

can you test with a stable release? (on another machine maybe?)

comment:8 by malenki, 9 years ago

When using Hotkey CTRL-M or the menu
still only merging two layers of seven on a
32bit Debian Sid with
java version "1.7.0_79"
OpenJDK Runtime Environment (IcedTea 2.5.6) (7u79-2.5.6-1)
OpenJDK Server VM (build 24.79-b02, mixed mode)

Merging by the newly introduced context menu entry works for all layers…

in reply to:  8 comment:9 by Don-vip, 9 years ago

Replying to malenki:

When using Hotkey CTRL-M

ok, the shortcut does not trigger the same action.

@Simon: Maybe we should get rid of LayerListDialog.MergeAction and move the whole logic to MergeLayerAction.

comment:10 by simon04, 9 years ago

Resolution: fixed
Status: reopenedclosed

Ah, this operation is also placed in the Edit menu.

Since the behaviour of this operation hasn't been changed and has never supported merging multiple layers, I would keep additional adaptions for the next release. Therefore, I created #11897.

Personally, I would vote for removing the merge operation from the Edit menu. Analogously, neither duplicating nor deleting layers is placed in the Edit menu.

in reply to:  10 comment:11 by malenki, 9 years ago

Replying to simon04:

Since the behaviour of this operation hasn't been changed and has never supported merging multiple layers, I would keep additional adaptions for the next release. Therefore, I created #11897.

Strange enough (and as I mentioned in the OP) merging multiple layers did work. Right now tested with r8701. :)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.