Modify

Opened 22 months ago

Closed 19 months ago

Last modified 19 months ago

#11696 closed enhancement (fixed)

[Patch] Option to prevent translation of values in presets.

Reported by: StephaneP Owned by: simon04
Priority: normal Milestone: 15.10
Component: Internal preset Version:
Keywords: translation; collection_time Cc: Klumbumbus, stoecker

Description

Hello !

With Josm sets in french, the preset for post_box contains a menu for the collection_time tag. But all the examples for the value are translated in french :
Lun-Ven instead of Mo-Fr

Attachments (1)

11696.patch (4.8 KB) - added by simon04 19 months ago.

Download all attachments as: .zip

Change History (16)

comment:1 Changed 22 months ago by stoecker

Owner: changed from team to StephaneP
Status: newneedinfo

That's the case for most of JOSM's presets. JOSM automatically handles this and adds the untranslated text. That would only be an error, when the final tags contain translated texts. Do they?

comment:2 Changed 22 months ago by anonymous

I thought that I made a mistake, but no.

If you choose one of the examples and don't touch it, the preset put the right english value :
I select "Lu-Ve 17:30; Sa 12:00"
the value become "Mo-Fr 17:30; Sa 12:00"

But if you select one example, then change something (you adapt the hours), the preset keep the translated value.
I select "Lu-Ve 17:30; Sa 12:00"
I change it to "Lu-Ve 17:30; Sa 09:00"
the value stays to "Lu-Ve 17:30; Sa 09:00"

comment:3 Changed 22 months ago by stoecker

Summary: Preset post_box : collection_time translatedOption to prevent translation of values in presets.
Type: defectenhancement

Yes, It's not a good idea to use translation for presets where values are usually changed. But we currently have no possibility to prevent translation. Short-term-fix: Change french translation (see Translations). You can do this yourself.

Long-term-solution. Add possibility to prevent translation for some data fields with high probability of errors.

comment:4 Changed 22 months ago by Klumbumbus

Cc: Klumbumbus added

comment:5 Changed 21 months ago by StephaneP

Translation reverted in launchpad.

comment:6 Changed 19 months ago by simon04

Owner: changed from StephaneP to team
Status: needinfonew

Changed 19 months ago by simon04

Attachment: 11696.patch added

comment:7 Changed 19 months ago by simon04

Milestone: 15.10
Owner: changed from team to simon04
Summary: Option to prevent translation of values in presets.[Patch] Option to prevent translation of values in presets.

Patch attached. i18n/convpreset.pl needs to be adapted not not extract those values for translation.

comment:8 Changed 19 months ago by simon04

Cc: stoecker added

comment:9 Changed 19 months ago by simon04

comment:10 Changed 19 months ago by simon04

Resolution: fixed
Status: newclosed

In 8872/josm:

fix #11696 - Option to prevent translation of values in presets

comment:12 Changed 19 months ago by Klumbumbus

This is availible for combo and multiselect, right?

comment:13 Changed 19 months ago by simon04

Yes.

comment:15 Changed 19 months ago by Klumbumbus

In 8878/josm:

see #11696 - add values_no_i18n="true" to service_times in default preset

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain simon04.
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.