Modify

Opened 2 years ago

Closed 20 months ago

Last modified 2 months ago

#11491 closed enhancement (fixed)

Remove "place together with addr:*" for places with only addr:postcode

Reported by: anonymous Owned by: team
Priority: normal Milestone: 15.09
Component: Core validator Version: latest
Keywords: postal code postcode place address Cc:

Description

Please add exception for addr:postcode because we are using it in Poland for places (mainly villages) where is only one postcode. Thank you.

Attachments (0)

Change History (12)

comment:1 Changed 2 years ago by Klumbumbus

I think Key:postal_code is the correct key to use on place nodes or relations.

comment:2 Changed 2 years ago by naoliv

(I am not the reporter)
Couldn't JOSM fix addr:postcodepostal_code for cases like this?
I use a rule to change this in streets here in Brazil (and after reading this bug report I will also add another one for areas with place)

comment:3 in reply to:  2 Changed 23 months ago by Don-vip

Keywords: postal code postcode place address added
Milestone: 15.06
Type: defectenhancement

Replying to naoliv:

Couldn't JOSM fix addr:postcodepostal_code for cases like this?
I use a rule to change this in streets here in Brazil (and after reading this bug report I will also add another one for areas with place)

Agreed. Can you please share these rules so we will include them in core?

comment:4 Changed 23 months ago by naoliv

What we use:

way[highway]["addr:postcode"],
area[place]["addr:postcode"] {
        throwWarning: tr("improper use of {0}", "{1.key}");
        suggestAlternative: "postal_code";
        fixChangeKey: "{1.key} => postal_code";
}

But I see some possible issues/improvements:

  • we are not testing for this, but an area or highway could be possibly (and erroneously) tagged with both addr:postcode and postal_code:
    • remove addr:postcode if both values are the same
    • just warn when the values are different
  • likewise, !area and !highway with both keys:
    • remove postal_code if the same
    • warn if different

Should area[landuse] also be tested for this?

comment:5 Changed 23 months ago by Don-vip

Milestone: 15.0615.07

skip milestone 15.06

comment:6 Changed 21 months ago by Don-vip

Milestone: 15.0715.08

Milestone renamed

comment:7 Changed 21 months ago by Don-vip

Milestone: 15.0815.09

comment:8 Changed 20 months ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 8730/josm:

fix #11491 - add/enhance validator rules for postcode/postal_code/addr:postcode

comment:9 Changed 20 months ago by Klumbumbus

A test for place together with addr:postcode with autofix addr:postcode=>postalcode is risky, because in some cases not the addr:postcode tag is wrong, but the place tag. See e.g. way/233908425 or node/439184883.

comment:10 in reply to:  1 Changed 18 months ago by avatar6

Replying to Klumbumbus:

I think Key:postal_code is the correct key to use on place nodes or relations.

I think not. wiki(Key:place) says: "Probably better to use the Karlsruhe Schema instead of this tag." so why not? De facto people using same tag for same meaning entity, either on buildings and on places/their boundaries.

comment:11 Changed 18 months ago by avatar6

Russia(and some rus-speaking exUSSR) are de-facto using addr:postcode on place. Pls see ru-wiki for tag "place":
http://wiki.openstreetmap.org/wiki/RU:Key:place#.D0.98.D1.81.D0.BF.D0.BE.D0.BB.D1.8C.D0.B7.D1.83.D0.B5.D1.82.D1.81.D1.8F_.D0.B2.D0.BC.D0.B5.D1.81.D1.82.D0.B5_.D1.81

comment:12 Changed 2 months ago by Klumbumbus

In 11548/josm:

fix #14310, see #11491, see #9811 - don't warn about addr:postcode together with place=* (used this way in some countries)

(If this combination is "wrong" in your country you can add a country specific rule at https://josm.openstreetmap.de/wiki/Rules with a territory selector.)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.