turnrestrictions plugin doesn't like to play properly with LaneConnector

[rickmastfan67]

Steps to reproduce:

1. Start with a fresh profile.
2. Download and install the 'turnrestrictions' & 'LaneConnector' plugins.
3. Restart JOSM.
4. Download a small section of data (doesn't matter where).

What happens:
The turnrestrictions plugin crashes.

What should happen:
The turnrestrictions plugin shouldn't crash.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2015-05-23 01:31:25
Last Changed Author: Don-vip
Revision: 8419
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Relative URL: ^/trunk
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2015-05-23 01:40:23 +0200 (Sat, 23 May 2015)
Last Changed Rev: 8419

Identification: JOSM/1.5 (8419 en) Windows 7 64-Bit
Memory Usage: 355 MB / 1820 MB (82 MB allocated, but free)
Java version: 1.7.0_79, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Dataset consistency test: No problems found

Plugins:
- LaneConnector (UNKNOWN)
- turnrestrictions (31034)

Last errors/warnings:
- E: org.openstreetmap.josm.plugins.PluginException: An error occurred in plugin turnrestrictions. Cause: java.lang.reflect.InvocationTargetException. Cause: java.lang.NoClassDefFoundError: org/openstreetmap/josm/gui/JMultilineLabel. Cause: java.lang.ClassNotFoundException: org.openstreetmap.josm.gui.JMultilineLabel

org.openstreetmap.josm.plugins.PluginException: An error occurred in plugin turnrestrictions
	at org.openstreetmap.josm.plugins.PluginProxy.mapFrameInitialized(PluginProxy.java:34)
	at org.openstreetmap.josm.Main.setMapFrame(Main.java:508)
	at org.openstreetmap.josm.Main.createMapFrame(Main.java:761)
	at org.openstreetmap.josm.Main.addLayer(Main.java:748)
	at org.openstreetmap.josm.Main.addLayer(Main.java:733)
	at org.openstreetmap.josm.actions.downloadtasks.DownloadOsmTask$AbstractInternalTask.addNewLayerIfRequired(DownloadOsmTask.java:277)
	at org.openstreetmap.josm.actions.downloadtasks.DownloadOsmTask$AbstractInternalTask.loadData(DownloadOsmTask.java:284)
	at org.openstreetmap.josm.actions.downloadtasks.DownloadOsmTask$DownloadTask.finish(DownloadOsmTask.java:346)
	at org.openstreetmap.josm.gui.PleaseWaitRunnable$1.run(PleaseWaitRunnable.java:101)
	at java.awt.event.InvocationEvent.dispatch(Unknown Source)
	at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
	at java.awt.EventQueue.access$300(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.awt.WaitDispatchSupport$2.run(Unknown Source)
	at java.awt.WaitDispatchSupport$4.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.awt.WaitDispatchSupport.enter(Unknown Source)
	at java.awt.Dialog.show(Unknown Source)
	at java.awt.Component.show(Unknown Source)
	at java.awt.Component.setVisible(Unknown Source)
	at java.awt.Window.setVisible(Unknown Source)
	at java.awt.Dialog.setVisible(Unknown Source)
	at org.openstreetmap.josm.gui.progress.PleaseWaitProgressMonitor$4.run(PleaseWaitProgressMonitor.java:167)
	at java.awt.event.InvocationEvent.dispatch(Unknown Source)
	at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
	at java.awt.EventQueue.access$300(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.run(Unknown Source)
Caused by: java.lang.reflect.InvocationTargetException
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at org.openstreetmap.josm.plugins.PluginProxy.mapFrameInitialized(PluginProxy.java:30)
	... 43 more
Caused by: java.lang.NoClassDefFoundError: org/openstreetmap/josm/gui/JMultilineLabel
	at org.openstreetmap.josm.plugins.turnrestrictions.list.TurnRestrictionsInDatasetView.build(TurnRestrictionsInDatasetView.java:27)
	at org.openstreetmap.josm.plugins.turnrestrictions.list.TurnRestrictionsInDatasetView.<init>(TurnRestrictionsInDatasetView.java:47)
	at org.openstreetmap.josm.plugins.turnrestrictions.list.TurnRestrictionsListDialog.build(TurnRestrictionsListDialog.java:124)
	at org.openstreetmap.josm.plugins.turnrestrictions.list.TurnRestrictionsListDialog.<init>(TurnRestrictionsListDialog.java:152)
	at org.openstreetmap.josm.plugins.turnrestrictions.TurnRestrictionsPlugin.mapFrameInitialized(TurnRestrictionsPlugin.java:26)
	... 48 more
Caused by: java.lang.ClassNotFoundException: org.openstreetmap.josm.gui.JMultilineLabel
	at java.net.URLClassLoader$1.run(Unknown Source)
	at java.net.URLClassLoader$1.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.net.URLClassLoader.findClass(Unknown Source)
	at java.lang.ClassLoader.loadClass(Unknown Source)
	at java.lang.ClassLoader.loadClass(Unknown Source)
	... 53 more

This crash doesn't seem to be triggered except when paired with the LaneConnector plugin.

[stoecker]

Please report this here: ​https://github.com/TrifanAdrian/LanecConnectorPlugin

Somehow they integrated the classes from turnrestrictions plugin, which naturally breaks the plugin loading.

[rickmastfan67]

Done.
​https://github.com/TrifanAdrian/LanecConnectorPlugin/issues/1

[Don-vip]

In 8944/josm:

see #11468, #11518: missed another dummy plugin: RemoveRedundantPoints ==> unmaintained