autolanguage does not work . english instead of system language (was: JOSM plötzlich auf Englisch)

[brogo]

Mit JOSM 8287 ist die Spracheinstellung plötzlich von Deutsch auf Englisch umgestellt.

[Klumbumbus]

Stell sie doch einfach wieder um.

[brogo]

Wert stand auf "Standard, automatisch". Habe diesen Wert nie geändert.
Manuell auf German gesetzt. -> OK.

Zur Info: Windows 7 Prof. 64 Bit., Java 8

[Klumbumbus]

Revision: 8287
Repository Root: http://josm.openstreetmap.de/svn
Relative URL: ^/trunk
Last Changed Author: Don-vip
Last Changed Date: 2015-04-28 01:11:18 +0200 (Tue, 28 Apr 2015)
Build-Date: 2015-04-28 01:31:11
URL: http://josm.openstreetmap.de/svn/trunk
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last Changed Rev: 8287

Identification: JOSM/1.5 (8287 en) Windows 7 32-Bit
Memory Usage: 247 MB / 742 MB (145 MB allocated, but free)
Java version: 1.8.0_45, Oracle Corporation, Java HotSpot(TM) Client VM
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:C:\Program Files\Java\jre1.8.0_45\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=C:\Program Files\josm-latest-bla.jnlp, -Djnlpx.remove=false, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=256m,768m, -Djnlpx.splashport=57023, -Djnlpx.jvm=<java.home>\bin\javaw.exe, -Djnlpx.vmargs=LURqYXZhLnV0aWwuQXJyYXlzLnVzZUxlZ2FjeU1lcmdlU29ydD10cnVlAA==]

[Don-vip]

confirmed. Works fine with tested, not with latest ==> regression of r8282:8283?

[Don-vip]

Messages at startup:

DEBUG: System property 'http.agent' set to 'JOSM/1.5 (8289 SVN en) Windows 7 64-Bit'. Old value was 'null'
DEBUG: System property 'user.language' set to ''. Old value was 'fr'
DEBUG: System property 'jsse.enableSNIExtension' set to 'false'. Old value was 'null'
DEBUG: System property 'http.agent' set to 'JOSM/1.5 (8289 SVN en) Windows 7 64-Bit'. Old value was 'JOSM/1.5 (8289 SVN en) Windows 7 64-Bit'
DEBUG: System property 'user.language' set to ''. Old value was ''

[Don-vip]

Dirk, why did you remove these lines?

https://josm.openstreetmap.de/changeset/8283/josm/trunk/src/org/openstreetmap/josm/tools/I18n.java

It kills the autodetection feature. On my setup "fr_FR" is the default language, so JOSM does not load "fr" lang file anymore.

[stoecker]

Because getJOSMLocalCode() should already change that to fr. If not, then somewhere else getJOSMLocaleCode() needs be called. Works for Linux.

[stoecker]

I can't test here: I think in line 444 the Locale.getDefault().toString() should be a LanguageInfo.getJOSMLocaleCode().

[stoecker]

Fixed In r8292: default language setting failed

Seems I simply did my tests wrong and now I also used wrong ticket id. :-)

[Don-vip]

Replying to stoecker:

now I also used wrong ticket id. :-)

Easy to fix :)

[stoecker]

In 8292/josm:

fix #11381 - default language setting failed