Modify

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#11257 closed enhancement (fixed)

[Patch] Drop dependency on Apache Commons Codec

Reported by: floscher Owned by: team
Priority: normal Milestone: 15.03
Component: Core Version:
Keywords: Cc:

Description

Patch-file: https://github.com/floscher/josm/commit/542367b2fa806ac0b96206650245722bfaa5cb32.patch

The dependency on Apache Commons Codec is only needed for Base64 decoding, which can be done with a tool from JAXB, which is part of JavaSE since 1.6 (javax.xml.bind.DatatypeConverter).

This patch replaces both the Base64 decoder from Apache Commons Codec and the one from the Sun-packages with the previously mentioned one.

See also https://github.com/floscher/josm/commit/542367b2fa806ac0b96206650245722bfaa5cb32

Attachments (1)

0001-Updated-README-to-reflect-changes-in-r8149.patch (1.1 KB ) - added by floscher 9 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 by stoecker, 9 years ago

Please cleanup the patch and remove all unnecessary changes like whitespace fixes.

comment:3 by floscher, 9 years ago

I almost forgot to say:

This patch of course obviates the need for the svn-external

/src/org/apache/commons/codec http://svn.apache.org/repos/asf/commons/proper/codec/trunk/src/main/java/org/apache/commons/codec

As I don't have any experience with svn-externals, I don't know how to include the removal of one in a patch, if this is even possible.

comment:4 by stoecker, 9 years ago

Resolution: fixed
Status: newclosed

In 8149/josm:

fix #11257 - Remove apache.commons.codecs - patch by Florian Schaefer

comment:5 by stoecker, 9 years ago

Milestone: 15.03

comment:6 by floscher, 9 years ago

This new patch removes Apache Commons Codec also from the list of third party libraries.

comment:7 by stoecker, 9 years ago

In 8150/josm:

see #11257 - fix README

comment:8 by stoecker, 9 years ago

I'm 100% sure I already did that. Probably forgot to save the file :-)

comment:9 by Don-vip, 9 years ago

plugin native-password-manager needs adaptation:

http://donvip.fr/jenkins/job/JOSM-Plugins/1062/console

in reply to:  9 comment:10 by bastiK, 9 years ago

Replying to Don-vip:

plugin native-password-manager needs adaptation:

http://donvip.fr/jenkins/job/JOSM-Plugins/1062/console

Fixed in [o31061].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.