Modify

Opened 3 years ago

Closed 6 days ago

Last modified 7 hours ago

#11217 closed enhancement (fixed)

support urls in notes

Reported by: skyper Owned by: team
Priority: normal Milestone: 17.11
Component: Core notes Version:
Keywords: Cc: Klumbumbus

Description (last modified by skyper)

Not sure if it is within the scope of the plugin. If not it would be an enhancement of "Core notes".

I often find URLs within a note but cannot click nor copy it to open in a web browser.

Attachments (5)

11217.patch (1.6 KB) - added by simon04 3 years ago.
2015-04-15-213157_1198x1899_scrot.png (1.1 KB) - added by simon04 3 years ago.
First attempt using GettingStarted.LinkGeneral: does not look as expected …
josm_notes.png (9.8 KB) - added by Don-vip 7 days ago.
note_escape.gif (1.7 MB) - added by Klumbumbus 7 days ago.
notes_arrow.gif (555.9 KB) - added by Klumbumbus 7 days ago.

Change History (33)

comment:1 Changed 3 years ago by Don-vip

Component: Plugin tag2linkCore notes
Keywords: notes removed
Owner: changed from Don-vip to ToeBee

comment:2 Changed 3 years ago by skyper

Description: modified (diff)

Changed 3 years ago by simon04

Attachment: 11217.patch added

comment:3 Changed 3 years ago by simon04

Summary: support urls in notes[Patch] support urls in notes

An idea would be to copy the note URL to the clipboard when right clicking the tooltip, see attachment:11217.patch

comment:4 Changed 3 years ago by bastiK

Can we use GettingStarted.LinkGeneral?

Changed 3 years ago by simon04

First attempt using GettingStarted.LinkGeneral: does not look as expected …

comment:5 Changed 3 years ago by Klumbumbus

Cc: Klumbumbus added

comment:6 Changed 3 years ago by ToeBee

Technically speaking, the patch and this ticket are solving two different problems. The ticket is asking for URLs in the note text to be clickable. The patch makes it easier to open a given note on osm.org. If note text could be made clickable, the "note xxx" link at the top of the note could be turned into a URL to open on osm.org. The problem I ran into is that the note text is rendered as a tooltip which isn't really intended to be clicked on.

comment:7 Changed 3 years ago by stoecker

Milestone: 15.05

comment:8 Changed 2 years ago by Don-vip

Milestone: 15.0515.06

comment:9 Changed 2 years ago by Don-vip

Milestone: 15.0615.07

skip milestone 15.06

comment:10 Changed 2 years ago by simon04

In 8503/josm:

see #11217 - Notes: copy note URL to clipboard when right clicking tooltip

comment:11 Changed 2 years ago by simon04

Summary: [Patch] support urls in notessupport urls in notes

comment:6 still applies: links within notes can still not be opened/copied.

comment:12 in reply to:  10 Changed 2 years ago by Klumbumbus

Replying to simon04:

In 8503/josm:

see #11217 - Notes: copy note URL to clipboard when right clicking tooltip

This copies the api url. Wouldn't it be better if it copies the url, which opens the note at osm.org?

So,

http://www.openstreetmap.org/note/377327

instead of

https://api.openstreetmap.org/api/0.6/notes/377327

comment:13 Changed 2 years ago by Don-vip

Milestone: 15.0715.08

Milestone renamed

comment:14 Changed 2 years ago by Don-vip

Milestone: 15.0815.09

comment:15 Changed 2 years ago by simon04

Milestone: 15.09
Owner: changed from ToeBee to team

I don't plan implementing this any time soon …

comment:16 Changed 7 days ago by Don-vip

Milestone: 17.11

comment:17 Changed 7 days ago by Don-vip

Resolution: fixed
Status: newclosed

In 13111/josm:

fix #11217, fix #12623 - major rework of notes tooltips:

  • display clickable links
  • allow to copy text from notes, including comments

Changed 7 days ago by Don-vip

Attachment: josm_notes.png added

comment:18 Changed 7 days ago by Don-vip

Here's the result:


comment:19 Changed 7 days ago by Klumbumbus

This means copying the notes api url (via right click on the popup) is no longer available, right?
(Just for updating Help/Dialog/Notes.)

Changed 7 days ago by Klumbumbus

Attachment: note_escape.gif added

comment:20 Changed 7 days ago by Klumbumbus

The notes Popup is now somehow on top of the JOSM window and can be moved out of it, which looks a bit weird.


Version 0, edited 7 days ago by Klumbumbus (next)

comment:21 Changed 7 days ago by Don-vip

I'm not sure I can display it behind the toolbars and panels with the new system. I could however hide the popup if displayed outside of JOSM...

comment:22 Changed 7 days ago by Don-vip

In 13117/josm:

see #11217, fix #15541 - hide note tooltip when selected note is no longer visible + drop old url copy code (does not work anymore with new system)

comment:23 Changed 7 days ago by Klumbumbus

Resolution: fixed
Status: closedreopened

There is one more regression. It is not possible anmore to cycle through the notes list with the arrow keys. I work a lot on handling and closing notes and this feature is pretty helpful as then you can quickly see the full texts of all the notes in the list.

Last edited 32 hours ago by Klumbumbus (previous) (diff)

Changed 7 days ago by Klumbumbus

Attachment: notes_arrow.gif added

comment:24 Changed 7 days ago by Klumbumbus

And one more regression is that shortcuts don't work anymore after clicking on a note. So my work flow is often:

  1. double click a note
  2. press shortcut for Help/Action/DownloadOsmInView

The shortcut doesn't work, you need to click somewhere else first.

comment:25 Changed 6 days ago by Don-vip

Resolution: fixed
Status: reopenedclosed

In 13118/josm:

fix #11217 - do not steel focus when the selected note changes

comment:26 in reply to:  25 Changed 32 hours ago by Klumbumbus

Replying to Don-vip:

In 13118/josm:

fix #11217 - do not steel focus when the selected note changes

Mouse scroll to zoom the mapview doesn't work if the mousepointer is on the note tooltip. Can this be fixed easily too?

comment:27 Changed 8 hours ago by Don-vip

In 13126/josm:

see #11217 - forward note tooltips mouse wheel scroll events to map frame

comment:28 Changed 7 hours ago by Don-vip

In 13128/josm:

see #15550, see #11217 - better detection of URLs in notes

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.