Improvements to user-settings for mapcss mappaint styles

[Klumbumbus]

User-settings for mapcss mappaint styles were included in JOSM with very basic functionality (see #10421). While this was ok for its first use, it could need some improvements which I want to sum up here:

• Currently it is only accessible in mappaint dialog. Many users do not use the dialog or even do not know how to get it. (Although I described where to change the user setting and attached a screenshot ​in the forum, users searched in the preferences window to change the user setting and gave up searching). It would be useful if the user-settings are also accessible in the preferences window and in the view menu (maybe also for buttons placed in the toolbar). To make it accessible in the preferences window (which is maybe indeed the first place to search for this setting) is maybe relevant for milestone:14.08 since it includes the big changes in default mappaint style.

• Extend the user settings to numbers, lists, colors and strings. Styles/Lane_and_Road_Attributes would need the colors. (r15731 adds double and string, r16843 adds color)

• Enable to set a keyboard shortcut to change a specific (boolean) user setting.

• Enable grouping of similar settings for enabling/disabling several settings at once. Done in r15289

• Make translations with tr() also working for external mappaint styles which are managed in this wiki Styles#StylesmanagedinJOSMwiki.

• Add documentation at Help/Styles/MapCSSImplementation (Done for initial boolean only implementation.)

[Don-vip]

I agree on point 1 we should make it more accessible. I don't understand the difference between point 4 and #10426 you created earlier?

[Klumbumbus]

Replying to Don-vip:

I don't understand the difference between point 4 and #10426 you created earlier?

#10426 was not about user settings but about strings to display on nodes, ways and areas. I would like to use it in Styles/Coloured_Streets. You can see there in the screenshoots that it displays strings on nodes, ways and areas like "street?" or "number?" or "addr:interpolation shouldn't have other addr:*=* tags!"

I don't know if there is a difference in implementation if tr() is used in a mappaint user setting or in a normal block like way[highway=residential][!name]{ text: tr("name?"); } (Help/Styles/MapCSSImplementation says tr()is only for strings in the JOSM user interface).
If there is no difference, then #10426 can be closed as duplicate of this ticket.

[bastiK]

Replying to Klumbumbus:

• Currently it is only accessible in mappaint dialog. Many users do not use the dialog or even do not know how to get it. (Although I described where to change the user setting and attached a screenshot ​in the forum, users searched in the preferences window to change the user setting and gave up searching). It would be useful if the user-settings are also accessible in the preferences window and in the view menu (maybe also for buttons placed in the toolbar). To make it accessible in the preferences window (which is maybe indeed the first place to search for this setting) is maybe relevant for milestone:14.08 since it includes the big changes in default mappaint style.

Technically, it is not so easy to have this setting available in the preference window. (At the moment, it is only aware of the metadata, either downloaded from the server or saved to the preferences.xml. The mapcss file is not parsed before the user hits Okay.)
I won't have time for this before the 14.08 release.

[Don-vip]

No problem, the version is stable enough, release in progress :)

[Klumbumbus]

added to ticket text: Add documentation at Help/Styles/MapCSSImplementation

[Klumbumbus]

Docu done. Help/Styles/MapCSSImplementation#Stylesettings

[G_Fyyar]

Is anyone still working on this? Or is there a newer ticket pertaining to enhancing mapcss user-settings?

[Don-vip]

I plan to work on making style settings more accessible (first point of this ticket).

[G_Fyyar]

Do you know if anyone is/was planning on expanding the user settings (second point of this ticket)?

[Don-vip]

In 15288/josm:

see #10435 - keep the style settings menu open after one has been selected, like for mappaint menu

[Klumbumbus]

Replying to Don-vip:

keep the style settings menu open

Thats a nice feature.

[Don-vip]

In 15289/josm:

see #10435 - Enable grouping of similar settings for enabling/disabling several settings at once

[G_Fyyar]

I'm sorry--there was some miscommunication on my end. I meant to say, do you know if anyone is/was planning on expanding the user settings (second point of this ticket)? If not, I'll be working on it.

[Don-vip]

I don't plan to work on it right now, a patch would be welcome.

[Klumbumbus]

Replying to G_Fyyar:

expanding the user settings (second point of this ticket)? If not, I'll be working on it.

Possible use case see ticket:18095#comment:4

[Don-vip]

In 15330/josm:

see #10435 - add more "stay open" menu item classes

[Don-vip]

In 15331/josm:

fix #18032, see #10435 - proper update of StayOpenCheckBoxMenuItemUI - fix rendering issue on macOS

[Don-vip]

In 15339/josm:

see #10435 - fix Findbugs violation VO_VOLATILE_REFERENCE_TO_ARRAY

[Don-vip]

In 15492/josm:

see #18032, see #10435 - fix mappaint popup menu disappearance on macOS

macOS triggers a spurious sun.awt.UngrabEvent that is catched by BasicPopupMenuUI.MouseGrabber
and makes the popup menu disappear. Probably related to ​https://bugs.openjdk.java.net/browse/JDK-8225698

[simon04]

In 15731/josm:

see #10435, fix #18095 - MapCSS: add settings of type string/double

[Klumbumbus]

Replying to simon04:

In 15731/josm:

see #10435, fix #18095 - MapCSS: add settings of type string/double

Could you please add documentation on wiki:/Help/Styles/MapCSSImplementation#Stylesettings?

[simon04]

Documentation done, see Help/Styles/MapCSSImplementation?action=diff&version=170

[Klumbumbus]

Thx.

[skyper]

mark implemented parts