Modify

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#10393 closed enhancement (fixed)

LRM character on URLS

Reported by: jgpacker Owned by: team
Priority: normal Milestone: 14.09
Component: Core validator Version:
Keywords: unicode lrm character url email Cc:

Description (last modified by jgpacker)

If possible, JOSM should automatically remove the LRM character (an invisible unicode character used in some languages) from certain keys.

This character can be accidentally introduced by mappers that copy and paste information from other sources.

Usually this character is no big deal, but it can be nasty in tags like website=* , contact:website=* and similar ones, because it can corrupt their address.
Examples of such tags can be seen here.
Note that recently I removed this character from URLs across the globe (around 1200), and yet it is growing again (around 60 right now).
Fortunately it seems this character only appears in the end (and maybe at the beginning) of an URL.

I opened a similar issue for the iD editor: https://github.com/openstreetmap/iD/issues/2323

Alternatively, this job could be delegated to JOSM Validator

Attachments (0)

Change History (9)

comment:1 Changed 3 years ago by mkoniecz

comment:2 Changed 3 years ago by jgpacker

Description: modified (diff)

comment:3 Changed 3 years ago by jgpacker

oops, fixed

comment:4 Changed 3 years ago by Don-vip

#9960 is related, although I was never able to reproduce the problem.

I approve removing these characters from URLs and e-mail addresses.

comment:5 Changed 3 years ago by jgpacker

I said before that I only saw this invisible character on either the beginning or the end of the tag's value, but I found a counter-example.
This node have an email=* tag with a LRM character both before and after the @ symbol.

comment:6 Changed 3 years ago by Don-vip

Keywords: unicode lrm character added

comment:7 Changed 3 years ago by Don-vip

Component: CoreCore validator
Milestone: 14.09

comment:8 Changed 3 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 7489/josm:

fix #10393 - Validation of URLs and e-mails in relevant tags, using modified subset of Apache Commons Validator 1.4

comment:9 Changed 3 years ago by Don-vip

Keywords: url email added

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.