source: josm

fix various issues:

• performance - inefficient use of keySet iterator instead of entrySet iterator
• squid:S2674: The value returned from a stream read should be checked
• remove unused imports
• improve javadoc

see #11384 - Attempt to fix UI problem with add tag dialog

fix #11339 - add man_made=storage_tank to preset and mappaint style (modified patch by brycenesbitt; icon derived from gasometer.png)

fix #11404 - High CPU load during tile loading in TMS layer and download box (patch by wiktorn)

squid:S1133 - remove deprecated code

fix #11380 - JOSM notes layer thinks that all notes were created on current date (regression of r8225)

fix #11405 - warn about very long segments (>15km for now)

fix various Sonar issues:

• squid:S1068: Unused private fields should be removed
• squid:S1155: Collection.isEmpty() should be used to test for emptiness
• squid:S1185: Overriding methods should do more than simply call the same method in the super class
• squid:S1694: An abstract class should have both abstract and concrete methods
• squid:S1905: Redundant casts should not be used
• squid:S2065: Fields in non-serializable classes should not be "transient"
• squid:S2583: Conditions should not unconditionally evaluate to "TRUE" or to "FALSE"
• squid:ModifiersOrderCheck: Modifiers should be declared in the correct order

still something left from mapcss switch

applied #10902 - TMS simultaneous connections (2nd patch by wiktorn)

revert build breaking change

add baselanguage keyword

fix potential NPEs and Sonar issues related to serialization

see #10512 - move taginfoextract.groovy to scripts directory

simplify URL encoding/decoding

see #11394 - do not warn about all club=* (e.g. club=chess|sailing|...) together with sport=*

update presets links

see #8562 - text improvement

see #8562 - move IPv6 detection to main class instead of preferences

fix #10396 - Disconnecting nodes from way could be easier

• Ignore non-connected nodes
• When exactly one way is selected, ignore nodes non-connected to this way
• Replace message dialog by notification.
• Add test case

fix #11381 - default language setting failed

code cleanup

fix #11353 - imagery offset regression (patch by wiktorn)

fix sonar squid:S1444 - "public static" fields should always be constant

typo

fix handling of khmer a bit

see #10512 - fix spelling

some smaller i18n updates as I anyway already processed them.

fix #11184 - "split way" is splitting an other way instead of the selected.
The case where the selected node is both one end and an intermediate node of the selected way was not taken into account.
Add test case.

see #10512 - taginfoextract: add initial presets extration, switch all links to HTTPS

see #10512 - Use Groovy's JsonBuilder

i18n update

fix #9533 - Do not autocomplete in combo boxes unless cursor is at the end

fix #9782 fix #10859 - MapCSS validator: evaluate real key and value for KeyConditions

hopefully fix #10864 - revert r8235, r8213 - Note layer: return to JToolTip based rendering - wrap long URLs using zero width space U+8203

see #10217 - "fix" test

see #10217 - move unit handling to parser
adds support for negative angles
new: length units px,cm,mm,in,q,pc,pt as in CSS (immediately converted to px)

see #10973 - Relation sorting: group platform* and stop* in front of other public_transport/route members

mapcss: improve expression parsing
Now it respects operator precedence (C/C++ style) and allows
mix of plus and minus like this:

3 + 2 * 5 - 2 + 10

This is parsed as

(((3 + (2 * 5)) - 2) + 10)

see #10789 - History dialog: add button to open changeset dialog

see #10529 - MapCSS: :unclosed_multipolygon should not trigger for incomplete multipolygons

fix #11358 - Search: allow negative indices for nth: to search backward

fix #11362 - do not confirm overwrite for OSX native file dialogs which already ask for it

i18n update

see #11359 - ignore unsupported date/time exif tags

fix #11360 - do not propose autofix for opening_hours with the same value as before

Open Location: enable loading of nodes/ways/relations/changesets from OSM website URL

Up to now, only corresponding API URLs have been supported.

see #10217 - Fix reset/flickering/cache issue wrt rotated MapCSS icons

see #10299 - Remove leftover, unwanted code line

fix #11354 - Add tags: clear input fields after adding tag without closing dialog