#10897 closed enhancement (fixed)
[patch] Mirror-download source checkboxes won't work
Reported by: | Owned by: | roland.olbricht | |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Plugin mirrored_download | Version: | tested |
Keywords: | template_report source checkbox | Cc: | bastiK, ToeBee |
Description (last modified by )
What steps will reproduce the problem?
- Download r7906, with plugin mirror-download
- Open Mirror-download window (file/mirror-download)
- Cannot select OSM data
Plugin was working fine with the last tested (7777 if I remember well).
What is the expected result?
What happens instead?
Please provide any additional information below. Attach a screenshot if possible.
Revision: 7906 Repository Root: http://josm.openstreetmap.de/svn Relative URL: ^/trunk Last Changed Author: Don-vip Last Changed Date: 2014-12-29 00:13:58 +0100 (Mon, 29 Dec 2014) Build-Date: 2014-12-29 00:11:17 URL: http://josm.openstreetmap.de/svn/trunk Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b Last Changed Rev: 7906 Identification: JOSM/1.5 (7906 fr) Windows 7 64-Bit Memory Usage: 113 MB / 247 MB (30 MB allocated, but free) Java version: 1.8.0_25, Oracle Corporation, Java HotSpot(TM) Client VM Plugins: - cadastre-fr (30859) - continuosDownload (1413902943) - download_along (30762) - geotools (30762) - jts (30762) - mirrored_download (30762) - notes (v0.9.5) - poly (30738) - reltoolbox (30841) - reverter (30737) - scripting (30702) - turnrestrictions (30762) - utilsplugin2 (30863)
Attachments (2)
Change History (16)
by , 9 years ago
Attachment: | Capture.PNG added |
---|
comment:1 by , 9 years ago
Description: | modified (diff) |
---|
comment:2 by , 9 years ago
Cc: | added |
---|
follow-up: 4 comment:3 by , 9 years ago
cannot reproduce. Tested with r7777, r7805, r7819 and r7906
Repository Root: http://josm.openstreetmap.de/svn Build-Date: 2014-12-29 00:11:17 Last Changed Author: Don-vip Revision: 7906 Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b Relative URL: ^/trunk URL: http://josm.openstreetmap.de/svn/trunk Last Changed Date: 2014-12-29 00:13:58 +0100 (Mon, 29 Dec 2014) Last Changed Rev: 7906 Identification: JOSM/1.5 (7906 en) Linux Debian GNU/Linux 7.7 (wheezy) Memory Usage: 376 MB / 882 MB (259 MB allocated, but free) Java version: 1.7.0_65, Oracle Corporation, OpenJDK 64-Bit Server VM Java package: openjdk-7-jre:amd64-7u71-2.5.3-2~deb7u1 Dataset consistency test: No problems found Plugins: - OpeningHoursEditor (30737) - conflation (0.1.7) - download_along (30762) - imagery-xml-bounds (30735) - imagery_offset_db (30808) - jts (30762) - mirrored_download (30762) - notes (v0.9.5) - photoadjust (30762) - reverter (30737) - terracer (30872) - todo (29154) - undelete (30762) - utilsplugin2 (30863) - waydownloader (30762) - wikipedia (30780) Last errors/warnings: - E: Failed to locate image 'sac_scale_icon.svg' - W: Mappaint style "standard" (sac_scale) icon "sac_scale_icon.svg" not found.
comment:4 by , 9 years ago
comment:5 by , 9 years ago
I tried again…
True, downloading works. But checked/unchecked buttons (osm data/gps) seems to remain asame to the normal download window, but grayed out. I thought it would just not work then…
But whatever the checked/unchecked controls, downloading starts anyway.
comment:6 by , 9 years ago
Thank you for reporting the issue.
However, the boxes always have been without effect. There is no mirror servie for GPS data.
I think I have greyed out the checkboxes some years ago to reduce confusion. If they were clickable in some intermediate version then this would have been non-intentional.
The reason why these boxes are visible at all is that the plugin re-uses the standard download dialogue. Beside saving development effort, this also reduced learning effort for the user. And has higher chances for long-term sustainability, because there are very few method calls from the plugin to the core that might break in later versions. The downside of this approach is: The plugin cannot pull the standard dialogue and just remove the third UI element. If the designers of the core decide to reorder elements then this may remove an essential part of the download dialogue. This was the reason to instead only grey out the checkboxes. If this hits an essential element then it is much easier to explain what has gone wrong.
If the checkboxes are the only problem then I ask you to close the ticket because they are greyed out on purpose.
by , 9 years ago
Attachment: | mirror.patch added |
---|
follow-up: 8 comment:7 by , 9 years ago
Summary: | Mirror-download won't work with 7906 → [patch] Mirror-download won't work with 7906 |
---|
Disabled usually means it cannot be changed, but the values are still valid. So how about checking the the OSM data download box and unchecking the GPX box, no matter what the previous user selection was in the normal download dialog. (see patch)
comment:8 by , 9 years ago
Replying to bastiK:
Disabled usually means it cannot be changed, but the values are still valid. So how about checking the the OSM data download box and unchecking the GPX box, no matter what the previous user selection was in the normal download dialog. (see patch)
+1
but you missed the Notes checkbox.
comment:9 by , 9 years ago
Description: | modified (diff) |
---|---|
Keywords: | source checkbox added |
Summary: | [patch] Mirror-download won't work with 7906 → [patch] Mirror-download source checkboxes won't work |
Type: | defect → enhancement |
comment:12 by , 9 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Now the same for "Download from Overpass API", please.
unexpected regression of r7808?