Changeset 7783 in josm

Timestamp:

2014-12-10T22:07:39+01:00 (9 years ago)

Author:

Don-vip

Message:

fix #10816 - add various safeguards to make sure to not upload empty keys

Location:

trunk/src/org/openstreetmap/josm

Files:

• actions/upload/FixDataHook.java (modified) (2 diffs)
• data/osm/AbstractPrimitive.java (modified) (3 diffs)
• tools/TextTagParser.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/actions/upload/FixDataHook.java

@@ -80 +80 @@
                 String v = Tag.removeWhiteSpaces(e.getValue());
                 String k = Tag.removeWhiteSpaces(e.getKey());
+                boolean drop = k.isEmpty() || v.isEmpty();
                 if(!e.getKey().equals(k)) {
-                    boolean drop = k.isEmpty() || v.isEmpty();
                     if(drop || !keys.containsKey(k)) {
                         newKeys.remove(e.getKey());
@@ -92 +92 @@
                     else
                         newKeys.put(k, v);
+                } else if (drop) {
+                    newKeys.remove(e.getKey());
                 }
             }

trunk/src/org/openstreetmap/josm/data/osm/AbstractPrimitive.java

@@ -18 +18 @@
 import java.util.concurrent.atomic.AtomicLong;
 
+import org.openstreetmap.josm.tools.Utils;
+
 /**
 * Abstract class to represent common features of the datatypes primitives.
@@ -509 +511 @@
      * removes the key and behaves like {@link #remove(String)}.
      *
-     * @param key  The key, for which the value is to be set. Can be null, does nothing in this case.
+     * @param key  The key, for which the value is to be set. Can be null or empty, does nothing in this case.
      * @param value The value for the key. If null, removes the respective key/value pair.
      *
@@ -517 +519 @@
     public void put(String key, String value) {
         Map<String, String> originalKeys = getKeys();
-        if (key == null)
+        if (key == null || Utils.strip(key).isEmpty())
             return;
         else if (value == null) {

trunk/src/org/openstreetmap/josm/tools/TextTagParser.java

@@ -204 +204 @@
         // Format
         // tag1\tval1\ntag2\tval2\n
-        tags = readTagsByRegexp(buf, "[\\r\\n]+", "(.*?)\\t(.*?)", false);
+        tags = readTagsByRegexp(buf, "[\\r\\n]+", "([a-zA-Z0-9:_]+)\\t(.*?)", false);
                 // try "tag\tvalue\n" format
         if (tags!=null) return tags;
@@ -213 +213 @@
         // a = "b=c" is OK
         // a = b=c  - this method of parsing fails intentionally
-        tags = readTagsByRegexp(buf, "[\\n\\t\\r]+", "(.*?)=(.*?)", true);
+        tags = readTagsByRegexp(buf, "[\\n\\t\\r]+", "([a-zA-Z0-9:_]+)=(.*?)", true);
                 // try format  t1=v1\n t2=v2\n ...
         if (tags!=null) return tags;