Changeset 6990 in josm for trunk/src/org/openstreetmap/josm/gui/help

Timestamp:

2014-04-19T00:36:43+02:00 (10 years ago)

Author:

Don-vip

Message:

sonar - place Strings literals on the left side when checking for equality (can avoid NPEs)

File:

• trunk/src/org/openstreetmap/josm/gui/help/HelpUtil.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/gui/help/HelpUtil.java

@@ -16 +16 @@
 import org.openstreetmap.josm.tools.LanguageInfo.LocaleType;
 
+/**
+ * Provides utility methods for help system.
+ * @since 2252
+ */
 public final class HelpUtil {
 
@@ -140 +144 @@
     public static String buildAbsoluteHelpTopic(String topic, LocaleType type) {
         String prefix = getHelpTopicPrefix(type);
-        if (prefix == null || topic == null || topic.trim().length() == 0 || topic.trim().equals("/"))
+        if (prefix == null || topic == null || topic.trim().length() == 0 || "/".equals(topic.trim()))
             return prefix;
         prefix += "/" + topic;
@@ -220 +224 @@
      *  </pre>
      *
-     *
-     * @param helpTopic
+     * @param helpTopic Help topic to mark
+     * @return {@code helpTopic}
      */
     public static String ht(String helpTopic) {