Changeset 5302 in josm

Timestamp:

Jun 25, 2012 10:16:36 PM (11 months ago)

Author:

Don-vip

Message:

fix #7756 - NPE in checkboxes creation

File:

• trunk/src/org/openstreetmap/josm/gui/io/ActionFlagsTableCell.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/gui/io/ActionFlagsTableCell.java

@@ -36 +36 @@
  */
 class ActionFlagsTableCell extends JPanel implements TableCellRenderer, TableCellEditor {
-    protected JCheckBox[] checkBoxes = new JCheckBox[2];
+    protected final JCheckBox[] checkBoxes = new JCheckBox[2];
     private CopyOnWriteArrayList<CellEditorListener> listeners;
 
@@ -49 +49 @@
         listeners = new CopyOnWriteArrayList<CellEditorListener>();
 
-        setLayout(new GridBagLayout());
         checkBoxes[0] = new JCheckBox(tr("Upload"));
         checkBoxes[1] = new JCheckBox(tr("Save"));
+        setLayout(new GridBagLayout());
 
         ActionMap am = getActionMap();
@@ -71 +71 @@
 
     protected void updateCheckboxes(Object v) {
-        boolean[] values;
-        if(v instanceof SaveLayerInfo) {
-            values = new boolean[2];
-            values[0] = ((SaveLayerInfo) v).isDoUploadToServer();
-            values[1] = ((SaveLayerInfo) v).isDoSaveToFile();
-        } else {
-            values = (boolean[]) v;
+        if (checkBoxes[0] != null && checkBoxes[1] != null) {
+            boolean[] values;
+            if(v instanceof SaveLayerInfo) {
+                values = new boolean[2];
+                values[0] = ((SaveLayerInfo) v).isDoUploadToServer();
+                values[1] = ((SaveLayerInfo) v).isDoSaveToFile();
+            } else {
+                values = (boolean[]) v;
+            }
+            checkBoxes[0].setSelected(values[0]);
+            checkBoxes[1].setSelected(values[1]);
         }
-        checkBoxes[0].setSelected(values[0]);
-        checkBoxes[1].setSelected(values[1]);
     }