Changeset 5219 in josm

Timestamp:

May 7, 2012 3:05:27 PM (13 months ago)

Author:

bastiK

Message:

mapstyles: add automatic reloading of local styles when they have been edited in an extenal editor (based on mtime)

Location:

trunk/src/org/openstreetmap/josm/gui

Files:

• MapView.java (modified) (2 diffs)
• dialogs/MapPaintDialog.java (modified) (6 diffs)
• mappaint/LineTextElemStyle.java (modified) (1 diff)
• mappaint/MapPaintStyles.java (modified) (3 diffs)
• mappaint/StyleSource.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/gui/MapView.java

@@ -238 +238 @@
             }
         });
-        
+
         // Add Multipolygon cache to layer listeners
         addLayerChangeListener(MultipolygonCache.getInstance());
@@ -730 +730 @@
             AbstractButton button = e.nextElement();
             MapMode mode = (MapMode)button.getAction();
-            boolean isLayerSupported = mode.layerIsSupported(layer); 
+            boolean isLayerSupported = mode.layerIsSupported(layer);
             button.setEnabled(isLayerSupported);
             // Also update associated shortcut (fix #6876)

trunk/src/org/openstreetmap/josm/gui/dialogs/MapPaintDialog.java

@@ -3 +3 @@
 
 import static org.openstreetmap.josm.tools.I18n.tr;
+import static org.openstreetmap.josm.tools.I18n.trn;
 
 import java.awt.Component;
@@ -11 +12 @@
 import java.awt.Point;
 import java.awt.Rectangle;
+import java.awt.Window;
 import java.awt.event.ActionEvent;
 import java.awt.event.ActionListener;
 import java.awt.event.KeyEvent;
 import java.awt.event.MouseEvent;
+import java.awt.event.WindowAdapter;
+import java.awt.event.WindowEvent;
 import java.io.BufferedInputStream;
 import java.io.BufferedOutputStream;
@@ -61 +65 @@
 import org.openstreetmap.josm.gui.SideButton;
 import org.openstreetmap.josm.gui.mappaint.MapPaintStyles;
+import org.openstreetmap.josm.gui.mappaint.MapPaintStyles.MapPaintStyleLoader;
 import org.openstreetmap.josm.gui.mappaint.MapPaintStyles.MapPaintSylesUpdateListener;
 import org.openstreetmap.josm.gui.mappaint.StyleSource;
@@ -143 +148 @@
         selectionModel.addListSelectionListener(upAction);
         selectionModel.addListSelectionListener(downAction);
-        
+
         // Toggle style on Enter and Spacebar
         InputMapUtils.addEnterAction(tblStyles, onoffAction);
         InputMapUtils.addSpacebarAction(tblStyles, onoffAction);
-        
+
         createLayout(p, true, Arrays.asList(new SideButton[] {
                 new SideButton(onoffAction, false),
@@ -173 +178 @@
     }
 
+    /**
+     * Reload local styles when they have been changed in an external editor.
+     *
+     * Checks file modification time when an WindowEvent is invoked. Because
+     * any dialog window can get activated, when switching to another app and back,
+     * we have to register listeners to all windows in JOSM.
+     */
+    protected static class ReloadWindowListener extends WindowAdapter {
+
+        private static ReloadWindowListener INSTANCE;
+
+        public static ReloadWindowListener getInstance() {
+            if (INSTANCE == null) {
+                INSTANCE = new ReloadWindowListener();
+            }
+            return INSTANCE;
+        }
+
+        public static void setup() {
+            for (Window w : Window.getWindows()) {
+                if (w.isShowing()) {
+                    w.addWindowListener(getInstance());
+                }
+            }
+        }
+
+        public static void teardown() {
+            for (Window w : Window.getWindows()) {
+                w.removeWindowListener(getInstance());
+            }
+        }
+
+        @Override
+        public void windowActivated(WindowEvent e) {
+            if (e.getOppositeWindow() == null) { // we come from a native window, e.g. editor
+                // reload local styles, if necessary
+                List<StyleSource> toReload = new ArrayList<StyleSource>();
+                for (StyleSource s : MapPaintStyles.getStyles().getStyleSources()) {
+                    if (s.isLocal()) {
+                        File f = new File(s.url);
+                        long mtime = f.lastModified();
+                        if (mtime > s.getLastMTime()) {
+                            toReload.add(s);
+                            s.setLastMTime(mtime);
+                        }
+                    }
+                }
+                if (!toReload.isEmpty()) {
+                    System.out.println(trn("Reloading {0} map style.", "Reloading {0} map styles.", toReload.size(), toReload.size()));
+                    Main.worker.submit(new MapPaintStyleLoader(toReload));
+                }
+            }
+        }
+
+        @Override
+        public void windowDeactivated(WindowEvent e) {
+            // set up windows that have been created in the meantime
+            for (Window w : Window.getWindows()) {
+                w.removeWindowListener(getInstance());
+                if (w.isShowing()) {
+                    w.addWindowListener(getInstance());
+                }
+            }
+        }
+    }
+
     @Override
     public void showNotify() {
         MapPaintStyles.addMapPaintSylesUpdateListener(model);
         Main.main.menu.wireFrameToggleAction.addButtonModel(cbWireframe.getModel());
+        if (Main.pref.getBoolean("mappaint.auto_reload_local_styles", true)) {
+            ReloadWindowListener.setup();
+        }
     }
 
@@ -183 +257 @@
         Main.main.menu.wireFrameToggleAction.removeButtonModel(cbWireframe.getModel());
         MapPaintStyles.removeMapPaintSylesUpdateListener(model);
+        if (Main.pref.getBoolean("mappaint.auto_reload_local_styles", true)) {
+            ReloadWindowListener.teardown();
+        }
     }
 

trunk/src/org/openstreetmap/josm/gui/mappaint/LineTextElemStyle.java

@@ -50 +50 @@
         return text.hashCode();
     }
+
+    @Override
+    public String toString() {
+        return "LineTextElemStyle{" + super.toString() + "text=" + text + "}";
+    }
+
 }

trunk/src/org/openstreetmap/josm/gui/mappaint/MapPaintStyles.java

@@ -4 +4 @@
 import static org.openstreetmap.josm.tools.I18n.tr;
 
+import java.io.File;
 import java.io.IOException;
 import java.io.InputStream;
@@ -21 +22 @@
 import org.openstreetmap.josm.gui.mappaint.mapcss.MapCSSStyleSource;
 import org.openstreetmap.josm.gui.mappaint.xml.XmlStyleSource;
+import org.openstreetmap.josm.gui.preferences.SourceEntry;
 import org.openstreetmap.josm.gui.preferences.map.MapPaintPreference.MapPaintPrefHelper;
-import org.openstreetmap.josm.gui.preferences.SourceEntry;
 import org.openstreetmap.josm.gui.progress.ProgressMonitor;
 import org.openstreetmap.josm.io.MirroredInputStream;
@@ -165 +166 @@
         for (StyleSource source : styles.getStyleSources()) {
             source.loadStyleSource();
-        }
-
+            if (Main.pref.getBoolean("mappaint.auto_reload_local_styles", true)) {
+                if (source.isLocal()) {
+                    File f = new File(source.url);
+                    source.setLastMTime(f.lastModified());
+                }
+            }
+        }
         fireMapPaintSylesUpdated();
     }

trunk/src/org/openstreetmap/josm/gui/mappaint/StyleSource.java

@@ -26 +26 @@
 
     private ImageIcon imageIcon;
+    private long lastMTime = 0l;
 
     /******
@@ -31 +32 @@
      * of the source file.
      */
-    
+
     public String icon;
 
@@ -104 +105 @@
         return null;
     }
+
+    public long getLastMTime() {
+        return lastMTime;
+    }
+
+    public void setLastMTime(long lastMTime) {
+        this.lastMTime = lastMTime;
+    }
+
+
 }