Changeset 5217 in josm

Timestamp:

May 6, 2012 9:23:18 PM (13 months ago)

Author:

bastiK

Message:

mapcss: change z-index handling

In contrast to previous default z-index of 1000 for nodes and -1000 for areas, the default z-index is
now always 0. An additional "major-z-index" is used to sort elemstyles by category, this property
can be adjusted in the style, so icons can be rendered below lines, if you want to.

Location:

trunk/src/org/openstreetmap/josm

Files:

• data/osm/visitor/paint/StyledMapRenderer.java (modified) (3 diffs)
• gui/mappaint/AreaElemStyle.java (modified) (1 diff)
• gui/mappaint/BoxTextElemStyle.java (modified) (2 diffs)
• gui/mappaint/ElemStyle.java (modified) (7 diffs)
• gui/mappaint/LineElemStyle.java (modified) (5 diffs)
• gui/mappaint/LinePatternElemStyle.java (modified) (1 diff)
• gui/mappaint/LineTextElemStyle.java (modified) (1 diff)
• gui/mappaint/NodeElemStyle.java (modified) (6 diffs)

trunk/src/org/openstreetmap/josm/data/osm/visitor/paint/StyledMapRenderer.java

@@ -28 +28 @@
 /**
  * <p>A map renderer which renders a map according to style rules in a set of style sheets.</p>
- * 
+ *
  */
 public class StyledMapRenderer extends AbstractMapRenderer{
@@ -39 +39 @@
     private static int FLAG_NORMAL = 0;
     private static int FLAG_DISABLED = 1;
-    private static int FLAG_SELECTED = 2;
-    private static int FLAG_MEMBER_OF_SELECTED = 4;
+    private static int FLAG_MEMBER_OF_SELECTED = 2;
+    private static int FLAG_SELECTED = 4;
 
     private static class StyleRecord implements Comparable<StyleRecord> {
@@ -59 +59 @@
             if ((this.flags & FLAG_DISABLED) == 0 && (other.flags & FLAG_DISABLED) != 0)
                 return 1;
-            float z_index1 = this.style.z_index;
-            if ((this.flags & FLAG_SELECTED) != 0) {
-                z_index1 += 700f;
-            } else if ((this.flags & FLAG_MEMBER_OF_SELECTED) != 0) {
-                z_index1 += 600f;
-            }
-            float z_index2 = other.style.z_index;
-            if ((other.flags & FLAG_SELECTED) != 0) {
-                z_index2 += 700f;
-            } else if ((other.flags & FLAG_MEMBER_OF_SELECTED) != 0) {
-                z_index2 += 600f;
-            }
-
-            int d1 = Float.compare(z_index1, z_index2);
-            if (d1 != 0)
-                return d1;
+
+            int d0 = Float.compare(this.style.major_z_index, other.style.major_z_index);
+            if (d0 != 0)
+                return d0;
+
+            // selected on top of member of selected on top of unselected
+            // FLAG_DISABLED bit is the same at this point
+            if (this.flags > other.flags)
+                return 1;
+            if (this.flags < other.flags)
+                return -1;
+
+            int dz = Float.compare(this.style.z_index, other.style.z_index);
+            if (dz != 0)
+                return dz;
 
             // simple node on top of icons and shapes

trunk/src/org/openstreetmap/josm/gui/mappaint/AreaElemStyle.java

@@ -28 +28 @@
 
     protected AreaElemStyle(Cascade c, Color color, MapImage fillImage, TextElement text) {
-        super(c, -1000f);
+        super(c, 1f);
         CheckParameterUtil.ensureParameterNotNull(color);
         this.color = color;

trunk/src/org/openstreetmap/josm/gui/mappaint/BoxTextElemStyle.java

@@ -90 +90 @@
 
     public BoxTextElemStyle(Cascade c, TextElement text, BoxProvider boxProvider, Rectangle box, HorizontalTextAlignment hAlign, VerticalTextAlignment vAlign) {
-        super(c, 2000f);
+        super(c, 5f);
         CheckParameterUtil.ensureParameterNotNull(text);
         CheckParameterUtil.ensureParameterNotNull(hAlign);
@@ -197 +197 @@
         if (boxProvider != null) {
             if (!boxProvider.equals(other.boxProvider)) return false;
-        } else if (other.boxProvider != null) {
+        } else if (other.boxProvider != null)
             return false;
-        } else {
+        else {
             if (!box.equals(other.box)) return false;
         }

trunk/src/org/openstreetmap/josm/gui/mappaint/ElemStyle.java

@@ -16 +16 @@
 abstract public class ElemStyle {
 
+    public float major_z_index;
     public float z_index;
     public float object_z_index;
@@ -21 +22 @@
     // primitive; true, if it is a highlight or modifier
 
-    public ElemStyle(float z_index, float object_z_index, boolean isModifier) {
+    public ElemStyle(float major_z_index, float z_index, float object_z_index, boolean isModifier) {
+        this.major_z_index = major_z_index;
         this.z_index = z_index;
         this.object_z_index = object_z_index;
@@ -27 +29 @@
     }
 
-    protected ElemStyle(Cascade c, float default_z_index) {
-        z_index = c.get("z-index", default_z_index, Float.class);
+    protected ElemStyle(Cascade c, float default_major_z_index) {
+        major_z_index = c.get("major-z-index", default_major_z_index, Float.class);
+        z_index = c.get("z-index", 0f, Float.class);
         object_z_index = c.get("object-z-index", 0f, Float.class);
         isModifier = c.get("modifier", false, Boolean.class);
@@ -81 +84 @@
      * expensive lookups and to avoid too many font objects
      * (in analogy to flyweight pattern).
-     * 
+     *
      * FIXME: cached preference values are not updated if the user changes them during
      * a JOSM session. Should have a listener listening to preference changes.
@@ -170 +173 @@
             return false;
         ElemStyle s = (ElemStyle) o;
-        return z_index == s.z_index && object_z_index == s.object_z_index && isModifier == s.isModifier;
+        return major_z_index == s.major_z_index &&
+                z_index == s.z_index &&
+                object_z_index == s.object_z_index &&
+                isModifier == s.isModifier;
     }
 
@@ -176 +182 @@
     public int hashCode() {
         int hash = 5;
+        hash = 41 * hash + Float.floatToIntBits(this.major_z_index);
         hash = 41 * hash + Float.floatToIntBits(this.z_index);
         hash = 41 * hash + Float.floatToIntBits(this.object_z_index);
@@ -184 +191 @@
     @Override
     public String toString() {
-        if (z_index != 0f || object_z_index != 0f)
-            return String.format("z_idx=%s/%s ", z_index, object_z_index) + (isModifier ? "modifier " : "");
-        return "";
+        return String.format("z_idx=[%s/%s/%s] ", major_z_index, z_index, object_z_index) + (isModifier ? "modifier " : "");
     }
 }

trunk/src/org/openstreetmap/josm/gui/mappaint/LineElemStyle.java

@@ -40 +40 @@
 
     protected enum LineType {
-        NORMAL(""),
-        CASING("casing-"),
-        LEFT_CASING("left-casing-"),
-        RIGHT_CASING("right-casing-");
-
-        public String prefix;
-
-        LineType(String prefix) {
+        NORMAL("", 3f),
+        CASING("casing-", 2f),
+        LEFT_CASING("left-casing-", 2.1f),
+        RIGHT_CASING("right-casing-", 2.1f);
+
+        public final String prefix;
+        public final float default_major_z_index;
+
+        LineType(String prefix, float default_major_z_index) {
             this.prefix = prefix;
-        }
-    }
-
-    protected LineElemStyle(Cascade c, BasicStroke line, Color color, BasicStroke dashesLine, Color dashesBackground, float offset, float realWidth) {
-        super(c, 0f);
+            this.default_major_z_index = default_major_z_index;
+        }
+    }
+
+    protected LineElemStyle(Cascade c, float default_major_z_index, BasicStroke line, Color color, BasicStroke dashesLine, Color dashesBackground, float offset, float realWidth) {
+        super(c, default_major_z_index);
         this.line = line;
         this.color = color;
@@ -69 +71 @@
         LineElemStyle leftCasing = createImpl(env, LineType.LEFT_CASING);
         if (leftCasing != null) {
-            leftCasing.z_index += -90;
             leftCasing.isModifier = true;
         }
@@ -78 +79 @@
         LineElemStyle rightCasing = createImpl(env, LineType.RIGHT_CASING);
         if (rightCasing != null) {
-            rightCasing.z_index += -90;
             rightCasing.isModifier = true;
         }
@@ -87 +87 @@
         LineElemStyle casing = createImpl(env, LineType.CASING);
         if (casing != null) {
-            casing.z_index += -100;
             casing.isModifier = true;
         }
@@ -263 +262 @@
         }
 
-        return new LineElemStyle(c, line, color, dashesLine, dashesBackground, offset, realWidth);
+        return new LineElemStyle(c, type.default_major_z_index, line, color, dashesLine, dashesBackground, offset, realWidth);
     }
 

trunk/src/org/openstreetmap/josm/gui/mappaint/LinePatternElemStyle.java

@@ -16 +16 @@
 
     public LinePatternElemStyle(Cascade c, MapImage pattern) {
-        super(c, -1f);
+        super(c, 2.9f);
         this.pattern = pattern;
     }

trunk/src/org/openstreetmap/josm/gui/mappaint/LineTextElemStyle.java

@@ -10 +10 @@
 
 public class LineTextElemStyle extends ElemStyle {
-    
+
     private TextElement text;
 
     protected LineTextElemStyle(Cascade c, TextElement text) {
-        super(c, 2f);
+        super(c, 4.9f);
         this.text = text;
     }

trunk/src/org/openstreetmap/josm/gui/mappaint/NodeElemStyle.java

@@ -15 +15 @@
 import org.openstreetmap.josm.data.osm.visitor.paint.MapPaintSettings;
 import org.openstreetmap.josm.data.osm.visitor.paint.MapPainter;
+import org.openstreetmap.josm.gui.mappaint.BoxTextElemStyle.BoxProvider;
+import org.openstreetmap.josm.gui.mappaint.BoxTextElemStyle.SimpleBoxProvider;
 import org.openstreetmap.josm.gui.mappaint.MapPaintStyles.IconReference;
 import org.openstreetmap.josm.gui.mappaint.StyleCache.StyleList;
-import org.openstreetmap.josm.gui.mappaint.BoxTextElemStyle.BoxProvider;
-import org.openstreetmap.josm.gui.mappaint.BoxTextElemStyle.SimpleBoxProvider;
-import org.openstreetmap.josm.tools.Pair;
 import org.openstreetmap.josm.tools.Utils;
 
@@ -85 +84 @@
         MultiCascade mc = new MultiCascade();
         Cascade c = mc.getOrCreateCascade("default");
-        SIMPLE_NODE_ELEMSTYLE = create(new Environment(null, mc, "default", null), true);
+        SIMPLE_NODE_ELEMSTYLE = create(new Environment(null, mc, "default", null), 4.1f, true);
         if (SIMPLE_NODE_ELEMSTYLE == null) throw new AssertionError();
     }
@@ -92 +91 @@
     public static final StyleList DEFAULT_NODE_STYLELIST_TEXT = new StyleList(NodeElemStyle.SIMPLE_NODE_ELEMSTYLE, BoxTextElemStyle.SIMPLE_NODE_TEXT_ELEMSTYLE);
 
-    protected NodeElemStyle(Cascade c, MapImage mapImage, Symbol symbol) {
-        super(c, 1000f);
+    protected NodeElemStyle(Cascade c, MapImage mapImage, Symbol symbol, float default_major_z_index) {
+        super(c, default_major_z_index);
         this.mapImage = mapImage;
         this.symbol = symbol;
@@ -99 +98 @@
 
     public static NodeElemStyle create(Environment env) {
-        return create(env, false);
-    }
-
-    private static NodeElemStyle create(Environment env, boolean allowDefault) {
+        return create(env, 4f, false);
+    }
+
+    private static NodeElemStyle create(Environment env, float default_major_z_index, boolean allowDefault) {
         Cascade c = env.mc.getCascade(env.layer);
 
@@ -116 +115 @@
         if (!allowDefault && symbol == null && mapImage == null) return null;
 
-        return new NodeElemStyle(c, mapImage, symbol);
+        return new NodeElemStyle(c, mapImage, symbol, default_major_z_index);
     }
 
@@ -302 +301 @@
 
     public BoxProvider getBoxProvider() {
-        if (mapImage != null) {
+        if (mapImage != null)
             return mapImage.getBoxProvider();
-        } else if (symbol != null) {
+        else if (symbol != null)
             return new SimpleBoxProvider(new Rectangle(-symbol.size/2, -symbol.size/2, symbol.size, symbol.size));
-        } else {
+        else {
             // This is only executed once, so no performance concerns.
             // However, it would be better, if the settings could be changed at runtime.