Changeset 5169 in josm

Timestamp:

Apr 5, 2012 5:29:22 PM (14 months ago)

Author:

simon04

Message:

(hopefully) fix #7574 - NameTemplate stopped working

Location:

trunk/src/org/openstreetmap/josm

Files:

• gui/tagging/TaggingPreset.java (modified) (1 diff)
• tools/TaggingPresetNameTemplateList.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/tagging/TaggingPreset.java

@@ -1692 +1692 @@
     }
 
+    public boolean typeMatches(Collection<PresetType> t) {
+        return t == null || types == null || types.containsAll(t);
+    }
+
     public boolean matches(Collection<PresetType> t, Map<String, String> tags, boolean onlyShowable) {
         if (onlyShowable && !isShowable()) {
             return false;
-        } else if (t != null && types != null && !types.containsAll(t)) {
+        } else if (!typeMatches(t)) {
             return false;
         }

trunk/src/org/openstreetmap/josm/tools/TaggingPresetNameTemplateList.java

@@ -2 +2 @@
 package org.openstreetmap.josm.tools;
 
-import java.util.EnumSet;
+import java.util.Collection;
+import java.util.Collections;
 import java.util.LinkedList;
 import java.util.List;
@@ -39 +40 @@
 
         for (TaggingPreset t : presetsWithPattern) {
-            if (t.matches(EnumSet.of(PresetType.forPrimitive(primitive)), primitive.getKeys(), false)) {
-                return t;
+            Collection<PresetType> type = Collections.singleton(PresetType.forPrimitive(primitive));
+            if (t.typeMatches(type)) {
+                if (t.nameTemplateFilter != null) {
+                    if (t.nameTemplateFilter.match(primitive))
+                        return t;
+                    else {
+                        continue;
+                    }
+                } else if (t.matches(type, primitive.getKeys(), false)) {
+                    return t;
+                }
             }
         }