Changeset 5159 in josm

Timestamp:

Apr 1, 2012 10:20:11 PM (14 months ago)

Author:

simon04

Message:

see #7552 - damn confusion with Greek letters: apply delta instead of gamma patch ;-) (translation should work correctly now)

Location:

trunk/src/org/openstreetmap/josm

Files:

• gui/tagging/TaggingPreset.java (modified) (5 diffs)
• tools/Utils.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/tagging/TaggingPreset.java

@@ -77 +77 @@
 import org.openstreetmap.josm.tools.ImageProvider;
 import org.openstreetmap.josm.tools.UrlLabel;
+import org.openstreetmap.josm.tools.Utils;
 import org.openstreetmap.josm.tools.XmlObjectParser;
 import org.openstreetmap.josm.tools.template_engine.ParseError;
@@ -268 +269 @@
         public String short_description;
         public String icon;
+        public String locale_display_value;
+        public String locale_short_description;
 
         public String getListDisplay() {
@@ -276 +279 @@
                 return " ";
 
-            StringBuilder res = new StringBuilder("<b>");
-            if (display_value != null) {
-                res.append(display_value);
-            } else {
-                res.append(value);
-            }
+            final StringBuilder res = new StringBuilder("<b>");
+            final String displ = Utils.firstNonNull(locale_display_value, tr(display_value), tr(value));
+            res.append(displ);
             res.append("</b>");
-            if (short_description != null) {
+            final String descr = Utils.firstNonNull(locale_short_description, tr(short_description));
+            if (descr != null) {
                 // wrap in table to restrict the text width
-                res.append("<div style=\"width:300px; padding:0 0 5px 5px\">").append(short_description).append("</div>");
+                res.append("<div style=\"width:300px; padding:0 0 5px 5px\">").append(descr).append("</div>");
             }
             return res.toString();
@@ -299 +300 @@
         public PresetListEntry(String value) {
             this.value = value;
-            this.display_value = value;
-        }
-
-        public PresetListEntry(String value, String display_value) {
-            this.value = value;
-            this.display_value = display_value;
         }
 
@@ -593 +588 @@
 
         private String[] initListEntriesFromAttributes() {
-
             char delChar = getDelChar();
 
             String[] value_array = splitEscaped(delChar, values);
-            String[] display_array;
-            String[] short_descriptions_array = null;
-
-            if (locale_display_values != null) {
-                display_array = splitEscaped(delChar, locale_display_values);
-            } else if (display_values != null) {
-                display_array = splitEscaped(delChar, display_values);
-            } else {
-                display_array = value_array;
-            }
-
-            if (locale_short_descriptions != null) {
-                short_descriptions_array = splitEscaped(delChar, locale_short_descriptions);
-            } else if (short_descriptions != null) {
-                short_descriptions_array = splitEscaped(delChar, short_descriptions);
-            }
+
+            final String displ = Utils.firstNonNull(locale_display_values, display_values);
+            String[] display_array = displ == null ? value_array : splitEscaped(delChar, displ);
+
+            final String descr = Utils.firstNonNull(locale_short_descriptions, short_descriptions);
+            String[] short_descriptions_array = descr == null ? null : splitEscaped(delChar, descr);
 
             if (display_array.length != value_array.length) {

trunk/src/org/openstreetmap/josm/tools/Utils.java

@@ -63 +63 @@
     }
 
-        public static <T> Collection<T> filter(Collection<? extends T> collection, Predicate<? super T> predicate) {
-                return new FilteredCollection<T>(collection, predicate);
-        }
+    public static <T> Collection<T> filter(Collection<? extends T> collection, Predicate<? super T> predicate) {
+        return new FilteredCollection<T>(collection, predicate);
+    }
+
+    public static <T> T firstNonNull(T... items) {
+        for (T i : items) {
+            if (i != null) {
+                return i;
+            }
+        }
+        return null;
+    }
 
     /**