Changeset 5077 in josm

Timestamp:

Mar 13, 2012 8:25:45 PM (14 months ago)

Author:

xeen

Message:

Bring area icon to most (all?) places in core. Fixes #6318 (related: #7036)

Location:

trunk/src/org/openstreetmap/josm

Files:

• command/AddCommand.java (modified) (1 diff)
• command/ChangeCommand.java (modified) (2 diffs)
• command/ChangePropertyCommand.java (modified) (3 diffs)
• command/ChangeRelationMemberRoleCommand.java (modified) (3 diffs)
• command/ConflictAddCommand.java (modified) (3 diffs)
• command/DeleteCommand.java (modified) (6 diffs)
• corrector/TagCorrector.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/command/AddCommand.java

@@ -74 +74 @@
     @Override
     public Icon getDescriptionIcon() {
-        return ImageProvider.get(OsmPrimitiveType.from(osm));
+        return ImageProvider.get(osm.getDisplayType());
     }
 

trunk/src/org/openstreetmap/josm/command/ChangeCommand.java

@@ -6 +6 @@
 
 import java.util.Collection;
+
 import javax.swing.Icon;
 
@@ -62 +63 @@
     @Override
     public Icon getDescriptionIcon() {
-        return ImageProvider.get(OsmPrimitiveType.from(osm));
+        return ImageProvider.get(osm.getDisplayType());
     }
 }

trunk/src/org/openstreetmap/josm/command/ChangePropertyCommand.java

@@ -14 +14 @@
 import java.util.List;
 import java.util.Map;
+
 import javax.swing.Icon;
 
@@ -181 +182 @@
                 }
             }
-            
+
             if (allnull) {
                 text = tr("Deleted {0} properties for {1} objects", tags.size(), objects.size());
@@ -206 +207 @@
 
                 @Override public Icon getDescriptionIcon() {
-                    return ImageProvider.get(OsmPrimitiveType.from(osm));
+                    return ImageProvider.get(osm.getDisplayType());
                 }
 

trunk/src/org/openstreetmap/josm/command/ChangeRelationMemberRoleCommand.java

@@ -7 +7 @@
 
 import javax.swing.Icon;
+
 import org.openstreetmap.josm.data.osm.OsmPrimitive;
 import org.openstreetmap.josm.data.osm.OsmPrimitiveType;
@@ -40 +41 @@
 
     @Override public boolean executeCommand() {
-        if (position < 0 || position >= relation.getMembersCount()) {
+        if (position < 0 || position >= relation.getMembersCount())
             return false;
-        }
 
         oldRole = relation.getMember(position).getRole();
@@ -71 +71 @@
     @Override
     public Icon getDescriptionIcon() {
-        return ImageProvider.get(OsmPrimitiveType.from(relation));
+        return ImageProvider.get(relation.getDisplayType());
     }
 }

trunk/src/org/openstreetmap/josm/command/ConflictAddCommand.java

@@ -5 +5 @@
 
 import java.util.Collection;
+
 import javax.swing.Icon;
 import javax.swing.JOptionPane;
@@ -11 +12 @@
 import org.openstreetmap.josm.data.conflict.Conflict;
 import org.openstreetmap.josm.data.osm.OsmPrimitive;
-import org.openstreetmap.josm.data.osm.OsmPrimitiveType;
 import org.openstreetmap.josm.gui.DefaultNameFormatter;
 import org.openstreetmap.josm.gui.layer.OsmDataLayer;
@@ -70 +70 @@
     @Override
     public Icon getDescriptionIcon() {
-        return ImageProvider.get(OsmPrimitiveType.from(conflict.getMy()));
+        return ImageProvider.get(conflict.getMy().getDisplayType());
     }
 }

trunk/src/org/openstreetmap/josm/command/DeleteCommand.java

@@ -2 +2 @@
 package org.openstreetmap.josm.command;
 
-import java.awt.GridBagLayout;
-import java.awt.geom.Area;
 import static org.openstreetmap.josm.tools.I18n.marktr;
 import static org.openstreetmap.josm.tools.I18n.tr;
 import static org.openstreetmap.josm.tools.I18n.trn;
 
+import java.awt.GridBagLayout;
+import java.awt.geom.Area;
 import java.util.ArrayList;
 import java.util.Collection;
@@ -19 +19 @@
 import java.util.Set;
 import java.util.Map.Entry;
+
 import javax.swing.Icon;
-
 import javax.swing.JLabel;
-
 import javax.swing.JOptionPane;
 import javax.swing.JPanel;
+
 import org.openstreetmap.josm.Main;
 import org.openstreetmap.josm.actions.SplitWayAction;
@@ -160 +160 @@
     @Override
     public String getDescriptionText() {
-           if (toDelete.size() == 1) {
+        if (toDelete.size() == 1) {
             OsmPrimitive primitive = toDelete.iterator().next();
             String msg = "";
@@ -189 +189 @@
     @Override
     public Icon getDescriptionIcon() {
-        if (toDelete.size() == 1) {
-            return ImageProvider.get(OsmPrimitiveType.from(toDelete.iterator().next()));
-        }
+        if (toDelete.size() == 1)
+            return ImageProvider.get(toDelete.iterator().next().getDisplayType());
         Set<OsmPrimitiveType> typesToDelete = getTypesToDelete();
-        if (typesToDelete.size() > 1) {
+        if (typesToDelete.size() > 1)
             return ImageProvider.get("data", "object");
-        } else {
+        else
             return ImageProvider.get(typesToDelete.iterator().next());
-        }
     }
 
@@ -213 +211 @@
 
                     @Override public Icon getDescriptionIcon() {
-                        return ImageProvider.get(OsmPrimitiveType.from(osm));
+                        return ImageProvider.get(osm.getDisplayType());
                     }
 
@@ -345 +343 @@
 
         Collection<Relation> relationsToDelete = Utils.filteredCollection(primitivesToDelete, Relation.class);
-        if(!relationsToDelete.isEmpty() && !silent && !confirmRelationDeletion(relationsToDelete)) {
-            return null;
-        }
+        if(!relationsToDelete.isEmpty() && !silent && !confirmRelationDeletion(relationsToDelete))
+            return null;
 
         Collection<Way> waysToBeChanged = new HashSet<Way>();

trunk/src/org/openstreetmap/josm/corrector/TagCorrector.java

@@ -26 +26 @@
 import org.openstreetmap.josm.data.osm.Node;
 import org.openstreetmap.josm.data.osm.OsmPrimitive;
-import org.openstreetmap.josm.data.osm.OsmPrimitiveType;
 import org.openstreetmap.josm.data.osm.Relation;
 import org.openstreetmap.josm.data.osm.Way;
@@ -89 +88 @@
                 final JLabel primitiveLabel = new JLabel(
                         primitive.getDisplayName(DefaultNameFormatter.getInstance()) + ":",
-                        ImageProvider.get(OsmPrimitiveType.from(primitive)),
+                        ImageProvider.get(primitive.getDisplayType()),
                         JLabel.LEFT
                 );
@@ -116 +115 @@
                 final JLabel primitiveLabel = new JLabel(
                         primitive.getDisplayName(DefaultNameFormatter.getInstance()),
-                        ImageProvider.get(OsmPrimitiveType.from(primitive)),
+                        ImageProvider.get(primitive.getDisplayType()),
                         JLabel.LEFT
                 );