Changeset 4930 in josm

Timestamp:

Feb 14, 2012 1:26:15 PM (16 months ago)

Author:

Don-vip

Message:

see #7386 - Speed up keyCodes retrieving (from ~50ms to 1ms only)

File:

• trunk/src/org/openstreetmap/josm/gui/preferences/PrefJPanel.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/preferences/PrefJPanel.java

@@ -11 +11 @@
 
 import java.awt.event.KeyEvent;
+import java.lang.reflect.Field;
 import java.util.ArrayList;
 import java.util.LinkedHashMap;
@@ -106 +107 @@
         Map<Integer, String> list = new LinkedHashMap<Integer, String>();
         String unknown = Toolkit.getProperty("AWT.unknown", "Unknown");
-        // I hate this, but I found no alternative...
-        for (int i = 0; i < 65534; i++) {
-            String s = KeyEvent.getKeyText(i);
-            if (s != null && s.length() > 0 && !s.contains(unknown)) {
-                list.put(Integer.valueOf(i), s);
-                //System.out.println(i+": "+s);
+        // Assume all known keys are declared in KeyEvent as "public static int VK_*"
+        for (Field field : KeyEvent.class.getFields()) {
+            if (field.getName().startsWith("VK_")) {
+                try {
+                    int i = field.getInt(null);
+                    String s = KeyEvent.getKeyText(i);
+                    if (s != null && s.length() > 0 && !s.contains(unknown)) {
+                        list.put(Integer.valueOf(i), s);
+                        //System.out.println(i+": "+s);
+                    }
+                } catch (Exception e) {
+                    e.printStackTrace();
+                }
             }
         }