Changeset 4797 in josm

Timestamp:

Jan 15, 2012 9:42:25 PM (16 months ago)

Author:

simon04

Message:

fix #4062 - remotecontrol prints stack trace when it can't bind to the default port

File:

• trunk/src/org/openstreetmap/josm/io/remotecontrol/RemoteControlHttpServer.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/io/remotecontrol/RemoteControlHttpServer.java

@@ -2 +2 @@
 package org.openstreetmap.josm.io.remotecontrol;
 
+import static org.openstreetmap.josm.tools.I18n.tr;
+
 import java.io.IOException;
+import java.net.BindException;
 import java.net.ServerSocket;
 import java.net.Socket;
@@ -14 +17 @@
  * Taken from YWMS plugin by frsantos.
  */
-
 public class RemoteControlHttpServer extends Thread {
 
@@ -28 +30 @@
      * Starts or restarts the HTTP server
      */
-    public static void restartRemoteControlHttpServer()
-    {
-        try
-        {
-            if (instance != null)
+    public static void restartRemoteControlHttpServer() {
+        try {
+            if (instance != null) {
                 instance.stopServer();
+            }
 
-            int port = DEFAULT_PORT;
-            instance = new RemoteControlHttpServer(port);
+            instance = new RemoteControlHttpServer(DEFAULT_PORT);
             instance.start();
-        }
-        catch(IOException ioe)
-        {
+        } catch (BindException ex) {
+            System.err.println(tr("Warning: Cannot start remotecontrol server on port {0}: {1}",
+                    Integer.toString(DEFAULT_PORT), ex.getLocalizedMessage()));
+        } catch (IOException ioe) {
             ioe.printStackTrace();
         }
@@ -79 +80 @@
                 if( !server.isClosed() )
                     se.printStackTrace();
-            }
+                }
             catch (IOException ioe)
             {