Changeset 4114 in josm

Timestamp:

Jun 1, 2011 10:23:11 PM (2 years ago)

Author:

stoecker

Message:

setting a save file in the close layer dialog now works as expected

Location:

trunk/src/org/openstreetmap/josm

Files:

• actions/SaveAction.java (modified) (1 diff)
• actions/SaveActionBase.java (modified) (3 diffs)
• gui/io/SaveLayerTask.java (modified) (1 diff)
• gui/io/SaveLayersModel.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/actions/SaveAction.java

@@ -37 +37 @@
         }
 
-        // FIXME: why only for GpxLayer?
+        // Ask for overwrite in case of GpxLayer: GpxLayers usually are imports
+        // and modifying is an error most of the time.
         if(f != null && layer instanceof GpxLayer) {
             ExtendedDialog dialog = new ExtendedDialog(

trunk/src/org/openstreetmap/josm/actions/SaveActionBase.java

@@ -46 +46 @@
 
     public boolean doSave(Layer layer) {
-        if (layer == null)
-            return false;
-        if ( !(layer instanceof OsmDataLayer) && !(layer instanceof GpxLayer))
-            return false;
-        if (!checkSaveConditions(layer))
-            return false;
-
-        File file = getFile(layer);
+        if(!checkSaveConditions(layer))
+            return false;
+        return doInternalSave(layer, getFile(layer));
+    }
+
+    public boolean doSave(Layer layer, File file) {
+        if(!checkSaveConditions(layer))
+            return false;
+        return doInternalSave(layer, file);
+    }
+
+    private boolean doInternalSave(Layer layer, File file) {
         if (file == null)
             return false;
@@ -91 +95 @@
      */
     public boolean checkSaveConditions(Layer layer) {
-        if (layer instanceof OsmDataLayer && isDataSetEmpty((OsmDataLayer)layer)) {
-            ExtendedDialog dialog = new ExtendedDialog(
-                    Main.parent,
-                    tr("Empty document"),
-                    new String[] {tr("Save anyway"), tr("Cancel")}
-            );
-            dialog.setContent(tr("The document contains no data."));
-            dialog.setButtonIcons(new String[] {"save.png", "cancel.png"});
-            dialog.showDialog();
-            if (dialog.getValue() != 1) return false;
-        }
-
-        if (layer instanceof GpxLayer && ((GpxLayer)layer).data == null)
-            return false;
-        if (layer instanceof OsmDataLayer)  {
+        if (layer instanceof GpxLayer)
+            return ((GpxLayer)layer).data != null;
+        else if (layer instanceof OsmDataLayer)  {
+            if (isDataSetEmpty((OsmDataLayer)layer)) {
+                ExtendedDialog dialog = new ExtendedDialog(
+                        Main.parent,
+                        tr("Empty document"),
+                        new String[] {tr("Save anyway"), tr("Cancel")}
+                );
+                dialog.setContent(tr("The document contains no data."));
+                dialog.setButtonIcons(new String[] {"save.png", "cancel.png"});
+                dialog.showDialog();
+                if (dialog.getValue() != 1) return false;
+            }
+
             ConflictCollection conflicts = ((OsmDataLayer)layer).getConflicts();
             if (conflicts != null && !conflicts.isEmpty()) {
@@ -119 +123 @@
                 if (dialog.getValue() != 1) return false;
             }
-        }
-        return true;
+            return true;
+        }
+        return false;
     }
 

trunk/src/org/openstreetmap/josm/gui/io/SaveLayerTask.java

@@ -48 +48 @@
         try {
             parentMonitor.subTask(tr("Saving layer to ''{0}'' ...", layerInfo.getFile().toString()));
-            layerInfo.getLayer().setAssociatedFile(layerInfo.getFile());
-            if (!new SaveAction().doSave(layerInfo.getLayer())) {
+            if (!new SaveAction().doSave(layerInfo.getLayer(), layerInfo.getFile())) {
                 setFailed(true);
                 return;

trunk/src/org/openstreetmap/josm/gui/io/SaveLayersModel.java

@@ -116 +116 @@
         List<SaveLayerInfo> ret =new ArrayList<SaveLayerInfo>();
         for (SaveLayerInfo info: layerInfo) {
-            if (info.isDoSaveToFile() && info.getFile() != null && ! info.getFile().canWrite()) {
+            if (info.isDoSaveToFile() && info.getFile() != null && info.getFile().exists() && !info.getFile().canWrite()) {
                 ret.add(info);
             }