Changeset 3827 in josm

Timestamp:

Jan 28, 2011 6:58:56 PM (2 years ago)

Author:

bastiK

Message:

IconElemStyle: delay the loading of imagage icon until it is actually displayed on screen

Location:

trunk/src/org/openstreetmap/josm/gui

Files:

• mappaint/MapPaintStyles.java (modified) (6 diffs)
• mappaint/xml/IconPrototype.java (modified) (3 diffs)
• mappaint/xml/XmlStyleSource.java (modified) (3 diffs)
• mappaint/xml/XmlStyleSourceHandler.java (modified) (2 diffs)
• preferences/SourceEntry.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/mappaint/MapPaintStyles.java

@@ -23 +23 @@
 import org.openstreetmap.josm.tools.ImageProvider;
 import org.openstreetmap.josm.tools.XmlObjectParser;
+import org.openstreetmap.josm.tools.Utils;
 import org.xml.sax.SAXException;
 import org.xml.sax.SAXParseException;
@@ -30 +31 @@
     private static ElemStyles styles = new ElemStyles();
     private static Collection<String> iconDirs;
-    private static File zipIcons;
 
     public static ElemStyles getStyles()
@@ -36 +36 @@
         return styles;
     }
+    
+    public static class IconReference {
 
-    public static ImageIcon getIcon(String name, String styleName)
+        public String iconName;
+        public XmlStyleSource source;
+
+        public IconReference(String iconName, XmlStyleSource source) {
+            this.iconName = iconName;
+            this.source = source;
+        }
+    }
+
+    public static ImageIcon getIcon(IconReference ref)
     {
+        String styleName = ref.source.getPrefName();
         List<String> dirs = new LinkedList<String>();
         for(String fileset : iconDirs)
@@ -54 +66 @@
             }
         }
-        ImageIcon i = ImageProvider.getIfAvailable(dirs, "mappaint."+styleName, null, name, zipIcons);
+        ImageIcon i = ImageProvider.getIfAvailable(dirs, "mappaint."+styleName, null, ref.iconName, ref.source.zipIcons);
         if(i == null)
         {
-            System.out.println("Mappaint style \""+styleName+"\" icon \"" + name + "\" not found.");
+            System.out.println("Mappaint style \""+styleName+"\" icon \"" + ref.iconName + "\" not found.");
             i = ImageProvider.getIfAvailable(dirs, "mappaint."+styleName, null, "misc/no_icon.png");
         }
@@ -86 +98 @@
                 if(zip != null)
                 {
-                    zipIcons = in.getFile();
+                    style.zipIcons = in.getFile();
                     ins = new InputStreamReader(zip);
                 } else {
@@ -110 +122 @@
             styles.add(style);
         }
-        iconDirs = null;
-        zipIcons = null;
     }
 }

trunk/src/org/openstreetmap/josm/gui/mappaint/xml/IconPrototype.java

@@ -2 +2 @@
 package org.openstreetmap.josm.gui.mappaint.xml;
 
-import javax.swing.ImageIcon;
-
 import org.openstreetmap.josm.gui.mappaint.IconElemStyle;
+import org.openstreetmap.josm.gui.mappaint.MapPaintStyles;
+import org.openstreetmap.josm.gui.mappaint.MapPaintStyles.IconReference;
 import org.openstreetmap.josm.gui.mappaint.NodeElemStyle;
 import org.openstreetmap.josm.gui.mappaint.SimpleNodeElemStyle;
@@ -10 +10 @@
 public class IconPrototype extends Prototype {
     
-    public ImageIcon icon;
+    public IconReference icon;
     public boolean annotate;
 
@@ -33 +33 @@
             return SimpleNodeElemStyle.INSTANCE;
         } else {
-            IconElemStyle i = new IconElemStyle(minScale, maxScale, icon);
+            IconElemStyle i = new IconElemStyle(minScale, maxScale, MapPaintStyles.getIcon(icon));
             i.annotate = annotate;
             return i;

trunk/src/org/openstreetmap/josm/gui/mappaint/xml/XmlStyleSource.java

@@ -2 +2 @@
 package org.openstreetmap.josm.gui.mappaint.xml;
 
+import java.io.File;
 import java.util.Collection;
 import java.util.Collections;
@@ -28 +29 @@
 
     public boolean hasError = false;
+    public File zipIcons;
 
     public XmlStyleSource(String url, String name, String shortdescription) {
@@ -200 +202 @@
          }
      }
-
-    /**
-     * the name / identifier that should be used to save custom color values
-     * and similar stuff to the preference file
-     * @return the identifier; never null. Usually the result is "standard"
-     */
-    public String getPrefName() {
-        return name == null ? "standard" : name;
-    }
 }

trunk/src/org/openstreetmap/josm/gui/mappaint/xml/XmlStyleSourceHandler.java

@@ -6 +6 @@
 import java.util.LinkedList;
 
-import javax.swing.ImageIcon;
-
 import org.openstreetmap.josm.Main;
-import org.openstreetmap.josm.gui.mappaint.MapPaintStyles;
+import org.openstreetmap.josm.gui.mappaint.MapPaintStyles.IconReference;
 import org.openstreetmap.josm.tools.ColorHelper;
 import org.xml.sax.Attributes;
@@ -211 +209 @@
                 {
                     if (atts.getQName(count).equals("src")) {
-                        ImageIcon icon = MapPaintStyles.getIcon(atts.getValue(count), style.getPrefName());
+                        IconReference icon = new IconReference(atts.getValue(count), style);
                         hadIcon = (icon != null);
                         rule.icon.icon = icon;

trunk/src/org/openstreetmap/josm/gui/preferences/SourceEntry.java

@@ -96 +96 @@
     }
 
+    /**
+     * the name / identifier that should be used to save custom color values
+     * and similar stuff to the preference file
+     * @return the identifier; never null. Usually the result is "standard"
+     */
+    public String getPrefName() {
+        return name == null ? "standard" : name;
+    }
 }