Changeset 3335 in josm

Timestamp:

Jun 19, 2010 2:21:38 PM (3 years ago)

Author:

stoecker

Message:

#close #4675 - patch by Upliner - error in conflict/undo handling

File:

• trunk/src/org/openstreetmap/josm/command/PurgePrimitivesCommand.java (modified) (7 diffs)

trunk/src/org/openstreetmap/josm/command/PurgePrimitivesCommand.java

@@ -8 +8 @@
 import java.util.Collection;
 import java.util.Collections;
+import java.util.HashMap;
 import java.util.HashSet;
 import java.util.List;
+import java.util.Map;
 import java.util.Set;
+import java.util.Map.Entry;
 import java.util.logging.Logger;
 
@@ -19 +22 @@
 import org.openstreetmap.josm.data.osm.Node;
 import org.openstreetmap.josm.data.osm.OsmPrimitive;
+import org.openstreetmap.josm.data.osm.PrimitiveData;
 import org.openstreetmap.josm.data.osm.Relation;
 import org.openstreetmap.josm.data.osm.Way;
@@ -48 +52 @@
     private Set<OsmPrimitive> purgedPrimitives;
 
-    private Set<OsmPrimitive> origVersionsOfTouchedPrimitives;
+    private Map<OsmPrimitive,PrimitiveData> origVersionsOfTouchedPrimitives;
 
     protected void init(Collection<OsmPrimitive> toPurge) {
         this.toPurge = toPurge;
         this.purgedPrimitives = new HashSet<OsmPrimitive>();
-        this.origVersionsOfTouchedPrimitives = new HashSet<OsmPrimitive>();
+        this.origVersionsOfTouchedPrimitives = new HashMap<OsmPrimitive,PrimitiveData>();
     }
 
@@ -149 +153 @@
             if (parent instanceof Way) {
                 Way w = (Way)parent;
-                if (!origVersionsOfTouchedPrimitives.contains(w)) {
-                    origVersionsOfTouchedPrimitives.add(w);
+                if (!origVersionsOfTouchedPrimitives.containsKey(w)) {
+                    origVersionsOfTouchedPrimitives.put(w,w.save());
                 }
                 w.removeNode((Node)child);
@@ -163 +167 @@
             } else if (parent instanceof Relation) {
                 Relation r = (Relation)parent;
-                if (!origVersionsOfTouchedPrimitives.contains(r)) {
-                    origVersionsOfTouchedPrimitives.add(r);
+                if (!origVersionsOfTouchedPrimitives.containsKey(r)) {
+                    origVersionsOfTouchedPrimitives.put(r,r.save());
                 }
                 System.out.println(tr("Removing reference from relation {0}",r.getId()));
@@ -200 +204 @@
     public void fillModifiedData(Collection<OsmPrimitive> modified, Collection<OsmPrimitive> deleted,
             Collection<OsmPrimitive> added) {
-        modified.addAll(origVersionsOfTouchedPrimitives);
     }
 
@@ -219 +222 @@
             getLayer().data.addPrimitive(purged);
         }
+
+        for (Entry<OsmPrimitive, PrimitiveData> entry: origVersionsOfTouchedPrimitives.entrySet()) {
+            entry.getKey().load(entry.getValue());
+        }
+
         reconstituteConflicts();