Changeset 3287 in josm

Timestamp:

May 30, 2010 5:07:19 PM (3 years ago)

Author:

stoecker

Message:

fix #4706 and fix #5066 - plugin handling

Location:

trunk/src/org/openstreetmap/josm

Files:

• gui/MainApplication.java (modified) (1 diff)
• plugins/PluginHandler.java (modified) (5 diffs)
• plugins/PluginInformation.java (modified) (2 diffs)
• plugins/ReadLocalPluginInformationTask.java (modified) (2 diffs)
• plugins/ReadRemotePluginInformationTask.java (modified) (9 diffs)

trunk/src/org/openstreetmap/josm/gui/MainApplication.java

@@ -195 +195 @@
         if (!pluginsToLoad.isEmpty() && PluginHandler.checkAndConfirmPluginUpdate(splash)) {
             monitor.subTask(tr("Updating plugins..."));
-            PluginHandler.updatePlugins(splash,pluginsToLoad, monitor.createSubTaskMonitor(1, false));
+            pluginsToLoad = PluginHandler.updatePlugins(splash,pluginsToLoad, monitor.createSubTaskMonitor(1, false));
         }
         monitor.worked(1);

trunk/src/org/openstreetmap/josm/plugins/PluginHandler.java

@@ -620 +620 @@
      * @throws IllegalArgumentException thrown if plugins is null
      */
-    public static void updatePlugins(Window parent, Collection<PluginInformation> plugins, ProgressMonitor monitor) throws IllegalArgumentException{
+    public static List<PluginInformation>  updatePlugins(Window parent,
+    List<PluginInformation> plugins, ProgressMonitor monitor)
+    throws IllegalArgumentException{
         CheckParameterUtil.ensureParameterNotNull(plugins, "plugins");
         if (monitor == null) {
@@ -638 +640 @@
             try {
                 future.get();
+                plugins = buildListOfPluginsToLoad(parent,monitor.createSubTaskMonitor(1, false));
             } catch(ExecutionException e) {
                 System.out.println(tr("Warning: failed to download plugin information list"));
@@ -672 +675 @@
                     e.printStackTrace();
                     alertFailedPluginUpdate(parent, pluginsToUpdate);
-                    return;
+                    return plugins;
                 } catch(InterruptedException e) {
                     e.printStackTrace();
                     alertFailedPluginUpdate(parent, pluginsToUpdate);
-                    return;
+                    return plugins;
                 }
                 // notify user if downloading a locally installed plugin failed
@@ -682 +685 @@
                 if (! task2.getFailedPlugins().isEmpty()) {
                     alertFailedPluginUpdate(parent, task2.getFailedPlugins());
-                    return;
+                    return plugins;
                 }
             }
@@ -692 +695 @@
         Main.pref.putInteger("pluginmanager.version", Version.getInstance().getVersion());
         Main.pref.put("pluginmanager.lastupdate", Long.toString(System.currentTimeMillis()));
+        return plugins;
     }
 

trunk/src/org/openstreetmap/josm/plugins/PluginInformation.java

@@ -351 +351 @@
      */
     public boolean isUpdateRequired(String referenceVersion) {
+        if (this.downloadlink == null) return false;
         if (this.version == null && referenceVersion!= null)
             return true;
@@ -366 +367 @@
      */
     public boolean isUpdateRequired() {
+        if (this.downloadlink == null) return false;
         if (this.localversion == null) return true;
         return isUpdateRequired(this.localversion);

trunk/src/org/openstreetmap/josm/plugins/ReadLocalPluginInformationTask.java

@@ -62 +62 @@
         );
         if (!availablePlugins.containsKey(info.getName())) {
+            info.localversion = info.version;
             availablePlugins.put(info.getName(), info);
         } else {
@@ -184 +185 @@
         Collection<String> pluginLocations = PluginInformation.getPluginLocations();
         getProgressMonitor().setTicksCount(pluginLocations.size() + 2);
-        if (canceled)return;
+        if (canceled) return;
         for (String location : pluginLocations) {
             scanLocalPluginRepository(

trunk/src/org/openstreetmap/josm/plugins/ReadRemotePluginInformationTask.java

@@ -7 +7 @@
 import java.io.ByteArrayInputStream;
 import java.io.File;
+import java.io.FilenameFilter;
 import java.io.FileOutputStream;
 import java.io.IOException;
@@ -43 +44 @@
     private boolean canceled;
     private HttpURLConnection connection;
-    private List<PluginInformation> availabePlugins;
+    private List<PluginInformation> availablePlugins;
 
     protected void init(Collection<String> sites){
@@ -50 +51 @@
             this.sites = Collections.emptySet();
         }
-        availabePlugins = new LinkedList<PluginInformation>();
+        availablePlugins = new LinkedList<PluginInformation>();
 
     }
@@ -94 +95 @@
      * @return the file name for the cache file
      */
-    protected String createSiteCacheFileName(String site) {
+    protected File createSiteCacheFile(File pluginDir, String site) {
+        String name;
         try {
             URL url = new URL(site);
@@ -113 +115 @@
             }
             sb.append(".txt");
-            return sb.toString();
+            name = sb.toString();
         } catch(MalformedURLException e) {
-            return "site-unknown.txt";
-        }
+            name = "site-unknown.txt";
+        }
+        return new File(pluginDir, name);
     }
 
@@ -186 +189 @@
                 }
             }
-            File cacheFile = new File(pluginDir, createSiteCacheFileName(site));
+            File cacheFile = createSiteCacheFile(pluginDir, site);
             getProgressMonitor().subTask(tr("Writing plugin list to local cache ''{0}''", cacheFile.toString()));
             writer = new PrintWriter(new OutputStreamWriter(new FileOutputStream(cacheFile), "utf-8"));
@@ -231 +234 @@
             InputStream in = new ByteArrayInputStream(doc.getBytes("UTF-8"));
             List<PluginInformation> pis = new PluginListParser().parse(in);
-            availabePlugins.addAll(filterDeprecatedPlugins(pis));
+            availablePlugins.addAll(filterDeprecatedPlugins(pis));
         } catch(UnsupportedEncodingException e) {
             System.err.println(tr("Failed to parse plugin list document from site ''{0}''. Skipping site. Exception was: {1}", site, e.toString()));
@@ -245 +248 @@
         if (sites == null) return;
         getProgressMonitor().setTicksCount(sites.size() * 3);
+        File pluginDir = Main.pref.getPluginsDirectory();
+        List<File> siteCacheFiles = new LinkedList<File>();
+        for (String location : PluginInformation.getPluginLocations()) {
+            File [] f = new File(location).listFiles(
+                new FilenameFilter() {
+                    public boolean accept(File dir, String name) {
+                        return name.matches("^([0-9]+-)?site.*\\.txt$");
+                    }
+                }
+            );
+            if(f != null && f.length > 0)
+                siteCacheFiles.addAll(Arrays.asList(f));
+        }
+
         for (String site: sites) {
             getProgressMonitor().subTask(tr("Processing plugin list from site ''{0}''", site));
             String list = downloadPluginList(site, getProgressMonitor().createSubTaskMonitor(0, false));
-            if (canceled || list == null) return;
-            getProgressMonitor().worked(1);
-            cachePluginList(site, list);
             if (canceled) return;
-            getProgressMonitor().worked(1);
-            parsePluginListDocument(site, list);
-            if (canceled) return;
-            getProgressMonitor().worked(1);
+            if(list != null)
+            {
+                siteCacheFiles.remove(createSiteCacheFile(pluginDir, site));
+                getProgressMonitor().worked(1);
+                cachePluginList(site, list);
+                if (canceled) return;
+                getProgressMonitor().worked(1);
+                parsePluginListDocument(site, list);
+                if (canceled) return;
+                getProgressMonitor().worked(1);
+                if (canceled) return;
+            }
+        }
+        for (File file: siteCacheFiles) /* remove old stuff or whole update process is broken */
+        {
+            file.delete();
         }
     }
@@ -273 +299 @@
      */
     public List<PluginInformation> getAvailabePlugins() {
-        return availabePlugins;
+        return availablePlugins;
     }
 }