Changeset 3092 in josm

Timestamp:

Mar 7, 2010 2:34:27 PM (3 years ago)

Author:

Gubaer

Message:

fixed #4681: Open Street Bug Plugin Crashed

Location:

trunk/src/org/openstreetmap/josm/actions

Files:

• UpdateModifiedAction.java (modified) (1 diff)
• UpdateSelectionAction.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/actions/UpdateModifiedAction.java

@@ -32 +32 @@
     }
 
+    // FIXME: overrides the behaviour of UpdateSelectionAction. Doesn't update
+    // the enabled state based on the current selection because
+    // it doesn't depend on it.
+    // The action should be enabled/disabled based on whether there is a least
+    // one modified object in the current dataset. Unfortunately, there is no
+    // efficient way to find out here. getDataSet().allModifiedPrimitives() is
+    // too heavy weight because it loops over the whole dataset.
+    // Perhaps this action should  be a DataSetListener? Or it could listen to the
+    // REQUIRES_SAVE_TO_DISK_PROP and REQUIRES_UPLOAD_TO_SERVER_PROP properties
+    // in the OsmLayer?
+    //
     @Override
-    protected void updateEnabledState(Collection<? extends OsmPrimitive> selection) {
-        super.updateEnabledState(getData());
+    protected void updateEnabledState() {
+        setEnabled(getCurrentDataSet() != null);
     }
 
     @Override
-    protected Collection<OsmPrimitive> getData() {
-        return getCurrentDataSet().allModifiedPrimitives();
+    protected void updateEnabledState(Collection<? extends OsmPrimitive> selection) {
     }
 }

trunk/src/org/openstreetmap/josm/actions/UpdateSelectionAction.java

@@ -103 +103 @@
             setEnabled(false);
         } else {
-            updateEnabledState(getData());
+            updateEnabledState(getCurrentDataSet().getSelected());
         }
     }
@@ -118 +118 @@
         if (! isEnabled())
             return;
-        Collection<OsmPrimitive> selection = getData();
+        Collection<OsmPrimitive> selection =getCurrentDataSet().getSelected();
         if (selection.size() == 0) {
             JOptionPane.showMessageDialog(
@@ -130 +130 @@
         updatePrimitives(selection);
     }
-
-    protected Collection<OsmPrimitive> getData() {
-        return getCurrentDataSet().getSelected();
-    }
 }