Changeset 2948 in josm

Timestamp:

Feb 7, 2010 10:58:30 AM (3 years ago)

Author:

jttt

Message:

Multipolygon with multiple outer polygons optimization - test bbox first when looking for outer polygon

File:

• trunk/src/org/openstreetmap/josm/data/osm/visitor/paint/relations/Multipolygon.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/data/osm/visitor/paint/relations/Multipolygon.java

@@ -4 +4 @@
 import java.awt.Point;
 import java.awt.Polygon;
+import java.awt.Rectangle;
 import java.util.ArrayList;
 import java.util.Collection;
@@ -24 +25 @@
         public final boolean selected;
         private Point lastP;
+        private Rectangle bounds;
 
         public PolyData(NavigatableComponent nc, List<Node> nodes, boolean selected) {
@@ -68 +70 @@
         public Polygon get() {
             return poly;
+        }
+
+        public Rectangle getBounds() {
+            if (bounds == null) {
+                bounds = poly.getBounds();
+            }
+            return bounds;
+        }
+
+        @Override
+        public String toString() {
+            return "Points: " + poly.npoints + " Selected: " + selected;
         }
     }
@@ -228 +242 @@
     public PolyData findOuterPolygon(PolyData inner, List<PolyData> outerPolygons) {
         PolyData result = null;
+
+        {// First try to test only bbox, use precise testing only if we don't get unique result
+            Rectangle innerBox = inner.getBounds();
+            PolyData insidePolygon = null;
+            PolyData intersectingPolygon = null;
+            int insideCount = 0;
+            int intersectingCount = 0;
+
+            for (PolyData outer: outerPolygons) {
+                if (outer.getBounds().contains(innerBox)) {
+                    insidePolygon = outer;
+                    insideCount++;
+                } else if (outer.getBounds().intersects(innerBox)) {
+                    intersectingPolygon = outer;
+                    intersectingCount++;
+                }
+            }
+
+            if (insideCount == 1)
+                return insidePolygon;
+            else if (intersectingCount == 1)
+                return intersectingPolygon;
+        }
+
         for (PolyData combined : outerPolygons) {
             Intersection c = combined.contains(inner.poly);
             if(c != Intersection.OUTSIDE)
             {
-                if(result == null || result.contains(combined.poly) != Intersection.OUTSIDE) {
+                if(result == null || result.contains(combined.poly) != Intersection.INSIDE) {
                     result = combined;
                 }