Changeset 2880 in josm

Timestamp:

Jan 23, 2010 10:22:15 AM (3 years ago)

Author:

jttt

Message:

Fixed #4411 Can't upload due to conflicts, but conflict list is empty

File:

• trunk/src/org/openstreetmap/josm/gui/dialogs/ConflictDialog.java (modified) (8 diffs)

trunk/src/org/openstreetmap/josm/gui/dialogs/ConflictDialog.java

@@ -46 +46 @@
 import org.openstreetmap.josm.gui.OsmPrimitivRenderer;
 import org.openstreetmap.josm.gui.SideButton;
-import org.openstreetmap.josm.gui.layer.Layer;
 import org.openstreetmap.josm.gui.layer.OsmDataLayer;
 import org.openstreetmap.josm.tools.ImageProvider;
@@ -56 +55 @@
  *
  */
-public final class ConflictDialog extends ToggleDialog implements MapView.LayerChangeListener, IConflictListener, SelectionChangedListener{
+public final class ConflictDialog extends ToggleDialog implements MapView.EditLayerChangeListener, IConflictListener, SelectionChangedListener{
 
     static public Color getColor() {
@@ -72 +71 @@
     private ResolveAction actResolve;
     private SelectAction actSelect;
-
-    private OsmDataLayer layer = null;
 
     /**
@@ -125 +122 @@
     public void showNotify() {
         DataSet.selListeners.add(this);
-        MapView.addLayerChangeListener(this);
+        MapView.addEditLayerChangeListener(this);
+        refreshView();
     }
 
     @Override
     public void hideNotify() {
-        MapView.removeLayerChangeListener(this);
+        MapView.removeEditLayerChangeListener(this);
         DataSet.selListeners.remove(this);
     }
@@ -164 +162 @@
      */
     public final void refreshView() {
+        OsmDataLayer editLayer =  Main.main.getEditLayer();
+        conflicts = editLayer == null?new ConflictCollection():editLayer.getConflicts();
         model.fireContentChanged();
     }
@@ -210 +210 @@
     }
 
+    public void editLayerChanged(OsmDataLayer oldLayer, OsmDataLayer newLayer) {
+        if (oldLayer != null) {
+            oldLayer.getConflicts().removeConflictListener(this);
+        }
+        if (newLayer != null) {
+            newLayer.getConflicts().addConflictListener(this);
+        }
+        refreshView();
+    }
+
+
     /**
      * replies the conflict collection currently held by this dialog; may be null
@@ -217 +228 @@
     public ConflictCollection getConflicts() {
         return conflicts;
-    }
-
-    /**
-     * invoked if the active {@see Layer} changes
-     */
-    public void activeLayerChange(Layer oldLayer, Layer newLayer) {
-        if (oldLayer instanceof OsmDataLayer) {
-            this.layer = (OsmDataLayer)oldLayer;
-            this.layer.getConflicts().removeConflictListener(this);
-        }
-        this.layer = null;
-        if (newLayer instanceof OsmDataLayer) {
-            this.layer = (OsmDataLayer)newLayer;
-            layer.getConflicts().addConflictListener(this);
-            this.conflicts = layer.getConflicts();
-        }
-        refreshView();
-    }
-
-    public void layerAdded(Layer newLayer) {
-        // ignore
-    }
-
-    public void layerRemoved(Layer oldLayer) {
-        if (this.layer == oldLayer) {
-            this.layer = null;
-            refreshView();
-        }
     }
 
@@ -376 +359 @@
         }
     }
+
 }