Changeset 2652 in josm

Timestamp:

Dec 18, 2009 8:40:15 AM (3 years ago)

Author:

jttt

Message:

Added listener for edit layer change (not just active layer)

Location:

trunk/src/org/openstreetmap/josm

Files:

• data/osm/event/DataChangedEvent.java (modified) (2 diffs)
• data/osm/event/DatasetEventManager.java (modified) (4 diffs)
• gui/MapView.java (modified) (16 diffs)
• gui/dialogs/changeset/ChangesetsInActiveDataLayerListModel.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/data/osm/event/DataChangedEvent.java

@@ -2 +2 @@
 package org.openstreetmap.josm.data.osm.event;
 
+import java.util.Collections;
 import java.util.List;
 
@@ -21 +22 @@
     @Override
     public List<OsmPrimitive> getPrimitives() {
-        return dataSet.allPrimitives();
+        if (dataSet == null)
+            return Collections.emptyList();
+        else
+            return dataSet.allPrimitives();
     }
 

trunk/src/org/openstreetmap/josm/data/osm/event/DatasetEventManager.java

@@ -9 +9 @@
 import javax.swing.SwingUtilities;
 
-import org.openstreetmap.josm.Main;
 import org.openstreetmap.josm.data.osm.event.DataSetListenerAdapter.Listener;
 import org.openstreetmap.josm.gui.MapView;
-import org.openstreetmap.josm.gui.MapView.LayerChangeListener;
-import org.openstreetmap.josm.gui.layer.Layer;
 import org.openstreetmap.josm.gui.layer.OsmDataLayer;
 
@@ -26 +23 @@
  *
  */
-public class DatasetEventManager implements LayerChangeListener, Listener {
+public class DatasetEventManager implements MapView.EditLayerChangeListener, Listener {
 
     private static final DatasetEventManager instance = new DatasetEventManager();
@@ -40 +37 @@
 
     public DatasetEventManager() {
-        MapView.addLayerChangeListener(this);
+        MapView.addEditLayerChangeListener(this);
     }
 
@@ -62 +59 @@
     }
 
-    /* --------------------------------------------------------------------------- */
-    /* interface LayerChangeListener                                               */
-    /* --------------------------------------------------------------------------- */
-    public void activeLayerChange(Layer a, Layer b) {
-        if (a != null && a instanceof OsmDataLayer) {
-            ((OsmDataLayer)a).data.removeDataSetListener(myListener);
+    public void editLayerChanged(OsmDataLayer oldLayer, OsmDataLayer newLayer) {
+        if (oldLayer != null) {
+            oldLayer.data.removeDataSetListener(myListener);
         }
-        if (b != null && b instanceof OsmDataLayer) {
-            ((OsmDataLayer)b).data.addDataSetListener(myListener);
-        }
-        if (Main.main.getEditLayer() != null) {
-            processDatasetEvent(new DataChangedEvent(Main.main.getEditLayer().data));
+
+        if (newLayer != null) {
+            newLayer.data.addDataSetListener(myListener);
+            processDatasetEvent(new DataChangedEvent(newLayer.data));
+        } else {
+            processDatasetEvent(new DataChangedEvent(null));
         }
     }
-    public void layerRemoved(Layer a) {/* irrelevant in this context */}
-    public void layerAdded(Layer a) {/* irrelevant in this context */}
 
     public void processDatasetEvent(AbstractDatasetChangedEvent event) {

trunk/src/org/openstreetmap/josm/gui/MapView.java

@@ -76 +76 @@
     }
 
+    public interface EditLayerChangeListener {
+        void editLayerChanged(OsmDataLayer oldLayer, OsmDataLayer newLayer);
+    }
+
     /**
      * the layer listeners
      */
     private static final Collection<MapView.LayerChangeListener> layerChangeListeners = new CopyOnWriteArrayList<MapView.LayerChangeListener>();
+    private static final Collection<EditLayerChangeListener> editLayerChangeListeners = new CopyOnWriteArrayList<EditLayerChangeListener>();
 
     /**
@@ -92 +97 @@
     }
 
+    public static void removeEditLayerChangeListener(EditLayerChangeListener listener) {
+        if (listener != null && editLayerChangeListeners.contains(listener)) {
+            editLayerChangeListeners.remove(listener);
+        }
+    }
+
+
+
     /**
      * Adds a layer change listener
@@ -103 +116 @@
     }
 
+    public static void addEditLayerChangeListener(EditLayerChangeListener listener) {
+        if (listener != null && ! layerChangeListeners.contains(listener)) {
+            editLayerChangeListeners.add(listener);
+        }
+    }
+
     protected static void fireActiveLayerChanged(Layer oldLayer, Layer newLayer) {
         for (LayerChangeListener l : layerChangeListeners) {
@@ -121 +140 @@
     }
 
+    protected static void fireEditLayerChanged(OsmDataLayer oldLayer, OsmDataLayer newLayer) {
+        for (EditLayerChangeListener l : editLayerChangeListeners) {
+            l.editLayerChanged(oldLayer, newLayer);
+        }
+    }
+
     /**
      * A list of all layers currently loaded.
@@ -134 +159 @@
      */
     private Layer activeLayer;
+
+    private OsmDataLayer editLayer;
 
     /**
@@ -255 +282 @@
     @Override
     protected DataSet getCurrentDataSet() {
-        if(activeLayer != null && activeLayer instanceof OsmDataLayer)
-            return ((OsmDataLayer)activeLayer).data;
-        return null;
+        if (editLayer != null)
+            return editLayer.data;
+        else
+            return null;
     }
 
@@ -266 +294 @@
      */
     public boolean isActiveLayerDrawable() {
-        return activeLayer != null && activeLayer instanceof OsmDataLayer;
+        return editLayer != null;
     }
 
@@ -275 +303 @@
      */
     public boolean isActiveLayerVisible() {
-        return isActiveLayerDrawable() && activeLayer.isVisible();
+        return isActiveLayerDrawable() && editLayer.isVisible();
     }
 
@@ -290 +318 @@
      * @return the next active data layer
      */
-    protected Layer determineNextActiveLayer() {
-        if (layers.isEmpty()) return null;
-        // if possible, activate the first data layer
-        //
-        List<OsmDataLayer> dataLayers = getLayersOfType(OsmDataLayer.class);
-        if (!dataLayers.isEmpty())
-            return dataLayers.get(0);
-
-        // else the first layer of any type
-        //
-        return layers.get(0);
+    protected Layer determineNextActiveLayer(Layer ignoredLayer) {
+        // First look for data layer
+        for (Layer layer:layers) {
+            if (layer instanceof OsmDataLayer && layer != ignoredLayer)
+                return layer;
+        }
+
+        // Then any layer
+        for (Layer layer:layers) {
+            if (layer != ignoredLayer)
+                return layer;
+        }
+
+        // and then give up
+        return null;
+
     }
 
@@ -308 +341 @@
      */
     public void removeLayer(Layer layer) {
-        boolean deletedLayerWasActiveLayer = false;
-
         if (layer == activeLayer) {
-            activeLayer = null;
-            deletedLayerWasActiveLayer = true;
-            fireActiveLayerChanged(layer, null);
+            setActiveLayer(determineNextActiveLayer(activeLayer));
         }
         if (layers.remove(layer)) {
@@ -321 +350 @@
         layer.destroy();
         AudioPlayer.reset();
-        if (deletedLayerWasActiveLayer) {
-            Layer l = determineNextActiveLayer();
-            if (l != null) {
-                activeLayer = l;
-                fireActiveLayerChanged(null, l);
-            }
-        }
         repaint();
     }
@@ -362 +384 @@
             layers.add(pos, layer);
         }
+        setEditLayer();
         AudioPlayer.reset();
         repaint();
@@ -561 +584 @@
     }
 
+    private void setEditLayer() {
+        OsmDataLayer newEditLayer = null;
+        OsmDataLayer oldEditLayer = editLayer;
+
+        // Find new edit layer
+        if (activeLayer != editLayer) {
+            if (activeLayer instanceof OsmDataLayer) {
+                newEditLayer = (OsmDataLayer) activeLayer;
+            } else {
+                for (Layer layer:layers) {
+                    if (layer instanceof OsmDataLayer) {
+                        newEditLayer = (OsmDataLayer) layer;
+                        break;
+                    }
+                }
+            }
+        }
+
+        // Set new edit layer
+        if (newEditLayer != editLayer) {
+            if (newEditLayer == null) {
+                getCurrentDataSet().setSelected();
+            }
+
+            editLayer = newEditLayer;
+            fireEditLayerChanged(oldEditLayer, newEditLayer);
+            refreshTitle();
+        }
+
+    }
+
     /**
      * Sets the active layer to <code>layer</code>. If <code>layer</code> is an instance
@@ -571 +625 @@
         if (!layers.contains(layer))
             throw new IllegalArgumentException(tr("Layer ''{0}'' must be in list of layers", layer.toString()));
-        if (! (layer instanceof OsmDataLayer)) {
-            if (getCurrentDataSet() != null) {
-                getCurrentDataSet().setSelected();
-            }
-        }
+
+        if (layer == activeLayer)
+            return;
+
         Layer old = activeLayer;
         activeLayer = layer;
-        if (old != layer) {
-            fireActiveLayerChanged(old, layer);
-        }
-        if (layer instanceof OsmDataLayer) {
-            refreshTitle((OsmDataLayer)layer);
-        }
+        fireActiveLayerChanged(old, layer);
+
+        setEditLayer();
 
         /* This only makes the buttons look disabled. Disabling the actions as well requires
@@ -612 +662 @@
      */
     public OsmDataLayer getEditLayer() {
-        if (activeLayer instanceof OsmDataLayer)
-            return (OsmDataLayer)activeLayer;
-
-        // the first OsmDataLayer is the edit layer
-        //
-        for (Layer layer : layers) {
-            if (layer instanceof OsmDataLayer)
-                return (OsmDataLayer)layer;
-        }
-        return null;
+        return editLayer;
     }
 
@@ -678 +719 @@
             OsmDataLayer layer = (OsmDataLayer)evt.getSource();
             if (layer == getEditLayer()) {
-                refreshTitle(layer);
-            }
-        }
-    }
-
-    protected void refreshTitle(OsmDataLayer layer) {
-        boolean dirty = layer.requiresSaveToFile() || layer.requiresUploadToServer();
+                refreshTitle();
+            }
+        }
+    }
+
+    protected void refreshTitle() {
+        boolean dirty = editLayer != null && (editLayer.requiresSaveToFile() || editLayer.requiresUploadToServer());
         if (dirty) {
             JOptionPane.getFrameForComponent(Main.parent).setTitle("* " + tr("Java OpenStreetMap Editor"));

trunk/src/org/openstreetmap/josm/gui/dialogs/changeset/ChangesetsInActiveDataLayerListModel.java

@@ -6 +6 @@
 import org.openstreetmap.josm.Main;
 import org.openstreetmap.josm.gui.MapView;
-import org.openstreetmap.josm.gui.MapView.LayerChangeListener;
 import org.openstreetmap.josm.gui.layer.DataChangeListener;
 import org.openstreetmap.josm.gui.layer.Layer;