Changeset 2517 in josm

Timestamp:

Nov 26, 2009 8:43:56 PM (3 years ago)

Author:

jttt

Message:

Fixed #3920 Selection history is broken

File:

• trunk/src/org/openstreetmap/josm/data/osm/DataSet.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/data/osm/DataSet.java

@@ -248 +248 @@
      * dataset. (However, the selection does only change in the active layer)
      */
-    public static Collection<SelectionChangedListener> selListeners = 
+    public static Collection<SelectionChangedListener> selListeners =
         Collections.synchronizedList(new LinkedList<SelectionChangedListener>());
-
-    /**
-     * notifies all registered selection change listeners about the current selection of
-     * primitives
-     *
-     * @param sel the current selection
-     */
-    private static void notifySelectionChangeListeners(Collection<? extends OsmPrimitive> sel) {
-        synchronized (selListeners) {
-            for (SelectionChangedListener l : selListeners) {
-                l.selectionChanged(sel);
-            }
-        }
-    }
 
     /**
@@ -271 +257 @@
      */
     public void fireSelectionChanged(){
-        notifySelectionChangeListeners(selectedPrimitives);
+        synchronized (selListeners) {
+            List<? extends OsmPrimitive> currentSelection = Collections.unmodifiableList(new ArrayList<OsmPrimitive>(selectedPrimitives));
+            for (SelectionChangedListener l : selListeners) {
+                l.selectionChanged(currentSelection);
+            }
+        }
     }