Changeset 2404 in josm

Timestamp:

Nov 7, 2009 8:01:37 PM (4 years ago)

Author:

jttt

Message:

Use Dataset.getPrimitiveById() instead of custom looking for primitive in Way.load() and Relation.load()

Location:

trunk/src/org/openstreetmap/josm/data/osm

Files:

• PrimitiveData.java (modified) (1 diff)
• Relation.java (modified) (2 diffs)
• RelationMemberData.java (modified) (2 diffs)
• Way.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/data/osm/PrimitiveData.java

@@ -40 +40 @@
     private final Map<String, String> keys = new HashMap<String, String>();
     private boolean modified;
-    private boolean visible;
+    private boolean visible = true;
     private boolean deleted;
     private long id;

trunk/src/org/openstreetmap/josm/data/osm/Relation.java

@@ -3 +3 @@
 import java.util.ArrayList;
 import java.util.Collection;
-import java.util.HashMap;
 import java.util.HashSet;
 import java.util.List;
-import java.util.Map;
 import java.util.Set;
 
@@ -160 +158 @@
         RelationData relationData = (RelationData) data;
 
-        // TODO Make this faster
-
-        Node nodeMarker = new Node();
-        Way wayMarker = new Way();
-        Relation relationMarker = new Relation();
-        Map<Long, Node> nodes = new HashMap<Long, Node>();
-        Map<Long, Way> ways = new HashMap<Long, Way>();
-        Map<Long, Relation> relations = new HashMap<Long, Relation>();
-
-        for (RelationMemberData member : relationData.getMembers()) {
-            switch (member.getMemberType()) {
-            case NODE:
-                nodes.put(member.getMemberId(), nodeMarker);
-                break;
-            case WAY:
-                ways.put(member.getMemberId(), wayMarker);
-                break;
-            case RELATION:
-                relations.put(member.getMemberId(), relationMarker);
-                break;
-            }
-        }
-
-        for (Node node : dataSet.getNodes()) {
-            if (nodes.get(node.getUniqueId()) == nodeMarker) {
-                nodes.put(node.getUniqueId(), node);
-            }
-        }
-        for (Way way : dataSet.getWays()) {
-            if (ways.get(way.getUniqueId()) == wayMarker) {
-                ways.put(way.getUniqueId(), way);
-            }
-        }
-        for (Relation relation : dataSet.getRelations()) {
-            if (relations.get(relation.getUniqueId()) == relationMarker) {
-                relations.put(relation.getUniqueId(), relation);
-            }
-        }
-
         List<RelationMember> newMembers = new ArrayList<RelationMember>();
         for (RelationMemberData member : relationData.getMembers()) {
-            OsmPrimitive foundMember = null;
-            switch (member.getMemberType()) {
-            case NODE:
-                foundMember = nodes.get(member.getMemberId());
-                if (foundMember == nodeMarker)
-                    throw new AssertionError("Data consistency problem - relation with missing member detected");
-                break;
-            case WAY:
-                foundMember = ways.get(member.getMemberId());
-                if (foundMember == wayMarker)
-                    throw new AssertionError("Data consistency problem - relation with missing member detected");
-                break;
-            case RELATION:
-                foundMember = relations.get(member.getMemberId());
-                if (foundMember == relationMarker)
-                    throw new AssertionError("Data consistency problem - relation with missing member detected");
-                break;
-            }
-            newMembers.add(new RelationMember(member.getRole(), foundMember));
+            OsmPrimitive primitive = dataSet.getPrimitiveById(member);
+            if (primitive == null)
+                throw new AssertionError("Data consistency problem - relation with missing member detected");
+            newMembers.add(new RelationMember(member.getRole(), primitive));
         }
         setMembers(newMembers);

trunk/src/org/openstreetmap/josm/data/osm/RelationMemberData.java

@@ -9 +9 @@
 
     public RelationMemberData(String role, OsmPrimitiveType type, long id) {
-        this.role = role;
+        this.role = role == null?"":role;
         this.memberType = type;
         this.memberId = id;
     }
 
-    public RelationMemberData(String role, OsmPrimitive primitive) {
-        this(role, OsmPrimitiveType.from(primitive), primitive.getUniqueId());
+    public RelationMemberData(String role, PrimitiveId primitive) {
+        this(role, primitive.getType(), primitive.getUniqueId());
     }
 
@@ -26 +26 @@
     public OsmPrimitiveType getMemberType() {
         return memberType;
+    }
+
+    public boolean hasRole() {
+        return !"".equals(role);
     }
 

trunk/src/org/openstreetmap/josm/data/osm/Way.java

@@ -7 +7 @@
 import java.util.Arrays;
 import java.util.Collection;
-import java.util.HashMap;
 import java.util.List;
-import java.util.Map;
 
 import org.openstreetmap.josm.data.osm.visitor.Visitor;
@@ -179 +177 @@
         WayData wayData = (WayData) data;
 
-        // TODO We should have some lookup by id mechanism in future to speed this up
-        Node marker = new Node(0);
-        Map<Long, Node> foundNodes = new HashMap<Long, Node>();
-        for (Long nodeId : wayData.getNodes()) {
-            foundNodes.put(nodeId, marker);
-        }
-        for (Node node : dataSet.getNodes()) {
-            if (foundNodes.get(node.getUniqueId()) == marker) {
-                foundNodes.put(node.getUniqueId(), node);
-            }
-        }
-
         List<Node> newNodes = new ArrayList<Node>(wayData.getNodes().size());
         for (Long nodeId : wayData.getNodes()) {
-            Node node = foundNodes.get(nodeId);
-            if (node != marker) {
-                newNodes.add(foundNodes.get(nodeId));
+            Node node = (Node)dataSet.getPrimitiveById(nodeId, OsmPrimitiveType.NODE);
+            if (node != null) {
+                newNodes.add(node);
             } else
                 throw new AssertionError("Data consistency problem - way with missing node detected");