Changeset 1844 in josm

Timestamp:

Jul 25, 2009 6:44:11 PM (4 years ago)

Author:

Gubaer

Message:

fixed #3018 : Make sure tools menu entries (and actions) are deactivated when no layer
Didn't apply the patch. Fixed it with slight modification in DrawAction. Applied patch for ReverseAction, though.

Location:

trunk/src/org/openstreetmap/josm/actions

Files:

• PasteAction.java (modified) (1 diff)
• ReverseWayAction.java (modified) (2 diffs)
• mapmode/DrawAction.java (modified) (4 diffs)
• mapmode/SelectAction.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/actions/PasteAction.java

@@ -120 +120 @@
     @Override
     protected void updateEnabledState() {
-        if (getCurrentDataSet() == null) {
+        if (getCurrentDataSet() == null || Main.pasteBuffer == null) {
             setEnabled(false);
             return;
-        }
-        if (Main.pasteBuffer == null) {
-            setEnabled(false);
         }
         setEnabled(

trunk/src/org/openstreetmap/josm/actions/ReverseWayAction.java

@@ -18 +18 @@
 import org.openstreetmap.josm.corrector.ReverseWayTagCorrector;
 import org.openstreetmap.josm.corrector.UserCancelException;
-import org.openstreetmap.josm.data.SelectionChangedListener;
 import org.openstreetmap.josm.data.osm.DataSet;
 import org.openstreetmap.josm.data.osm.OsmPrimitive;
 import org.openstreetmap.josm.data.osm.Way;
-import org.openstreetmap.josm.gui.layer.Layer;
-import org.openstreetmap.josm.gui.layer.Layer.LayerChangeListener;
 import org.openstreetmap.josm.tools.Shortcut;
 
-public final class ReverseWayAction extends JosmAction implements SelectionChangedListener, LayerChangeListener {
+public final class ReverseWayAction extends JosmAction {
 
     public ReverseWayAction() {
         super(tr("Reverse Ways"), "wayflip", tr("Reverse the direction of all selected ways."),
                 Shortcut.registerShortcut("tools:reverse", tr("Tool: {0}", tr("Reverse Ways")), KeyEvent.VK_R, Shortcut.GROUP_EDIT), true);
-        DataSet.selListeners.add(this);
-        Layer.listeners.add(this);
-        refreshEnabled();
     }
 
@@ -93 +87 @@
     }
 
-    protected void refreshEnabled() {
+    @Override
+    protected void updateEnabledState() {
         setEnabled(getNumWaysInSelection() > 0);
     }
-
-    public void activeLayerChange(Layer oldLayer, Layer newLayer) {
-        refreshEnabled();
-    }
-
-    public void layerAdded(Layer newLayer) {
-        refreshEnabled();
-
-    }
-
-    public void layerRemoved(Layer oldLayer) {
-        refreshEnabled();
-    }
-
-    public void selectionChanged(Collection<? extends OsmPrimitive> newSelection) {
-        refreshEnabled();
-    }
 }

trunk/src/org/openstreetmap/josm/actions/mapmode/DrawAction.java

@@ -31 +31 @@
 import java.util.Map;
 import java.util.Set;
+import java.util.logging.Logger;
 
 import javax.swing.JComponent;
@@ -62 +63 @@
  */
 public class DrawAction extends MapMode implements MapViewPaintable, SelectionChangedListener, AWTEventListener {
+    static private final Logger logger = Logger.getLogger(DrawAction.class.getName());
+
     final private Cursor cursorCrosshair;
     final private Cursor cursorJoinNode;
@@ -239 +242 @@
         } catch (SecurityException ex) {
         }
+
+        // when exiting we let everybody know about the currently selected
+        // primitives
+        //
+        DataSet.fireSelectionChanged(getCurrentDataSet().getSelected());
     }
 
@@ -274 +282 @@
      */
     private void finishDrawing() {
+        // let everybody else know about the current selection
+        //
+        DataSet.fireSelectionChanged(getCurrentDataSet().getSelected());
         lastUsedNode = null;
         wayIsFinished = true;

trunk/src/org/openstreetmap/josm/actions/mapmode/SelectAction.java

@@ -18 +18 @@
 import java.util.List;
 import java.util.TreeSet;
+import java.util.logging.Logger;
 
 import javax.swing.JOptionPane;
@@ -59 +60 @@
  */
 public class SelectAction extends MapMode implements SelectionEnded {
+    static private final Logger logger = Logger.getLogger(SelectAction.class.getName());
 
     /**