Changeset 1815 in josm

Timestamp:

Jul 19, 2009 9:35:34 PM (4 years ago)

Author:

Gubaer

Message:

fixed NPEs

Location:

trunk/src/org/openstreetmap/josm/gui/dialogs

Files:

• HistoryDialog.java (modified) (2 diffs)
• PropertiesDialog.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/dialogs/HistoryDialog.java

@@ -288 +288 @@
         public void refresh() {
             data.clear();
+            if (Main.main.getCurrentDataSet() == null)
+                return;
             for (OsmPrimitive primitive: Main.main.getCurrentDataSet().getSelected()) {
                 if (primitive.id == 0) {
@@ -454 +456 @@
 
         public void selectionChanged(Collection<? extends OsmPrimitive> newSelection) {
-            setEnabled(Main.main.getCurrentDataSet().getSelected().size() > 0);
+            if (Main.main.getCurrentDataSet() == null) {
+                setEnabled(false);
+            } else {
+                setEnabled(Main.main.getCurrentDataSet().getSelected().size() > 0);
+            }
 
         }

trunk/src/org/openstreetmap/josm/gui/dialogs/PropertiesDialog.java

@@ -792 +792 @@
 
         Map<Relation, Collection<RelationMember>> roles = new HashMap<Relation, Collection<RelationMember>>();
-        for (Relation r : Main.main.getCurrentDataSet().relations) {
-            if (!r.deleted && !r.incomplete) {
-                for (RelationMember m : r.members) {
-                    if (newSelection.contains(m.member)) {
-                        Collection<RelationMember> value = roles.get(r);
-                        if (value == null) {
-                            value = new HashSet<RelationMember>();
-                            roles.put(r, value);
+        if (Main.main.getCurrentDataSet() != null) {
+            for (Relation r : Main.main.getCurrentDataSet().relations) {
+                if (!r.deleted && !r.incomplete) {
+                    for (RelationMember m : r.members) {
+                        if (newSelection.contains(m.member)) {
+                            Collection<RelationMember> value = roles.get(r);
+                            if (value == null) {
+                                value = new HashSet<RelationMember>();
+                                roles.put(r, value);
+                            }
+                            value.add(m);
                         }
-                        value.add(m);
-                    }
-                }
-            }
-        }
-
+                    }
+                }
+            }
+        }
         for (Entry<Relation, Collection<RelationMember>> e : roles.entrySet()) {
             membershipData.addRow(new Object[]{e.getKey(), e.getValue()});