Changeset 12990 in josm

Timestamp:

2017-10-12T22:17:38+02:00 (7 years ago)

Author:

bastiK

Message:

see #15410 - update tests + minor fixes (2)

Location:

trunk

Files:

• src/org/openstreetmap/josm/data/Preferences.java (modified) (3 diffs)
• src/org/openstreetmap/josm/gui/preferences/display/ColorPreference.java (modified) (1 diff)
• test/unit/org/openstreetmap/josm/gui/layer/LayerTest.java (modified) (1 diff)
• test/unit/org/openstreetmap/josm/gui/mappaint/mapcss/MapCSSParserTest.groovy (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/data/Preferences.java

@@ -1006 +1006 @@
      * @param def default value
      * @return a Color object for the configured colour, or the default value if none configured.
-     * @deprecated Use a {@link ColorProperty} instead.
+     * @deprecated Use a {@link NamedColorProperty} instead.
      */
     @Deprecated
@@ -1045 +1045 @@
      * @param def default value
      * @return a Color object for the configured colour, or the default value if none configured.
-     * @deprecated Use a {@link ColorProperty} instead.
-     * You can replace this by: <code>new ColorProperty(colName, def).getChildColor(specName)</code>
+     * @deprecated Use a {@link NamedColorProperty} instead.
+     * You can replace this by: <code>new NamedColorProperty(colName, def).getChildColor(specName)</code>
      */
     @Deprecated
@@ -1095 +1095 @@
      * @param val The color
      * @return true if the setting was modified
-     * @see ColorProperty#put(Color)
+     * @see NamedColorProperty#put(Color)
      * @deprecated (since 12987) no longer supported (see {@link NamedColorProperty})
      */

trunk/src/org/openstreetmap/josm/gui/preferences/display/ColorPreference.java

@@ -141 +141 @@
          */
         public boolean isDefault() {
-            return info.getValue() == null || Objects.equals(info.getValue(),  info.getDefaultValue());
+            return info.getValue() == null || Objects.equals(info.getValue(), info.getDefaultValue());
         }
 

trunk/test/unit/org/openstreetmap/josm/gui/layer/LayerTest.java

@@ -59 +59 @@
         assertEquals(Color.BLACK, color.get());
         assertEquals(Color.BLACK, color.getDefaultValue());
-        assertEquals("color.layer.test.layer", color.getKey());
+        assertEquals("clr.layer.Test Layer.x", color.getKey());
     }
 

trunk/test/unit/org/openstreetmap/josm/gui/mappaint/mapcss/MapCSSParserTest.groovy

@@ -6 +6 @@
 import org.junit.Test
 import org.openstreetmap.josm.JOSMFixture
-import org.openstreetmap.josm.Main
 import org.openstreetmap.josm.data.coor.LatLon
 import org.openstreetmap.josm.data.osm.DataSet
@@ -308 +307 @@
         def expected = new Color(0x88DD22)
         assert e.getCascade(Environment.DEFAULT_LAYER).get("color") == expected
-        assert Main.pref.getDefaultColor("mappaint.mapcss.testcolour1") == expected
     }
 
@@ -317 +315 @@
         def expected = new Color(0x12, 0x34, 0x56, 0x78)
         assert e.getCascade(Environment.DEFAULT_LAYER).get("color") == expected
-        assert Main.pref.getDefaultColor("mappaint.mapcss.testcolour2") == expected
     }