Changeset 12940 in josm

Timestamp:

2017-10-08T03:29:55+02:00 (7 years ago)

Author:

Don-vip

Message:

fix #14163 - fix EDT violation when displaying conflict dialog from validator quick fix

File:

• trunk/src/org/openstreetmap/josm/gui/conflict/tags/CombinePrimitiveResolverDialog.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/conflict/tags/CombinePrimitiveResolverDialog.java

@@ -519 +519 @@
             }
         } else if (!GraphicsEnvironment.isHeadless()) {
-            // Build conflict resolution dialog
-            final CombinePrimitiveResolverDialog dialog = new CombinePrimitiveResolverDialog(Main.parent, tagModel, relModel);
-
-            // Ensure a proper title is displayed instead of a previous target (fix #7925)
-            if (targetPrimitives.size() == 1) {
-                dialog.setTargetPrimitive(targetPrimitives.iterator().next(), false);
-            } else {
-                dialog.setTargetPrimitive(null, false);
-            }
-
-            // Resolve tag conflicts
-            GuiHelper.runInEDTAndWait(() -> {
-                tagModel.fireTableDataChanged();
-                relModel.fireTableDataChanged();
-                dialog.updateTitle();
+            UserCancelException canceled = GuiHelper.runInEDTAndWaitAndReturn(() -> {
+                // Build conflict resolution dialog
+                final CombinePrimitiveResolverDialog dialog = new CombinePrimitiveResolverDialog(Main.parent, tagModel, relModel);
+
+                // Ensure a proper title is displayed instead of a previous target (fix #7925)
+                if (targetPrimitives.size() == 1) {
+                    dialog.setTargetPrimitive(targetPrimitives.iterator().next(), false);
+                } else {
+                    dialog.setTargetPrimitive(null, false);
+                }
+
+                // Resolve tag conflicts
+                GuiHelper.runInEDTAndWait(() -> {
+                    tagModel.fireTableDataChanged();
+                    relModel.fireTableDataChanged();
+                    dialog.updateTitle();
+                });
+                dialog.setVisible(true);
+                if (!dialog.isApplied()) {
+                    return new UserCancelException();
+                }
+
+                // Build commands
+                for (OsmPrimitive i : targetPrimitives) {
+                    dialog.setTargetPrimitive(i, false);
+                    cmds.addAll(dialog.buildResolutionCommands());
+                }
+                return null;
             });
-            dialog.setVisible(true);
-            if (!dialog.isApplied()) {
-                throw new UserCancelException();
-            }
-
-            // Build commands
-            for (OsmPrimitive i : targetPrimitives) {
-                dialog.setTargetPrimitive(i, false);
-                cmds.addAll(dialog.buildResolutionCommands());
+            if (canceled != null) {
+                throw canceled;
             }
         }