Changeset 12691 in josm

Timestamp:

2017-08-28T19:26:47+02:00 (7 years ago)

Author:

Don-vip

Message:

see #15182 - introduce Main.getEditDataSet to avoid unneeded GUI dependence in validator tests and tagging presets

Location:

trunk/src/org/openstreetmap/josm

Files:

• Main.java (modified) (1 diff)
• data/UndoRedoHandler.java (modified) (3 diffs)
• data/osm/FilterModel.java (modified) (3 diffs)
• data/validation/tests/UnconnectedWays.java (modified) (2 diffs)
• data/validation/tests/UntaggedWay.java (modified) (3 diffs)
• gui/MainApplication.java (modified) (1 diff)
• gui/tagging/presets/TaggingPreset.java (modified) (2 diffs)
• gui/tagging/presets/TaggingPresetSearchPrimitiveDialog.java (modified) (1 diff)
• gui/tagging/presets/TaggingPresetSelector.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/Main.java

@@ -632 +632 @@
 
     /**
+     * Gets the data set of the active edit layer.
+     * @return That data set, <code>null</code> if there is no edit layer.
+     * @since 12691
+     */
+    public DataSet getEditDataSet() {
+        return null;
+    }
+
+    /**
      * Registers a {@code JosmAction} and its shortcut.
      * @param action action defining its own shortcut

trunk/src/org/openstreetmap/josm/data/UndoRedoHandler.java

@@ -86 +86 @@
      */
     public synchronized void add(final Command c) {
-        DataSet ds = Optional.ofNullable(c.getAffectedDataSet()).orElseGet(() -> MainApplication.getLayerManager().getEditDataSet());
+        DataSet ds = Optional.ofNullable(c.getAffectedDataSet()).orElseGet(() -> Main.main.getEditDataSet());
         Collection<? extends OsmPrimitive> oldSelection = null;
         if (ds != null) {
@@ -115 +115 @@
         if (commands.isEmpty())
             return;
-        DataSet ds = MainApplication.getLayerManager().getEditDataSet();
+        DataSet ds = Main.main.getEditDataSet();
         Collection<? extends OsmPrimitive> oldSelection = null;
         if (ds != null) {
@@ -156 +156 @@
         if (redoCommands.isEmpty())
             return;
-        DataSet ds = MainApplication.getLayerManager().getEditDataSet();
+        DataSet ds = Main.main.getEditDataSet();
         Collection<? extends OsmPrimitive> oldSelection = ds.getSelected();
         for (int i = 0; i < num; ++i) {

trunk/src/org/openstreetmap/josm/data/osm/FilterModel.java

@@ -96 +96 @@
      */
     public void executeFilters() {
-        DataSet ds = MainApplication.getLayerManager().getEditDataSet();
+        DataSet ds = Main.main.getEditDataSet();
         changed = false;
         if (ds == null) {
@@ -145 +145 @@
      */
     public void executeFilters(Collection<? extends OsmPrimitive> primitives) {
-        DataSet ds = MainApplication.getLayerManager().getEditDataSet();
+        DataSet ds = Main.main.getEditDataSet();
         if (ds == null)
             return;
@@ -207 +207 @@
      */
     public void clearFilterFlags() {
-        DataSet ds = MainApplication.getLayerManager().getEditDataSet();
+        DataSet ds = Main.main.getEditDataSet();
         if (ds != null) {
             FilterWorker.clearFilterFlags(ds.allPrimitives());

trunk/src/org/openstreetmap/josm/data/validation/tests/UnconnectedWays.java

@@ -32 +32 @@
 import org.openstreetmap.josm.data.validation.Test;
 import org.openstreetmap.josm.data.validation.TestError;
-import org.openstreetmap.josm.gui.MainApplication;
 import org.openstreetmap.josm.gui.progress.ProgressMonitor;
 import org.openstreetmap.josm.tools.Logging;
@@ -169 +168 @@
         mindist = Main.pref.getDouble(PREFIX + ".node_way_distance", 10.0);
         minmiddledist = Main.pref.getDouble(PREFIX + ".way_way_distance", 0.0);
-        DataSet dataSet = MainApplication.getLayerManager().getEditDataSet();
+        DataSet dataSet = Main.main.getEditDataSet();
         dsArea = dataSet == null ? null : dataSet.getDataSourceArea();
     }

trunk/src/org/openstreetmap/josm/data/validation/tests/UntaggedWay.java

@@ -9 +9 @@
 import java.util.Set;
 
+import org.openstreetmap.josm.Main;
 import org.openstreetmap.josm.command.Command;
 import org.openstreetmap.josm.data.osm.DataSet;
@@ -18 +19 @@
 import org.openstreetmap.josm.data.validation.Test;
 import org.openstreetmap.josm.data.validation.TestError;
-import org.openstreetmap.josm.gui.MainApplication;
 import org.openstreetmap.josm.gui.progress.ProgressMonitor;
 
@@ -142 +142 @@
     public void startTest(ProgressMonitor monitor) {
         super.startTest(monitor);
-        DataSet ds = MainApplication.getLayerManager().getEditDataSet();
+        DataSet ds = Main.main.getEditDataSet();
         if (ds == null)
             return;

trunk/src/org/openstreetmap/josm/gui/MainApplication.java

@@ -397 +397 @@
     }
 
+    @Override
+    public DataSet getEditDataSet() {
+        return getLayerManager().getEditDataSet();
+    }
+
     /**
      * Returns the command-line arguments used to run the application.

trunk/src/org/openstreetmap/josm/gui/tagging/presets/TaggingPreset.java

@@ -382 +382 @@
             return;
         }
-        DataSet ds = MainApplication.getLayerManager().getEditDataSet();
+        DataSet ds = Main.main.getEditDataSet();
         Collection<OsmPrimitive> participants = Collections.emptyList();
-        if (Main.main != null && ds != null) {
+        if (ds != null) {
             participants = ds.getSelected();
         }
@@ -556 +556 @@
 
     protected final void updateEnabledState() {
-        setEnabled(Main.main != null && MainApplication.getLayerManager().getEditDataSet() != null);
+        setEnabled(Main.main != null && Main.main.getEditDataSet() != null);
     }
 

trunk/src/org/openstreetmap/josm/gui/tagging/presets/TaggingPresetSearchPrimitiveDialog.java

@@ -87 +87 @@
             TaggingPreset preset = selector.getSelectedPresetAndUpdateClassification();
             if (preset != null) {
-                final Set<OsmPrimitive> matching = new HashSet<>(MainApplication.getLayerManager().getEditDataSet().getPrimitives(preset));
-                MainApplication.getLayerManager().getEditDataSet().setSelected(matching);
+                final Set<OsmPrimitive> matching = new HashSet<>(Main.main.getEditDataSet().getPrimitives(preset));
+                Main.main.getEditDataSet().setSelected(matching);
             }
         }

trunk/src/org/openstreetmap/josm/gui/tagging/presets/TaggingPresetSelector.java

@@ -236 +236 @@
         boolean inTags = ckSearchInTags != null && ckSearchInTags.isSelected();
 
-        DataSet ds = MainApplication.getLayerManager().getEditDataSet();
+        DataSet ds = Main.main.getEditDataSet();
         Collection<OsmPrimitive> selected = (ds == null) ? Collections.<OsmPrimitive>emptyList() : ds.getSelected();
         final List<PresetClassification> result = classifications.getMatchingPresets(
@@ -356 +356 @@
                 typesInSelectionDirty = false;
                 typesInSelection.clear();
-                if (Main.main == null || MainApplication.getLayerManager().getEditDataSet() == null) return typesInSelection;
-                for (OsmPrimitive primitive : MainApplication.getLayerManager().getEditDataSet().getSelected()) {
+                if (Main.main == null || Main.main.getEditDataSet() == null) return typesInSelection;
+                for (OsmPrimitive primitive : Main.main.getEditDataSet().getSelected()) {
                     typesInSelection.add(TaggingPresetType.forPrimitive(primitive));
                 }